Merge pull request github#852 from github/lcartey/m5-3-1-unevaluated-uninstantiated

M5-3-1: Exclude unknown types

Author: lcartey

change_notes/2025-02-06-m5-3-1-exclude-unknown-type.md

@@ -0,0 +1,2 @@
+ - `M5-3-1` - `EachOperandOfTheOperatorOfTheLogicalAndOrTheLogicalOperatorsShallHaveTypeBool.ql`:
+   - Consistently exclude results in unevaluated contexts associated with uninstantiated templates, for example `noexcept` specifiers and `static_assert`s.

cpp/autosar/src/rules/M5-3-1/EachOperandOfTheOperatorTheLogicalAndOrTheLogicalOperatorsShallHaveTypeBool.ql

@@ -25,6 +25,11 @@ where
   ) and
   t = operand.getType() and
   not t.getUnderlyingType().getUnspecifiedType() instanceof BoolType and
+  // Ignore cases where the type is unknown - this will typically be in unevaluated contexts
+  // within uninstantiated templates. It's necessary to check for this explicitly because
+  // not all unevaluated contexts are considered to be `isFromUninstantiatedTemplate(_)`,
+  // e.g. `noexcept` specifiers
+  not t instanceof UnknownType and
   not exists(ReferenceType rt |
     rt = t.getUnderlyingType().getUnspecifiedType() and rt.getBaseType() instanceof BoolType
   ) and

cpp/autosar/test/rules/M5-3-1/test.cpp

@@ -25,4 +25,13 @@ template <typename T = int> class A {
 void f() {
   A<int> a;
   a.test1();
-}
+}
+
+template <typename T> constexpr bool some_variable_template_v = false;
+template <> constexpr bool some_variable_template_v<int> = true;
+
+template <typename S>
+void template_with_no_except() noexcept(some_variable_template_v<S> &&
+                                        true) { // COMPLIANT
+}
+void test_template() { template_with_no_except<int>(); }