Rule 21.10.2: Detect more complex type use of jmp_buf

Author: lcartey

cpp/misra/src/rules/RULE-21-10-2/NoCsetjmpHeader.ql

@@ -16,13 +16,14 @@
 import cpp
 import codingstandards.cpp.misra
 import codingstandards.cpp.BannedFunctions
+import codingstandards.cpp.types.Uses
 
 class CSetJmpHeader extends Include {
   CSetJmpHeader() { this.getIncludeText().regexpMatch("[<\\\"](csetjmp|setjmp.h)[>\\\"]") }
 }
 
-class JmpBufVariable extends Variable {
-  JmpBufVariable() { this.getType().(UserType).hasGlobalOrStdName("jmp_buf") }
+class JmpBufType extends UserType {
+  JmpBufType() { this.hasGlobalOrStdName("jmp_buf") }
 }
 
 class LongjmpFunction extends Function {
@@ -39,9 +40,15 @@ where
   (
     message = "Use of banned header " + element.(CSetJmpHeader).getIncludeText() + "."
     or
-    message =
-      "Declaration of variable '" + element.(JmpBufVariable).getName() +
-        "' with banned type 'jmp_buf'."
+    (
+      element = getATypeUse(any(JmpBufType jbt)) and
+      if element instanceof Variable
+      then
+        message =
+          "Declaration of variable '" + element.(Variable).getName() +
+            "' with banned type 'jmp_buf'."
+      else message = "Use of banned type 'jmp_buf'."
+    )
     or
     message =
       element.(BannedFunctions<LongjmpFunction>::Use).getAction() + " banned function '" +

cpp/misra/test/rules/RULE-21-10-2/NoCsetjmpHeader.expected

@@ -12,3 +12,4 @@
 | test.cpp:21:5:21:16 | call to longjmp | Call to banned function 'longjmp'. |
 | test.cpp:26:11:26:12 | l1 | Declaration of variable 'l1' with banned type 'jmp_buf'. |
 | test.cpp:27:16:27:17 | l2 | Declaration of variable 'l2' with banned type 'jmp_buf'. |
+| test.cpp:40:38:40:39 | l1 | Declaration of variable 'l1' with banned type 'jmp_buf'. |

cpp/misra/test/rules/RULE-21-10-2/test.cpp

@@ -35,4 +35,6 @@ void test_compliant_alternative() {
   } catch (const std::runtime_error &) { // COMPLIANT
     // Handle error properly
   }
-}
+}
+
+void test_jmp_buf_usage() { jmp_buf *l1; } // NON_COMPLIANT - pointer to jmp_buf