Merge pull request thephpleague#57 from JohnstonCode/stream_reads

Added streamReads config option to aws provider

Author: tgalopin

docs/2-cloud-storage-providers.md

@@ -55,6 +55,7 @@ flysystem:
                 client: 'aws_client_service' # The service ID of the Aws\S3\S3Client instance
                 bucket: 'bucket_name'
                 prefix: 'optional/path/prefix'
+                streamReads: true
 ```
 
 ## Google Cloud Storage

src/Adapter/Builder/AwsAdapterDefinitionBuilder.php

@@ -48,6 +48,9 @@ protected function configureOptions(OptionsResolver $resolver)
 
         $resolver->setDefault('options', []);
         $resolver->setAllowedTypes('options', 'array');
+
+        $resolver->setDefault('streamReads', true);
+        $resolver->setAllowedTypes('streamReads', 'bool');
     }
 
     protected function configureDefinition(Definition $definition, array $options)
@@ -59,5 +62,6 @@ protected function configureDefinition(Definition $definition, array $options)
         $definition->setArgument(3, null);
         $definition->setArgument(4, null);
         $definition->setArgument(5, $options['options']);
+        $definition->setArgument(6, $options['streamReads']);
     }
 }

tests/Adapter/Builder/AwsAdapterDefinitionBuilderTest.php

@@ -62,6 +62,7 @@ public function testOptionsBehavior()
             'options' => [
                 'ServerSideEncryption' => 'AES256',
             ],
+            'streamReads' => false,
         ]);
 
         $this->assertSame(AwsS3V3Adapter::class, $definition->getClass());
@@ -70,5 +71,6 @@ public function testOptionsBehavior()
         $this->assertSame('bucket', $definition->getArgument(1));
         $this->assertSame('prefix/path', $definition->getArgument(2));
         $this->assertSame(['ServerSideEncryption' => 'AES256'], $definition->getArgument(5));
+        $this->assertFalse($definition->getArgument(6));
     }
 }