Merge pull request thephpleague#72 from VincentLanglet/patch-1

Allow null password for SFTP

Author: tgalopin

src/Adapter/Builder/SftpAdapterDefinitionBuilder.php

@@ -43,8 +43,8 @@ protected function configureOptions(OptionsResolver $resolver)
         $resolver->setRequired('username');
         $resolver->setAllowedTypes('username', 'string');
 
-        $resolver->setRequired('password');
-        $resolver->setAllowedTypes('password', 'string');
+        $resolver->setDefault('password', null);
+        $resolver->setAllowedTypes('password', ['string', 'null']);
 
         $resolver->setDefault('port', 22);
         $resolver->setAllowedTypes('port', 'scalar');

tests/Adapter/Builder/SftpAdapterDefinitionBuilderTest.php

@@ -27,7 +27,6 @@ public function provideValidOptions()
         yield 'minimal' => [[
             'host' => 'ftp.example.com',
             'username' => 'username',
-            'password' => 'password',
         ]];
 
         yield 'full' => [[
@@ -65,6 +64,7 @@ public function testOptionsBehavior()
         ]);
 
         $expected = [
+            'password' => 'password',
             'port' => 22,
             'root' => '/path/to/root',
             'privateKey' => '/path/to/or/contents/of/privatekey',
@@ -74,7 +74,6 @@ public function testOptionsBehavior()
             'permPublic' => 0744,
             'host' => 'ftp.example.com',
             'username' => 'username',
-            'password' => 'password',
         ];
 
         $this->assertSame(SftpAdapter::class, $definition->getClass());