Use PortableVisibilityConverter for LocalAdapter

Author: Lustmored

src/Adapter/Builder/LocalAdapterDefinitionBuilder.php

@@ -12,6 +12,7 @@
 namespace League\FlysystemBundle\Adapter\Builder;
 
 use League\Flysystem\Local\LocalFilesystemAdapter;
+use League\Flysystem\UnixVisibility\PortableVisibilityConverter;
 use Symfony\Component\DependencyInjection\Definition;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
@@ -66,8 +67,13 @@ protected function configureDefinition(Definition $definition, array $options)
     {
         $definition->setClass(LocalFilesystemAdapter::class);
         $definition->setArgument(0, $options['directory']);
-        $definition->setArgument(1, $options['lock']);
-        $definition->setArgument(2, $options['skip_links'] ? LocalFilesystemAdapter::SKIP_LINKS : LocalFilesystemAdapter::DISALLOW_LINKS);
-        $definition->setArgument(3, $options['permissions']);
+        $definition->setArgument(1,
+            (new Definition(PortableVisibilityConverter::class))
+            ->setFactory([PortableVisibilityConverter::class, 'fromArray'])
+            ->addArgument($options['permissions'])
+            ->setShared(false)
+        );
+        $definition->setArgument(2, $options['lock']);
+        $definition->setArgument(3, $options['skip_links'] ? LocalFilesystemAdapter::SKIP_LINKS : LocalFilesystemAdapter::DISALLOW_LINKS);
     }
 }

tests/Adapter/Builder/LocalAdapterDefinitionBuilderTest.php

@@ -85,11 +85,11 @@ public function testOptionsBehavior()
     {
         $permissions = [
             'file' => [
-                'public' => 0755,
-                'private' => 0755,
+                'public' => 0666,
+                'private' => 0644,
             ],
             'dir' => [
-                'public' => 0755,
+                'public' => 0777,
                 'private' => 0755,
             ],
         ];
@@ -103,8 +103,8 @@ public function testOptionsBehavior()
 
         $this->assertSame(LocalFilesystemAdapter::class, $definition->getClass());
         $this->assertSame(__DIR__, $definition->getArgument(0));
-        $this->assertSame(LOCK_EX, $definition->getArgument(1));
-        $this->assertSame(LocalFilesystemAdapter::SKIP_LINKS, $definition->getArgument(2));
-        $this->assertSame($permissions, $definition->getArgument(3));
+        $this->assertSame($permissions, $definition->getArgument(1)->getArgument(0));
+        $this->assertSame(LOCK_EX, $definition->getArgument(2));
+        $this->assertSame(LocalFilesystemAdapter::SKIP_LINKS, $definition->getArgument(3));
     }
 }