Skip to content

Commit 21e02ac

Browse files
authored
Bugfix: Improved conditional visibility for 'HTTP Response' page section (#617)
* Resolved #616 by updating visibility rules on LogEntryRecordPage to show the HTTP Response section if the response status, body, or header keys are not null. Previously, only status was checked, which is null when using System.Continuation * Upgraded most of the devDependencies in package.json, and hopefully fixed package generation for the managed package by including an empty copy of Admin.profile-meta.xml ಥ_ಥ. Also updated both sfdx-project.json files to use the new flag 'scopeProfiles' * Added (re-added) new-ish Analytics standard tab to the LoggerConsole app * Fixed some test failures in ComponentLogger_Tests that occurred when running in a namespaced context
1 parent d452edd commit 21e02ac

14 files changed

Lines changed: 7820 additions & 13480 deletions

File tree

.forceignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
nebula-logger/managed-package/sfdx-project.json
66
nebula-logger/managed-package/**/*.animationRule-meta.xml
77
nebula-logger/managed-package/**/*.testSuite-meta.xml
8-
/**/Admin.profile-meta.xml
98

109
# Directory/package-specific README files
1110
**/README.md

.github/workflows/build.yml

Lines changed: 33 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -264,48 +264,39 @@ jobs:
264264
runs-on: ubuntu-latest
265265
environment: 'Demo Org'
266266
steps:
267-
# - name: 'Checkout source code'
268-
# uses: actions/checkout@v3
269-
# with:
270-
# ref: ${{ github.event.pull_request.head.ref }}
271-
272-
# - name: 'Restore node_modules cache'
273-
# id: cache-npm
274-
# uses: actions/cache@v3
275-
# with:
276-
# path: node_modules
277-
# key: npm-${{ hashFiles('**/package-lock.json') }}
278-
# restore-keys: |
279-
# npm-${{ env.cache-name }}-
280-
# npm-
281-
282-
# - name: 'Install npm dependencies'
283-
# if: steps.cache-npm.outputs.cache-hit != 'true'
284-
# run: npm ci
285-
286-
# - name: 'Authorize Dev Hub'
287-
# shell: bash
288-
# run: |
289-
# npx sf version
290-
# echo "${{ env.DEV_HUB_JWT_SERVER_KEY }}" > ./jwt-server.key
291-
# npx sf org login jwt --instance-url ${{ env.DEV_HUB_AUTH_URL }} --client-id ${{ env.DEV_HUB_CONSUMER_KEY }} --username ${{ env.DEV_HUB_BOT_USERNAME }} --jwt-key-file ./jwt-server.key --set-default-dev-hub
292-
# env:
293-
# DEV_HUB_AUTH_URL: ${{ secrets.DEV_HUB_AUTH_URL }}
294-
# DEV_HUB_BOT_USERNAME: ${{ secrets.DEV_HUB_BOT_USERNAME }}
295-
# DEV_HUB_CONSUMER_KEY: ${{ secrets.DEV_HUB_CONSUMER_KEY }}
296-
# DEV_HUB_JWT_SERVER_KEY: ${{ secrets.DEV_HUB_JWT_SERVER_KEY }}
297-
298-
# # TODO remove this after the plugin @salesforce/packaging has been upgraded
299-
# # to a new version that only looks at package directories
300-
# - name: 'Temporarily delete problematic metadata'
301-
# run: |
302-
# rm -rf ./config/experience-cloud/
303-
304-
# - name: 'Create Beta Managed Package Version'
305-
# run: npm run package:version:create:managed
306-
307-
- name: 'Placeholder because the sf cli and its plugins are trash'
308-
run: echo hello
267+
- name: 'Checkout source code'
268+
uses: actions/checkout@v3
269+
with:
270+
ref: ${{ github.event.pull_request.head.ref }}
271+
272+
- name: 'Restore node_modules cache'
273+
id: cache-npm
274+
uses: actions/cache@v3
275+
with:
276+
path: node_modules
277+
key: npm-${{ hashFiles('**/package-lock.json') }}
278+
restore-keys: |
279+
npm-${{ env.cache-name }}-
280+
npm-
281+
282+
- name: 'Install npm dependencies'
283+
if: steps.cache-npm.outputs.cache-hit != 'true'
284+
run: npm ci
285+
286+
- name: 'Authorize Dev Hub'
287+
shell: bash
288+
run: |
289+
npx sf version
290+
echo "${{ env.DEV_HUB_JWT_SERVER_KEY }}" > ./jwt-server.key
291+
npx sf org login jwt --instance-url ${{ env.DEV_HUB_AUTH_URL }} --client-id ${{ env.DEV_HUB_CONSUMER_KEY }} --username ${{ env.DEV_HUB_BOT_USERNAME }} --jwt-key-file ./jwt-server.key --set-default-dev-hub
292+
env:
293+
DEV_HUB_AUTH_URL: ${{ secrets.DEV_HUB_AUTH_URL }}
294+
DEV_HUB_BOT_USERNAME: ${{ secrets.DEV_HUB_BOT_USERNAME }}
295+
DEV_HUB_CONSUMER_KEY: ${{ secrets.DEV_HUB_CONSUMER_KEY }}
296+
DEV_HUB_JWT_SERVER_KEY: ${{ secrets.DEV_HUB_JWT_SERVER_KEY }}
297+
298+
- name: 'Create Beta Managed Package Version'
299+
run: npm run package:version:create:managed
309300

310301
create-unlocked-package-release-candidate:
311302
name: 'Create Core Package Release Candidate'
@@ -353,13 +344,6 @@ jobs:
353344
env:
354345
PKG_DEMO_ORG_SFDX_URL: ${{ secrets.NEBULA_PKG_DEMO_SANDBOX_SFDX_URL }}
355346

356-
# TODO remove this after the plugin @salesforce/packaging has been upgraded
357-
# to a new version that only looks at package directories
358-
- name: 'Temporarily delete problematic metadata'
359-
run: |
360-
rm -rf ./config/experience-cloud/
361-
rm -rf ./nebula-logger/unsorted/main/default/profiles/
362-
363347
- name: 'Create & Install Package Version'
364348
run: npx pwsh ./scripts/build/create-and-install-package-version.ps1 -targetpackagealias '"Nebula Logger - Core"' -targetreadme ./README.md -targetusername nebula-logger-package-demo
365349

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@
55

66
The most robust logger for Salesforce. Works with Apex, Lightning Components, Flow, Process Builder & Integrations. Designed for Salesforce admins, developers & architects.
77

8-
## Unlocked Package - v4.12.7
8+
## Unlocked Package - v4.12.8
99

10-
[![Install Unlocked Package in a Sandbox](./images/btn-install-unlocked-package-sandbox.png)](https://test.salesforce.com/packaging/installPackage.apexp?p0=04t5Y000001Mk6IQAS)
11-
[![Install Unlocked Package in Production](./images/btn-install-unlocked-package-production.png)](https://login.salesforce.com/packaging/installPackage.apexp?p0=04t5Y000001Mk6IQAS)
10+
[![Install Unlocked Package in a Sandbox](./images/btn-install-unlocked-package-sandbox.png)](https://test.salesforce.com/packaging/installPackage.apexp?p0=04t5Y000001Mk6cQAC)
11+
[![Install Unlocked Package in Production](./images/btn-install-unlocked-package-production.png)](https://login.salesforce.com/packaging/installPackage.apexp?p0=04t5Y000001Mk6cQAC)
1212
[![View Documentation](./images/btn-view-documentation.png)](https://jongpie.github.io/NebulaLogger/)
1313

14-
`sf package install --wait 20 --security-type AdminsOnly --package 04t5Y000001Mk6IQAS`
14+
`sf package install --wait 20 --security-type AdminsOnly --package 04t5Y000001Mk6cQAC`
1515

16-
`sfdx force:package:install --wait 20 --securitytype AdminsOnly --package 04t5Y000001Mk6IQAS`
16+
`sfdx force:package:install --wait 20 --securitytype AdminsOnly --package 04t5Y000001Mk6cQAC`
1717

1818
---
1919

nebula-logger/core/main/log-management/applications/LoggerConsole.app-meta.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
<tabs>LogEntry__c</tabs>
2727
<tabs>LogEntryTag__c</tabs>
2828
<tabs>LoggerTag__c</tabs>
29+
<tabs>standard-WaveHomeLightning</tabs>
2930
<tabs>standard-report</tabs>
3031
<tabs>standard-Dashboard</tabs>
3132
<uiType>Lightning</uiType>
@@ -51,6 +52,9 @@
5152
<mappings>
5253
<tab>standard-Dashboard</tab>
5354
</mappings>
55+
<mappings>
56+
<tab>standard-WaveHomeLightning</tab>
57+
</mappings>
5458
<mappings>
5559
<tab>standard-home</tab>
5660
</mappings>

nebula-logger/core/main/log-management/flexipages/LogEntryRecordPage.flexipage-meta.xml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -816,10 +816,21 @@
816816
<componentName>flexipage:fieldSection</componentName>
817817
<identifier>flexipage_fieldSection10</identifier>
818818
<visibilityRule>
819+
<booleanFilter>1 OR 2 OR 3</booleanFilter>
819820
<criteria>
820821
<leftValue>{!Record.HttpResponseStatus__c}</leftValue>
821822
<operator>NE</operator>
822823
</criteria>
824+
<criteria>
825+
<leftValue>{!Record.HasHttpResponseBody__c}</leftValue>
826+
<operator>EQUAL</operator>
827+
<rightValue>true</rightValue>
828+
</criteria>
829+
<criteria>
830+
<leftValue>{!Record.HasHttpResponseHeaderKeys__c}</leftValue>
831+
<operator>EQUAL</operator>
832+
<rightValue>true</rightValue>
833+
</criteria>
823834
</visibilityRule>
824835
</componentInstance>
825836
</itemInstances>

nebula-logger/core/main/logger-engine/classes/Logger.cls

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
global with sharing class Logger {
1616
// There's no reliable way to get the version number dynamically in Apex
1717
@TestVisible
18-
private static final String CURRENT_VERSION_NUMBER = 'v4.12.7';
18+
private static final String CURRENT_VERSION_NUMBER = 'v4.12.8';
1919
private static final System.LoggingLevel FALLBACK_LOGGING_LEVEL = System.LoggingLevel.DEBUG;
2020
private static final Set<String> IGNORED_APEX_CLASSES = initializeIgnoredApexClasses();
2121
private static final List<LogEntryEventBuilder> LOG_ENTRIES_BUFFER = new List<LogEntryEventBuilder>();

nebula-logger/core/main/logger-engine/lwc/logger/logger.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import { LightningElement, api } from 'lwc';
77
import { createLoggerService } from './loggerService';
88

9-
const CURRENT_VERSION_NUMBER = 'v4.12.7';
9+
const CURRENT_VERSION_NUMBER = 'v4.12.8';
1010

1111
export default class Logger extends LightningElement {
1212
#loggerService = createLoggerService();

0 commit comments

Comments
 (0)