Skip to content

Commit 29ae9bc

Browse files
committed
fix settting ceritificate.serial = number (change detection could not have worked)
1 parent 0bd2bd4 commit 29ae9bc

1 file changed

Lines changed: 2 additions & 5 deletions

File tree

src/main/java/org/jruby/ext/openssl/X509Cert.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -409,17 +409,14 @@ public IRubyObject serial() {
409409

410410
@JRubyMethod(name = "serial=")
411411
public IRubyObject set_serial(final IRubyObject serial) {
412-
if ( ! serial.equals(this.serial) ) {
413-
this.changed = true;
414-
}
415-
416-
final String serialStr = serial.toString();
412+
final String serialStr = serial.asString().toString();
417413
final BigInteger serialInt;
418414
if ( serialStr.equals("0") ) { // MRI compatibility: allow 0 serial number
419415
serialInt = BigInteger.ONE;
420416
} else {
421417
serialInt = new BigInteger(serialStr);
422418
}
419+
this.changed = ! serialInt.equals(this.serial);
423420
//generator.setSerialNumber( serialInt.abs() );
424421
this.serial = serialInt; return serial;
425422
}

0 commit comments

Comments
 (0)