we better not throw EOF on SSLSocket#sysclose for compatibility with MRI

Author: kares

src/main/java/org/jruby/ext/openssl/SSLSocket.java

@@ -883,12 +883,11 @@ private void forceClose() {
         close(true);
     }
 
-    //private boolean closed;
-
     private void close(boolean force)  {
-        //closed = true;
-
-        if ( engine == null ) throw getRuntime().newEOFError();
+        if ( engine == null ) {
+            // if ( force ) throw getRuntime().newEOFError();
+            return;
+        }
 
         engine.closeOutbound();
 
@@ -903,8 +902,6 @@ private void close(boolean force)  {
         }
     }
 
-    //final boolean isClosed() { return closed; }
-
     @JRubyMethod
     public IRubyObject sysclose(final ThreadContext context) {
         //if ( isClosed() ) return context.runtime.getNil();

src/test/ruby/ssl/test_socket.rb

@@ -42,4 +42,16 @@ def test_attr_methods
     socket.inspect
   end
 
+  def test_sync_close_without_connect
+    require 'socket'
+    Socket.open(:INET, :STREAM) do |socket|
+      assert ! socket.closed?
+      ssl = OpenSSL::SSL::SSLSocket.new(socket)
+      ssl.sync_close = true
+      assert ! ssl.closed?
+      ssl.close
+      assert socket.closed?
+    end
+  end
+
 end