refactor naming of "get"-ers returning random values/integers

Author: kares

src/main/java/org/jruby/ext/openssl/BN.java

@@ -794,28 +794,28 @@ public static BigInteger getRandomBI(int bits, int top, boolean bottom, Random r
 
     @JRubyMethod(name = "rand_range", meta = true)
     public static IRubyObject rand_range(IRubyObject recv, IRubyObject arg) {
-        return getRandomBNInRange(recv.getRuntime(), getBigInteger(arg), getSecureRandom());
+        return randomValueInRange(recv.getRuntime(), getBigInteger(arg), getSecureRandom());
     }
 
     @JRubyMethod(name = "pseudo_rand_range", meta = true)
     public static IRubyObject pseudo_rand_range(IRubyObject recv, IRubyObject arg) {
-        return getRandomBNInRange(recv.getRuntime(), getBigInteger(arg), getRandom());
+        return randomValueInRange(recv.getRuntime(), getBigInteger(arg), getRandom());
     }
 
-    private static BN getRandomBNInRange(Ruby runtime, BigInteger limit, Random random) {
+    private static BN randomValueInRange(Ruby runtime, BigInteger limit, Random random) {
         BigInteger value;
         try {
-            value = getRandomBIInRange(limit, random);
+            value = randomIntegerInRange(limit, random);
         }
         catch (IllegalArgumentException e) {
-            throw newBNError(runtime, "illegal range");
+            throw newBNError(runtime, e.getMessage());
         }
-        return newBN(runtime, value);
+        return newInstance(runtime, value);
     }
 
-    public static BigInteger getRandomBIInRange(BigInteger limit, Random random) {
+    public static BigInteger randomIntegerInRange(BigInteger limit, Random random) {
         if (limit.signum() < 0) {
-            throw new IllegalArgumentException("illegal range");
+            throw new IllegalArgumentException("illegal range: " + limit);
         }
         int bits = limit.bitLength();
         BigInteger value;

src/main/java/org/jruby/ext/openssl/PKeyDH.java

@@ -60,7 +60,6 @@
 import org.jruby.util.ByteList;
 import org.jruby.runtime.Visibility;
 
-import static org.jruby.ext.openssl.PKey._PKey;
 import static org.jruby.ext.openssl.OpenSSL.bcExceptionMessage;
 
 /**
@@ -209,9 +208,9 @@ public static BigInteger generateX(BigInteger p, int limit) {
         // subject to Miller-Rabin [certainty = 0], but is subject to other constraints)
         // see also [ossl]/crypto/dh/dh_key.c #generate_key
         if (limit == 0) {
-            BigInteger pSub2 = p.subtract(TWO);
+            final BigInteger pSub2 = p.subtract(TWO);
             do {
-                x = BN.getRandomBIInRange(pSub2, secureRandom);
+                x = BN.randomIntegerInRange(pSub2, secureRandom);
             } while (x.equals(BigInteger.ZERO));
         } else {
             do {