Skip to content

Commit 2d2968d

Browse files
igorDykhtaIhor Dykhta
andauthored
chore: upgrade to node 20 (#3387)
* chore: upgrade to node 20 Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com> * upgrade gl 6->8 Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com> * more fixes Signed-off-by: Ihor Dykhta <ihordykhta@Ihors-MacBook-Pro.local> * restore TextDecoder and TextEncoder polyfills Signed-off-by: Ihor Dykhta <ihordykhta@Ihors-MacBook-Pro.local> * more minor changes Signed-off-by: Ihor Dykhta <ihordykhta@Ihors-MacBook-Pro.local> * maint Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com> --------- Signed-off-by: Ihor Dykhta <dikhta.igor@gmail.com> Signed-off-by: Ihor Dykhta <ihordykhta@Ihors-MacBook-Pro.local> Co-authored-by: Ihor Dykhta <ihordykhta@Ihors-MacBook-Pro.local>
1 parent dd403d4 commit 2d2968d

35 files changed

Lines changed: 176 additions & 402 deletions

File tree

.github/workflows/npmpublish.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ jobs:
1919

2020
- run: yarn install
2121
- run: yarn bootstrap
22-
- run: npm i -g npm@8.19.2
23-
2422
- name: Login to NPM
2523
run: npm config set "//registry.npmjs.org/:_authToken=${NPM_AUTH_TOKEN}"
2624

.github/workflows/test.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,6 @@ jobs:
1313
build:
1414
runs-on: ubuntu-latest
1515

16-
strategy:
17-
matrix:
18-
node-version: [18.x]
19-
2016
steps:
2117
- uses: actions/checkout@v4
2218
# use Volta to manage yarn/node versions

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
18.18.2
1+
20.19.3

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,9 @@ Kepler.gl is also a React component that uses [Redux](https://redux.js.org/) to
5151

5252
## Env
5353

54-
For **developing this repository**, use Node **18.18.2** (see `.nvmrc`): run `nvm install` and `nvm use`. Newer Node versions can make `yarn install` / `yarn bootstrap` try to compile the `gl` dev dependency from source; if that fails, see [Troubleshooting: gl package install](contributing/DEVELOPERS.md#troubleshooting-gl-package-install).
54+
For **developing this repository**, use Node **20.19.3** (see `.nvmrc`): run `nvm install` and `nvm use`. Newer Node versions can make `yarn install` / `yarn bootstrap` try to compile the `gl` dev dependency from source; if that fails, see [Troubleshooting: gl package install](contributing/DEVELOPERS.md#troubleshooting-gl-package-install).
5555

56-
When **using kepler.gl as a dependency** in your own app, use Node 18.18.2 or a supported LTS; older Node versions are not supported or tested.
56+
When **using kepler.gl as a dependency** in your own app, use Node 20.19.3 or a supported LTS; older Node versions are not supported or tested.
5757

5858
## Install kepler.gl modules
5959

bindings/kepler.gl-jupyter/js/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,10 +113,10 @@
113113
}
114114
},
115115
"engines": {
116-
"node": ">=18"
116+
"node": ">=20"
117117
},
118118
"volta": {
119-
"node": "18.18.2",
119+
"node": "20.19.3",
120120
"yarn": "4.4.0"
121121
},
122122
"packageManager": "yarn@4.4.0"

contributing/DEVELOPERS.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Before you can build Kepler.gl, you must install and configure the following dep
2323

2424
- [Git](http://git-scm.com/): The [Github Guide to Installing Git][git-setup] is a good source of information.
2525

26-
- [Node.js ^18.x](http://nodejs.org): We use Node to generate the documentation, run a
26+
- [Node.js ^20.x](http://nodejs.org): We use Node to generate the documentation, run a
2727
development web server, run tests, and generate distributable files. Depending on your system,
2828
you can install Node either from source or as a pre-packaged bundle.
2929

@@ -131,7 +131,7 @@ Yarn may report that the `gl` package (a dev dependency used for headless WebGL
131131

132132
**What to do**
133133

134-
- **Prefer the Node version pinned for this repo** (see `.nvmrc`, currently 18.18.2). After `nvm install` and `nvm use` (or Volta, as above), run `yarn install` / `yarn bootstrap` again. A matching prebuild is often available, so the native compile step never runs.
134+
- **Prefer the Node version pinned for this repo** (see `.nvmrc`, currently 20.19.3). After `nvm install` and `nvm use` (or Volta, as above), run `yarn install` / `yarn bootstrap` again. A matching prebuild is often available, so the native compile step never runs.
135135

136136
- **If you must use a newer Node** and the install compiles from source, ensure `python` is on your `PATH` and points to Python 3, for example on macOS:
137137

docs/api-reference/get-started.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
### Installation
44

5-
Use <b>Node v18</b> and above, older node versions have not been tested
5+
Use <b>Node v20</b> and above, older node versions have not been tested
66

77
```sh
88
npm install --save kepler.gl @kepler.gl/components @kepler.gl/reducers

examples/demo-app/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
This is the src code of kepler.gl demo app. You can copy this folder out and run it locally.
44

55
#### Pre requirement
6-
- [Node.js ^18.x](http://nodejs.org): We use Node to generate the documentation, run a
6+
- [Node.js ^20.x](http://nodejs.org): We use Node to generate the documentation, run a
77
development web server, run tests, and generate distributable files. Depending on your system,
88
you can install Node either from source or as a pre-packaged bundle.
99
- [Yarn 4.4.0](https://yarnpkg.com): We use Yarn to install our Node.js module dependencies
@@ -17,7 +17,7 @@ Go to the root directory and install the dependencies using yarn:
1717
yarn bootstrap
1818
```
1919

20-
If install fails while building the `gl` package, use Node 18.18.2 from the repo root `.nvmrc` (`nvm install` / `nvm use`), or see [Troubleshooting: gl package install](../../contributing/DEVELOPERS.md#troubleshooting-gl-package-install).
20+
If install fails while building the `gl` package, use Node 20.19.3 from the repo root `.nvmrc` (`nvm install` / `nvm use`), or see [Troubleshooting: gl package install](../../contributing/DEVELOPERS.md#troubleshooting-gl-package-install).
2121

2222
If `yarn start` errors with missing `@kepler.gl/duckdb/components` (or other workspace `dist/` files), from the repo root run `yarn workspaces foreach -At run stab` or run full `yarn bootstrap` (not only `yarn install`).
2323

examples/demo-app/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,10 @@
6666
"react-vis": "1.11.7"
6767
},
6868
"engines": {
69-
"node": ">=18"
69+
"node": ">=20"
7070
},
7171
"volta": {
72-
"node": "18.18.2",
72+
"node": "20.19.3",
7373
"yarn": "4.4.0"
7474
},
7575
"packageManager": "yarn@4.4.0",

examples/get-started/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
},
1818
"devDependencies": {
1919
"@types/mapbox-gl": "^2.7.10",
20-
"@types/node": "^18.15.3",
20+
"@types/node": "^20",
2121
"@types/react": "^18.0.28",
2222
"@types/react-dom": "^18.0.11",
2323
"assert": "^2.1.0",

0 commit comments

Comments
 (0)