Skip to content

Commit 7b88a36

Browse files
committed
test: update remaining test expectations for average aggregation default
Update state-saved-v0 fixture and vis-state-test lineChart expected values to match the new average aggregation behavior: - yDomain starts at 1 instead of 0 (zero bins excluded) - Lines split into segments at zero-value gaps - Markers populated with all data points - allTime value recalculated for average Signed-off-by: pierreeurope <pierre.europe@pm.me>
1 parent f67bf30 commit 7b88a36

2 files changed

Lines changed: 27 additions & 16 deletions

File tree

test/fixtures/state-saved-v0.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -901,7 +901,7 @@ export const mergedFilters = [
901901
interval: '5-second',
902902
defaultTimeFormat: 'L LTS',
903903
type: 'histogram',
904-
aggregation: 'sum'
904+
aggregation: 'average'
905905
},
906906
yAxis: null,
907907
domain: [1453770124000, 1453770810000],

test/node/reducers/vis-state-test.js

Lines changed: 26 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3388,7 +3388,7 @@ test('#visStateReducer -> SET_FILTER_PLOT.yAxis', t => {
33883388
},
33893389
yAxis: yAxisField,
33903390
lineChart: {
3391-
yDomain: [0, 12124],
3391+
yDomain: [1, 12124],
33923392
xDomain: [1474070985000, 1474072215000],
33933393
interval: '15-second',
33943394
aggregation: 'average',
@@ -3402,29 +3402,40 @@ test('#visStateReducer -> SET_FILTER_PLOT.yAxis', t => {
34023402
{x: 1474071240000, y: 5, delta: 'last', pct: 0.25},
34033403
{x: 1474071300000, y: 12124, delta: 'last', pct: 2423.8},
34043404
{x: 1474071360000, y: 222, delta: 'last', pct: -0.9816892114813592},
3405-
{x: 1474071420000, y: 345, delta: 'last', pct: 0.5540540540540541},
3406-
{x: 1474071480000, y: 0, delta: 'last', pct: -1},
3407-
{x: 1474071540000, y: 0, delta: 'last', pct: null},
3408-
{x: 1474071555000, y: 0, delta: 'last', pct: null},
3409-
{x: 1474071600000, y: 0, delta: 'last', pct: null},
3410-
{x: 1474071675000, y: 0, delta: 'last', pct: null},
3411-
{x: 1474071735000, y: 0, delta: 'last', pct: null},
3412-
{x: 1474071795000, y: 0, delta: 'last', pct: null},
3413-
{x: 1474071855000, y: 1, delta: 'last', pct: null},
3414-
{x: 1474071915000, y: 0, delta: 'last', pct: -1},
3405+
{x: 1474071420000, y: 345, delta: 'last', pct: 0.5540540540540541}
3406+
],
3407+
[
3408+
{x: 1474071855000, y: 1, delta: 'last', pct: null}
3409+
],
3410+
[
34153411
{x: 1474071975000, y: 43, delta: 'last', pct: null},
34163412
{x: 1474072050000, y: 4, delta: 'last', pct: -0.9069767441860465},
3417-
{x: 1474072110000, y: 5, delta: 'last', pct: 0.25},
3418-
{x: 1474072170000, y: 0, delta: 'last', pct: -1},
3413+
{x: 1474072110000, y: 5, delta: 'last', pct: 0.25}
3414+
],
3415+
[
34193416
{x: 1474072200000, y: 6.5, delta: 'last', pct: null}
34203417
]
34213418
],
3422-
markers: []
3419+
markers: [
3420+
{x: 1474070985000, y: 1, delta: 'last', pct: null},
3421+
{x: 1474071045000, y: 2, delta: 'last', pct: 1},
3422+
{x: 1474071105000, y: 3, delta: 'last', pct: 0.5},
3423+
{x: 1474071165000, y: 4, delta: 'last', pct: 0.3333333333333333},
3424+
{x: 1474071240000, y: 5, delta: 'last', pct: 0.25},
3425+
{x: 1474071300000, y: 12124, delta: 'last', pct: 2423.8},
3426+
{x: 1474071360000, y: 222, delta: 'last', pct: -0.9816892114813592},
3427+
{x: 1474071420000, y: 345, delta: 'last', pct: 0.5540540540540541},
3428+
{x: 1474071855000, y: 1, delta: 'last', pct: null},
3429+
{x: 1474071975000, y: 43, delta: 'last', pct: null},
3430+
{x: 1474072050000, y: 4, delta: 'last', pct: -0.9069767441860465},
3431+
{x: 1474072110000, y: 5, delta: 'last', pct: 0.25},
3432+
{x: 1474072200000, y: 6.5, delta: 'last', pct: null}
3433+
]
34233434
},
34243435
yAxis: 'uid',
34253436
title: 'Average of uid',
34263437
fieldType: 'integer',
3427-
allTime: {title: 'All Time Average', value: 580.25},
3438+
allTime: {title: 'All Time Average', value: 981.9615384615385},
34283439
bins
34293440
},
34303441
speed: 1,

0 commit comments

Comments
 (0)