Skip to content

Commit 3d279b2

Browse files
Update Go SDK to 233b087 and surface telemetry storage state
- Bump github.com/kernel/kernel-go-sdk to 233b08772b836be24a9851d88122c39b1ed2c365 (adds telemetry.storage to browser, browser pool, and auth connection telemetry configs). - printTelemetrySummary now reports when a session's telemetry storage is off. No request flag is added: storage.enabled defaults to true and the API currently rejects false, so there is no usable value to expose yet. Tested: go build ./..., go test ./...; browsers create --telemetry=all, browsers get -o json, browsers delete against production. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent fc7410c commit 3d279b2

4 files changed

Lines changed: 19 additions & 3 deletions

File tree

‎cmd/browsers_telemetry.go‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -451,6 +451,11 @@ func printTelemetrySummary(cfg kernel.BrowserTelemetryConfig) {
451451
pterm.Info.Println("Telemetry exporting over OTLP")
452452
}
453453
}
454+
// Storage defaults on and is omitted for browsers created before the setting
455+
// existed, so only call it out when the response reports it off.
456+
if cfg.Storage.JSON.Enabled.Valid() && !cfg.Storage.Enabled {
457+
pterm.Info.Println("Telemetry storage: off (events are only available on the live stream and through any configured export)")
458+
}
454459
}
455460

456461
// formatCdpExcludedMethods renders the CDP methods left out of control

‎cmd/browsers_telemetry_test.go‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -503,6 +503,17 @@ func TestPrintTelemetrySummary_Export(t *testing.T) {
503503
printTelemetrySummary(parse(`{"browser":{"control":{"enabled":true}},"export":{"otlp":{"enabled":false}}}`))
504504
assert.NotContains(t, outBuf.String(), "OTLP")
505505
})
506+
t.Run("reports storage when off", func(t *testing.T) {
507+
setupStdoutCapture(t)
508+
printTelemetrySummary(parse(`{"browser":{"control":{"enabled":true}},"storage":{"enabled":false}}`))
509+
assert.Contains(t, outBuf.String(), "Telemetry storage: off")
510+
})
511+
t.Run("stays quiet when storage is on or omitted", func(t *testing.T) {
512+
setupStdoutCapture(t)
513+
printTelemetrySummary(parse(`{"browser":{"control":{"enabled":true}},"storage":{"enabled":true}}`))
514+
printTelemetrySummary(parse(`{"browser":{"control":{"enabled":true}}}`))
515+
assert.NotContains(t, outBuf.String(), "storage")
516+
})
506517
}
507518

508519
func TestTelemetryEnabledCategories(t *testing.T) {

‎go.mod‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ require (
99
github.com/charmbracelet/lipgloss/v2 v2.0.0-beta.1
1010
github.com/golang-jwt/jwt/v5 v5.2.2
1111
github.com/joho/godotenv v1.5.1
12-
github.com/kernel/kernel-go-sdk v0.113.0
12+
github.com/kernel/kernel-go-sdk v0.113.1-0.20260928141944-233b08772b83
1313
github.com/klauspost/compress v1.18.5
1414
github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c
1515
github.com/pterm/pterm v0.12.80

‎go.sum‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,8 @@ github.com/inconshreveable/mousetrap v1.1.0 h1:wN+x4NVGpMsO7ErUn/mUI3vEoE6Jt13X2
6666
github.com/inconshreveable/mousetrap v1.1.0/go.mod h1:vpF70FUmC8bwa3OWnCshd2FqLfsEA9PFc4w1p2J65bw=
6767
github.com/joho/godotenv v1.5.1 h1:7eLL/+HRGLY0ldzfGMeQkb7vMd0as4CfYvUVzLqw0N0=
6868
github.com/joho/godotenv v1.5.1/go.mod h1:f4LDr5Voq0i2e/R5DDNOoa2zzDfwtkZa6DnEwAbqwq4=
69-
github.com/kernel/kernel-go-sdk v0.113.0 h1:boOFcXfKpJIDkTFImSgoCm5//I/25pzLRnGSugQC8d8=
70-
github.com/kernel/kernel-go-sdk v0.113.0/go.mod h1:EeZzSuHZVeHKxKCPUzxou2bovNGhXaz0RXrSqKNf1AQ=
69+
github.com/kernel/kernel-go-sdk v0.113.1-0.20260928141944-233b08772b83 h1:zIzMv0Jt6Tc3rE+i3APw7+t2+EWgpPl4+BOLTlba+tU=
70+
github.com/kernel/kernel-go-sdk v0.113.1-0.20260928141944-233b08772b83/go.mod h1:EeZzSuHZVeHKxKCPUzxou2bovNGhXaz0RXrSqKNf1AQ=
7171
github.com/klauspost/compress v1.18.5 h1:/h1gH5Ce+VWNLSWqPzOVn6XBO+vJbCNGvjoaGBFW2IE=
7272
github.com/klauspost/compress v1.18.5/go.mod h1:cwPg85FWrGar70rWktvGQj8/hthj3wpl0PGDogxkrSQ=
7373
github.com/klauspost/cpuid/v2 v2.0.9/go.mod h1:FInQzS24/EEf25PyTYn52gqo7WaD8xa0213Md/qVLRg=

0 commit comments

Comments
 (0)