|
| 1 | +from datetime import datetime, timedelta, timezone as dt_timezone |
| 2 | +from unittest.mock import patch |
| 3 | + |
| 4 | +import pytest |
| 5 | + |
| 6 | +from kernelCI_app.helpers.dateRange import resolve_date_range |
| 7 | + |
| 8 | +FIXED_NOW = datetime(2026, 4, 6, 12, 0, 0, tzinfo=dt_timezone.utc) |
| 9 | + |
| 10 | +# Arbitrary round-number timestamps ~5 days apart, no domain significance. |
| 11 | +# Chosen for readability; any two valid timestamps where start < end would work. |
| 12 | +# 2023-11-14 22:13:20 UTC |
| 13 | +NOV_14_2023_TS = "1700000000" |
| 14 | +NOV_14_2023 = datetime(2023, 11, 14, 22, 13, 20, tzinfo=dt_timezone.utc) |
| 15 | + |
| 16 | +# 2023-11-19 22:13:20 UTC (5 days later) |
| 17 | +NOV_19_2023_TS = "1700432000" |
| 18 | +NOV_19_2023 = datetime(2023, 11, 19, 22, 13, 20, tzinfo=dt_timezone.utc) |
| 19 | + |
| 20 | + |
| 21 | +class TestResolveDateRange: |
| 22 | + """Unit tests for resolve_date_range.""" |
| 23 | + |
| 24 | + @patch("kernelCI_app.helpers.dateRange.now", return_value=FIXED_NOW) |
| 25 | + def test_defaults_when_no_timestamps(self, _mock_now): |
| 26 | + """Both None → end=now, start=now-7d.""" |
| 27 | + start, end = resolve_date_range(start_timestamp=None, end_timestamp=None) |
| 28 | + |
| 29 | + assert end == FIXED_NOW |
| 30 | + assert start == FIXED_NOW - timedelta(days=7) |
| 31 | + |
| 32 | + def test_both_timestamps_provided(self): |
| 33 | + """Explicit start and end are converted to UTC datetimes.""" |
| 34 | + start, end = resolve_date_range( |
| 35 | + start_timestamp=NOV_14_2023_TS, end_timestamp=NOV_19_2023_TS |
| 36 | + ) |
| 37 | + |
| 38 | + assert start == NOV_14_2023 |
| 39 | + assert end == NOV_19_2023 |
| 40 | + |
| 41 | + @patch("kernelCI_app.helpers.dateRange.now", return_value=FIXED_NOW) |
| 42 | + def test_only_start_provided(self, _mock_now): |
| 43 | + """Only start → end defaults to now().""" |
| 44 | + start, end = resolve_date_range( |
| 45 | + start_timestamp=NOV_14_2023_TS, end_timestamp=None |
| 46 | + ) |
| 47 | + |
| 48 | + assert start == NOV_14_2023 |
| 49 | + assert end == FIXED_NOW |
| 50 | + |
| 51 | + def test_only_end_provided(self): |
| 52 | + """Only end → start defaults to end-7d (not now()-7d).""" |
| 53 | + start, end = resolve_date_range( |
| 54 | + start_timestamp=None, end_timestamp=NOV_19_2023_TS |
| 55 | + ) |
| 56 | + |
| 57 | + assert end == NOV_19_2023 |
| 58 | + assert start == NOV_19_2023 - timedelta(days=7) |
| 59 | + |
| 60 | + def test_only_end_far_in_the_past(self): |
| 61 | + """End date 30+ days ago without start still produces a valid range.""" |
| 62 | + # 2023-01-15 00:00:00 UTC — ~10 months before NOV_14 |
| 63 | + jan_15_ts = "1673740800" |
| 64 | + jan_15 = datetime(2023, 1, 15, 0, 0, 0, tzinfo=dt_timezone.utc) |
| 65 | + |
| 66 | + start, end = resolve_date_range(start_timestamp=None, end_timestamp=jan_15_ts) |
| 67 | + |
| 68 | + assert end == jan_15 |
| 69 | + assert start == jan_15 - timedelta(days=7) |
| 70 | + assert start < end |
| 71 | + |
| 72 | + def test_start_after_end_raises(self): |
| 73 | + """start > end → ValueError (Nov 19 as start, Nov 14 as end).""" |
| 74 | + with pytest.raises(ValueError, match="start_date must be before end_date"): |
| 75 | + resolve_date_range( |
| 76 | + start_timestamp=NOV_19_2023_TS, end_timestamp=NOV_14_2023_TS |
| 77 | + ) |
| 78 | + |
| 79 | + @patch("kernelCI_app.helpers.dateRange.now", return_value=FIXED_NOW) |
| 80 | + def test_future_start_without_end_raises(self, _mock_now): |
| 81 | + """Start in the future with no end (defaults to now()) → ValueError.""" |
| 82 | + # 2027-01-01 00:00:00 UTC — ~9 months after FIXED_NOW |
| 83 | + future_ts = "1798761600" |
| 84 | + |
| 85 | + with pytest.raises(ValueError, match="start_date must be before end_date"): |
| 86 | + resolve_date_range(start_timestamp=future_ts, end_timestamp=None) |
| 87 | + |
| 88 | + def test_float_timestamps(self): |
| 89 | + """Fractional seconds are accepted (Nov 14 + 0.5s, Nov 19 + 0.9s).""" |
| 90 | + start, end = resolve_date_range( |
| 91 | + start_timestamp=f"{NOV_14_2023_TS}.5", |
| 92 | + end_timestamp=f"{NOV_19_2023_TS}.9", |
| 93 | + ) |
| 94 | + |
| 95 | + assert start == datetime.fromtimestamp(1700000000.5, tz=dt_timezone.utc) |
| 96 | + assert end == datetime.fromtimestamp(1700432000.9, tz=dt_timezone.utc) |
| 97 | + |
| 98 | + def test_invalid_start_raises(self): |
| 99 | + """Non-numeric start → ValueError.""" |
| 100 | + with pytest.raises(ValueError): |
| 101 | + resolve_date_range( |
| 102 | + start_timestamp="not-a-number", end_timestamp=NOV_19_2023_TS |
| 103 | + ) |
| 104 | + |
| 105 | + def test_invalid_end_raises(self): |
| 106 | + """Non-numeric end → ValueError.""" |
| 107 | + with pytest.raises(ValueError): |
| 108 | + resolve_date_range(start_timestamp=NOV_14_2023_TS, end_timestamp="abc") |
| 109 | + |
| 110 | + def test_equal_timestamps(self): |
| 111 | + """start == end is valid (zero-width range).""" |
| 112 | + start, end = resolve_date_range( |
| 113 | + start_timestamp=NOV_14_2023_TS, end_timestamp=NOV_14_2023_TS |
| 114 | + ) |
| 115 | + |
| 116 | + assert start == end |
| 117 | + |
| 118 | + def test_returned_datetimes_are_utc(self): |
| 119 | + """Both returned datetimes carry UTC timezone info.""" |
| 120 | + start, end = resolve_date_range( |
| 121 | + start_timestamp=NOV_14_2023_TS, end_timestamp=NOV_19_2023_TS |
| 122 | + ) |
| 123 | + |
| 124 | + assert start.tzinfo == dt_timezone.utc |
| 125 | + assert end.tzinfo == dt_timezone.utc |
0 commit comments