Skip to content

Commit c78b77b

Browse files
committed
Re-use parameters
1 parent ebbbebd commit c78b77b

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

internal/endtoend/testdata/order_by_binds/sqlite/go/db.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/endtoend/testdata/order_by_binds/sqlite/go/models.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/endtoend/testdata/order_by_binds/sqlite/go/query.sql.go

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/sql/rewrite/parameters.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -140,10 +140,10 @@ func NamedParameters(engine config.Engine, raw *ast.RawStmt, numbs map[int]bool,
140140

141141
// TODO: This code assumes that @foo::bool is on a single line
142142
var replace string
143-
if engine == config.EngineMySQL || !dollar {
144-
replace = "?"
145-
} else if engine == config.EngineSQLite {
143+
if engine == config.EngineSQLite {
146144
replace = fmt.Sprintf("?%d", argn)
145+
} else if engine == config.EngineMySQL || !dollar {
146+
replace = "?"
147147
} else {
148148
replace = fmt.Sprintf("$%d", argn)
149149
}
@@ -168,10 +168,10 @@ func NamedParameters(engine config.Engine, raw *ast.RawStmt, numbs map[int]bool,
168168

169169
// TODO: This code assumes that @foo is on a single line
170170
var replace string
171-
if engine == config.EngineMySQL || !dollar {
172-
replace = "?"
173-
} else if engine == config.EngineSQLite {
171+
if engine == config.EngineSQLite {
174172
replace = fmt.Sprintf("?%d", argn)
173+
} else if engine == config.EngineMySQL || !dollar {
174+
replace = "?"
175175
} else {
176176
replace = fmt.Sprintf("$%d", argn)
177177
}

0 commit comments

Comments
 (0)