fix bug with route attachment, it should use route namespace NOT gateway namespace

Author: zac-nixon

pkg/gateway/routeutils/listener_set.go

@@ -0,0 +1 @@
+package routeutils

pkg/gateway/routeutils/route_attachment_helper.go

@@ -38,7 +38,7 @@ func (rah *routeAttachmentHelperImpl) doesRouteAttachToGateway(gw gwv1.Gateway,
 		if parentRef.Namespace != nil {
 			namespaceToCompare = string(*parentRef.Namespace)
 		} else {
-			namespaceToCompare = gw.Namespace
+			namespaceToCompare = route.GetRouteNamespacedName().Namespace
 		}
 
 		nameCheck := string(parentRef.Name) == gw.Name

pkg/gateway/routeutils/route_attachment_helper_test.go

@@ -26,6 +26,10 @@ func Test_doesRouteAttachToGateway(t *testing.T) {
 				},
 			},
 			route: convertHTTPRoute(gwv1.HTTPRoute{
+				ObjectMeta: metav1.ObjectMeta{
+					Name:      "route",
+					Namespace: "ns1",
+				},
 				Spec: gwv1.HTTPRouteSpec{
 					CommonRouteSpec: gwv1.CommonRouteSpec{
 						ParentRefs: []gwv1.ParentReference{
@@ -47,6 +51,10 @@ func Test_doesRouteAttachToGateway(t *testing.T) {
 				},
 			},
 			route: convertHTTPRoute(gwv1.HTTPRoute{
+				ObjectMeta: metav1.ObjectMeta{
+					Name:      "route",
+					Namespace: "ns1",
+				},
 				Spec: gwv1.HTTPRouteSpec{
 					CommonRouteSpec: gwv1.CommonRouteSpec{
 						ParentRefs: []gwv1.ParentReference{