add tests

Author: abeowlu

test/e2e/gateway/nlb_instance_target_test.go

@@ -7,6 +7,7 @@ import (
 	"strings"
 	"time"
 
+	"k8s.io/apimachinery/pkg/types"
 	gwv1 "sigs.k8s.io/gateway-api/apis/v1"
 
 	awssdk "github.com/aws/aws-sdk-go-v2/aws"
@@ -788,4 +789,138 @@ var _ = Describe("test nlb gateway using instance targets reconciled by the aws
 			})
 		})
 	})
+
+	Context("with NLB instance target and gateway-level default TGC via LBC", func() {
+		It("should apply default TGC from LBC and merge with service-level TGC", func() {
+			ipTargetType := elbv2gw.TargetTypeIP
+			hcProtocol := elbv2gw.TargetGroupHealthCheckProtocolHTTP
+			gwHCPath := "/gw-default-health"
+			svcHCPath := "/svc-override-health"
+
+			interf := elbv2gw.LoadBalancerSchemeInternetFacing
+			lbcSpec := elbv2gw.LoadBalancerConfigurationSpec{
+				Scheme: &interf,
+				DefaultTargetGroupConfiguration: &elbv2gw.DefaultTargetGroupConfigurationReference{
+					Name: "gw-default-tgc",
+				},
+			}
+
+			defaultTGC := buildDefaultTargetGroupConfig("gw-default-tgc", elbv2gw.TargetGroupProps{
+				TargetType: &ipTargetType,
+				HealthCheckConfig: &elbv2gw.HealthCheckConfiguration{
+					HealthCheckPath:     &gwHCPath,
+					HealthCheckProtocol: &hcProtocol,
+				},
+			})
+
+			svcTgSpec := elbv2gw.TargetGroupConfigurationSpec{
+				DefaultConfiguration: elbv2gw.TargetGroupProps{
+					HealthCheckConfig: &elbv2gw.HealthCheckConfiguration{
+						HealthCheckPath:     &svcHCPath,
+						HealthCheckProtocol: &hcProtocol,
+					},
+				},
+			}
+
+			By("deploying stack", func() {
+				err := stack.DeployWithDefaultTGC(ctx, tf, lbcSpec, defaultTGC, svcTgSpec, true)
+				Expect(err).NotTo(HaveOccurred())
+			})
+
+			By("checking gateway status for lb dns name", func() {
+				dnsName = stack.GetLoadBalancerIngressHostName()
+				Expect(dnsName).ToNot(BeEmpty())
+			})
+
+			By("querying AWS loadbalancer from the dns name", func() {
+				var err error
+				lbARN, err = tf.LBManager.FindLoadBalancerByDNSName(ctx, dnsName)
+				Expect(err).NotTo(HaveOccurred())
+				Expect(lbARN).ToNot(BeEmpty())
+			})
+
+			By("verifying AWS loadbalancer resources with two ip target groups", func() {
+				expectedTargetGroups := []verifier.ExpectedTargetGroup{
+					{
+						Protocol:   "TCP",
+						Port:       80,
+						TargetType: "ip",
+						NumTargets: int(*stack.nlbResourceStack.commonStack.dps[0].Spec.Replicas),
+					},
+					{
+						Protocol:   "TCP",
+						Port:       80,
+						TargetType: "ip",
+						NumTargets: int(*stack.nlbResourceStack.commonStack.dps[0].Spec.Replicas),
+					},
+				}
+				err := verifier.VerifyAWSLoadBalancerResources(ctx, tf, lbARN, verifier.LoadBalancerExpectation{
+					Type:         "network",
+					Scheme:       "internet-facing",
+					Listeners:    stack.nlbResourceStack.getListenersPortMap(),
+					TargetGroups: expectedTargetGroups,
+				})
+				Expect(err).NotTo(HaveOccurred())
+			})
+
+			By("verifying svc1 inherits gateway TGC and svc2 uses service-level TGC health check path", func() {
+				targetGroups, err := tf.TGManager.GetTargetGroupsForLoadBalancer(ctx, lbARN)
+				Expect(err).NotTo(HaveOccurred())
+				Expect(len(targetGroups)).To(Equal(2))
+
+				hcPaths := []string{}
+				for _, tg := range targetGroups {
+					Expect(string(tg.TargetType)).To(Equal("ip"))
+					hcPaths = append(hcPaths, awssdk.ToString(tg.HealthCheckPath))
+				}
+				Expect(hcPaths).To(ContainElements("/gw-default-health", "/svc-override-health"))
+			})
+
+			By("waiting for target group targets to be healthy", func() {
+				err := verifier.WaitUntilAllTargetsAreHealthy(ctx, tf, lbARN, int(*stack.nlbResourceStack.commonStack.dps[0].Spec.Replicas)*2)
+				Expect(err).NotTo(HaveOccurred())
+			})
+
+			By("waiting until DNS name is available", func() {
+				err := utils.WaitUntilDNSNameAvailable(ctx, dnsName)
+				Expect(err).NotTo(HaveOccurred())
+			})
+
+			By("sending http request to the lb", func() {
+				url := fmt.Sprintf("http://%v/any-path", dnsName)
+				err := tf.HTTPVerifier.VerifyURL(url, http.ResponseCodeMatches(200))
+				Expect(err).NotTo(HaveOccurred())
+			})
+
+			By("updating default TGC health check path and verifying propagation", func() {
+				tgcKey := types.NamespacedName{
+					Name:      "gw-default-tgc",
+					Namespace: stack.nlbResourceStack.commonStack.ns.Name,
+				}
+				tgc := &elbv2gw.TargetGroupConfiguration{}
+				err := tf.K8sClient.Get(ctx, tgcKey, tgc)
+				Expect(err).NotTo(HaveOccurred())
+
+				updatedHCPath := "/updated-default-health"
+				tgc.Spec.DefaultConfiguration.HealthCheckConfig.HealthCheckPath = &updatedHCPath
+				err = tf.K8sClient.Update(ctx, tgc)
+				Expect(err).NotTo(HaveOccurred())
+			})
+
+			By("verifying AWS target group health check path updated after TGC change", func() {
+				Eventually(func() bool {
+					targetGroups, err := tf.TGManager.GetTargetGroupsForLoadBalancer(ctx, lbARN)
+					if err != nil || len(targetGroups) == 0 {
+						return false
+					}
+					for _, tg := range targetGroups {
+						if awssdk.ToString(tg.HealthCheckPath) == "/updated-default-health" {
+							return true
+						}
+					}
+					return false
+				}, utils.PollTimeoutLong, utils.PollIntervalMedium).Should(BeTrue())
+			})
+		})
+	})
 })

test/e2e/gateway/nlb_test_helper.go

@@ -661,7 +661,7 @@ func (s *NLBTestStack) DeployListenerMismatch(ctx context.Context, f *framework.
 	lbc := buildLoadBalancerConfig(lbConfSpec)
 	tgcTCP := buildTargetGroupConfig(defaultTgConfigName, tgConfSpec, svcTCP)
 
-	s.nlbResourceStack = newNLBResourceStack([]*appsv1.Deployment{dpTCP}, []*corev1.Service{svcTCP}, gwc, gw, lbc, []*elbv2gw.TargetGroupConfiguration{tgcTCP}, tcprs, []*gwalpha2.UDPRoute{}, nil, "nlb-gateway-e2e", readinessGateEnabled)
+	s.nlbResourceStack = newNLBResourceStack([]*appsv1.Deployment{dpTCP}, []*corev1.Service{svcTCP}, gwc, gw, lbc, []*elbv2gw.TargetGroupConfiguration{tgcTCP}, tcprs, []*gwalpha2.UDPRoute{}, nil, "nlb-gateway-e2e", getNamespaceLabels(readinessGateEnabled))
 
 	return s.nlbResourceStack.Deploy(ctx, f)
 }