Skip checking infinite redirect rules for Regex path values

Author: shraddhabang

pkg/ingress/rule_optimizer.go

@@ -98,6 +98,10 @@ func isInfiniteRedirectRule(port int32, protocol elbv2model.Protocol, rule Rule)
 		case condition.Field == elbv2model.RuleConditionFieldHostHeader && condition.HostHeaderConfig != nil:
 			ruleHosts.Insert(condition.HostHeaderConfig.Values...)
 		case condition.Field == elbv2model.RuleConditionFieldPathPattern && condition.PathPatternConfig != nil:
+			// We dont check for infinite rules for regex paths
+			if len(condition.PathPatternConfig.RegexValues) > 0 {
+				return false
+			}
 			rulePaths.Insert(condition.PathPatternConfig.Values...)
 		}
 	}

pkg/ingress/rule_optimizer_test.go

@@ -1285,6 +1285,38 @@ func Test_isInfiniteRedirectRule(t *testing.T) {
 			},
 			want: true,
 		},
+		{
+			name: "isnt infinite redirect rule when for regex paths",
+			args: args{
+				port:     443,
+				protocol: elbv2model.ProtocolHTTPS,
+				rule: Rule{
+					Conditions: []elbv2model.RuleCondition{
+						{
+							Field: elbv2model.RuleConditionFieldHostHeader,
+							HostHeaderConfig: &elbv2model.HostHeaderConditionConfig{
+								Values: []string{"www.example.com", "app.example.com"},
+							},
+						},
+						{
+							Field: elbv2model.RuleConditionFieldPathPattern,
+							PathPatternConfig: &elbv2model.PathPatternConditionConfig{
+								RegexValues: []string{"^/specific/path$"},
+							},
+						},
+					},
+					Actions: []elbv2model.Action{
+						{
+							Type: elbv2model.ActionTypeRedirect,
+							RedirectConfig: &elbv2model.RedirectActionConfig{
+								StatusCode: "HTTP_301",
+							},
+						},
+					},
+				},
+			},
+			want: false,
+		},
 		{
 			name: "is infinite redirect rule when all fields are set to default value",
 			args: args{