Merge pull request #4584 from vishwas121/main

Filter RequeueNeeded errors to skip event triggers on TGB controller

Author: k8s-ci-robot

controllers/elbv2/targetgroupbinding_controller.go

@@ -141,7 +141,9 @@ func (r *targetGroupBindingReconciler) reconcileTargetGroupBinding(ctx context.C
 	}
 	r.metricsCollector.ObserveControllerReconcileLatency(controllerName, "reconcile_targetgroupbinding", tgbResourceFn)
 	if err != nil {
-		r.eventRecorder.Event(tgb, corev1.EventTypeWarning, k8s.TargetGroupBindingEventReasonFailedReconcile, fmt.Sprintf("Failed reconcile due to %v", err))
+		if !runtime.IsRequeueError(err) {
+			r.eventRecorder.Event(tgb, corev1.EventTypeWarning, k8s.TargetGroupBindingEventReasonFailedReconcile, fmt.Sprintf("Failed reconcile due to %v", err))
+		}
 		return ctrlerrors.NewErrorWithMetrics(controllerName, "reconcile_targetgroupbinding_error", err, r.metricsCollector)
 	}
 

pkg/runtime/reconcile.go

@@ -29,6 +29,19 @@ func HandleReconcileError(inputErr error, log logr.Logger) (ctrl.Result, error)
 	return ctrl.Result{}, inputErr
 }
 
+// IsRequeueError returns true when err indicates a requeue (expected retry).
+func IsRequeueError(err error) bool {
+	var requeueNeededAfter *ctrlerrors.RequeueNeededAfter
+	if errors.As(err, &requeueNeededAfter) {
+		return true
+	}
+	var requeueNeeded *ctrlerrors.RequeueNeeded
+	if errors.As(err, &requeueNeeded) {
+		return true
+	}
+	return false
+}
+
 func handleNestedError(err error) error {
 	if err == nil {
 		return nil