Merge pull request #993 from SVanhull/insecure-diagnostics-conditional

k8s-ci-robot · web-flow · commit 56df0a1923b1 · 2026-03-06T17:00:26.000+05:30
🐛 Set insecure-diagnostics Arg only when true
diff --git a/internal/controller/component_customizer.go b/internal/controller/component_customizer.go
@@ -248,7 +248,9 @@ func customizeManagerContainer(mSpec *operatorv1.ManagerSpec, c *corev1.Containe
 		c.Args = setArgs(c.Args, "--diagnostics-address", mSpec.Metrics.DiagnosticsAddress)
 	}
 
-	c.Args = setArgs(c.Args, "--insecure-diagnostics", strconv.FormatBool(mSpec.Metrics.InsecureDiagnostics))
+	if mSpec.Metrics.InsecureDiagnostics {
+		c.Args = setArgs(c.Args, "--insecure-diagnostics", strconv.FormatBool(mSpec.Metrics.InsecureDiagnostics))
+	}
 
 	// webhooks
 	if mSpec.Webhook.Host != "" {

Original file line number	Diff line number	Diff line change
`@@ -248,7 +248,9 @@ func customizeManagerContainer(mSpec operatorv1.ManagerSpec, c corev1.Containe`
`248`	`248`	`c.Args = setArgs(c.Args, "--diagnostics-address", mSpec.Metrics.DiagnosticsAddress)`
`249`	`249`	`}`
`250`	`250`
`251`		`- c.Args = setArgs(c.Args, "--insecure-diagnostics", strconv.FormatBool(mSpec.Metrics.InsecureDiagnostics))`
	`251`	`+ if mSpec.Metrics.InsecureDiagnostics {`
	`252`	`+ c.Args = setArgs(c.Args, "--insecure-diagnostics", strconv.FormatBool(mSpec.Metrics.InsecureDiagnostics))`
	`253`	`+ }`
`252`	`254`
`253`	`255`	`// webhooks`
`254`	`256`	`if mSpec.Webhook.Host != "" {`