Skip to content

Commit ce3e4af

Browse files
authored
Merge pull request #5852 from Arpit529Srivastava/e2e-gpu-enabled
🐛 fix: Enable GPU-enabled cluster e2e test
2 parents 3ab39c6 + d325d0b commit ce3e4af

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

test/e2e/suites/unmanaged/unmanaged_functional_test.go

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,6 @@ var _ = ginkgo.Context("[unmanaged] [functional]", func() {
119119

120120
ginkgo.Describe("GPU-enabled cluster test", func() {
121121
ginkgo.It("should create cluster with single worker", func() {
122-
ginkgo.Skip("Args field of clusterctl.ApplyClusterTemplateAndWaitInput was removed, need to add support for server-side filtering.")
123122
specName := "functional-gpu-cluster"
124123
namespace := shared.SetupSpecNamespace(ctx, specName, e2eCtx)
125124
if !e2eCtx.Settings.SkipQuotas {
@@ -151,13 +150,8 @@ var _ = ginkgo.Context("[unmanaged] [functional]", func() {
151150
WaitForClusterIntervals: e2eCtx.E2EConfig.GetIntervals(specName, "wait-cluster"),
152151
WaitForControlPlaneIntervals: e2eCtx.E2EConfig.GetIntervals(specName, "wait-control-plane"),
153152
WaitForMachineDeployments: e2eCtx.E2EConfig.GetIntervals(specName, "wait-worker-nodes"),
154-
// nvidia-gpu flavor creates a config map as part of a crs, that exceeds the annotations size limit when we do kubectl apply.
155-
// This is because the entire config map is stored in `last-applied` annotation for tracking.
156-
// The workaround is to use server side apply by passing `--server-side` flag to kubectl apply.
157-
// More on server side apply here: https://kubernetes.io/docs/reference/using-api/server-side-apply/
158-
// TODO: Need a PR to re-add argument support to this type.
159-
// It was removed in https://github.com/kubernetes-sigs/cluster-api/commit/b4349fecaa626865e71b058a8b01e0377fb9e444
160-
// Args: []string{"--server-side"},
153+
// GPU operator components are deployed via ClusterResourceSet which handles large ConfigMaps
154+
// without the kubectl annotation size limit issues that occur with client-side apply.
161155
}, result)
162156

163157
shared.AWSGPUSpec(ctx, e2eCtx, shared.AWSGPUSpecInput{

0 commit comments

Comments
 (0)