Add fuzzy conversion tests for v1beta1 API types

Signed-off-by: Lennart Jern <lennart.jern@est.tech>

Author: lentzi90

api/v1beta1/conversion_fuzz_test.go

@@ -0,0 +1,163 @@
+/*
+Copyright 2026 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+	http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package v1beta1_test
+
+import (
+	"slices"
+	"strings"
+	"testing"
+
+	"k8s.io/apimachinery/pkg/api/apitesting/fuzzer"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/runtime"
+	runtimeserializer "k8s.io/apimachinery/pkg/runtime/serializer"
+	clusterv1 "sigs.k8s.io/cluster-api/api/core/v1beta2"
+	utilconversion "sigs.k8s.io/cluster-api/util/conversion"
+	"sigs.k8s.io/controller-runtime/pkg/conversion"
+
+	infrav1beta1 "sigs.k8s.io/cluster-api-provider-openstack/api/v1beta1"
+	infrav1 "sigs.k8s.io/cluster-api-provider-openstack/api/v1beta2"
+	testhelpers "sigs.k8s.io/cluster-api-provider-openstack/test/helpers"
+)
+
+// Setting this to false to avoid running tests in parallel. Only for use in development.
+const parallel = true
+
+func runParallel(f func(t *testing.T)) func(t *testing.T) {
+	if parallel {
+		return func(t *testing.T) {
+			t.Helper()
+			t.Parallel()
+			f(t)
+		}
+	}
+	return f
+}
+
+func TestFuzzyConversion(t *testing.T) {
+	t.Helper()
+
+	scheme := runtime.NewScheme()
+	if err := infrav1beta1.AddToScheme(scheme); err != nil {
+		t.Fatal(err)
+	}
+	if err := infrav1.AddToScheme(scheme); err != nil {
+		t.Fatal(err)
+	}
+
+	fuzzerFuncs := func(_ runtimeserializer.CodecFactory) []interface{} {
+		return slices.Concat(
+			testhelpers.InfraV1beta1FuzzerFuncs(),
+			testhelpers.InfraV1Beta2FuzzerFuncs(),
+		)
+	}
+
+	// ignoreDataAnnotation removes the data annotation that is added by
+	// MarshalData during ConvertTo. The annotation is not present on the
+	// original hub object, so it must be removed before comparison.
+	ignoreDataAnnotation := func(hub conversion.Hub) {
+		obj := hub.(metav1.Object)
+		delete(obj.GetAnnotations(), utilconversion.DataAnnotation)
+	}
+
+	// clusterHubAfterMutation removes the data annotation and sorts
+	// FailureDomains by Name to normalize non-deterministic map iteration
+	// order from the FailureDomains map↔slice conversion.
+	clusterHubAfterMutation := func(hub conversion.Hub) {
+		cluster := hub.(*infrav1.OpenStackCluster)
+		delete(cluster.GetAnnotations(), utilconversion.DataAnnotation)
+		slices.SortFunc(cluster.Status.FailureDomains, func(a, b clusterv1.FailureDomain) int {
+			return strings.Compare(a.Name, b.Name)
+		})
+	}
+
+	t.Run("for OpenStackCluster", runParallel(utilconversion.FuzzTestFunc(utilconversion.FuzzTestFuncInput{
+		Scheme:           scheme,
+		Hub:              &infrav1.OpenStackCluster{},
+		Spoke:            &infrav1beta1.OpenStackCluster{},
+		HubAfterMutation: clusterHubAfterMutation,
+		FuzzerFuncs:      []fuzzer.FuzzerFuncs{fuzzerFuncs},
+	})))
+
+	t.Run("for OpenStackCluster with mutate", runParallel(testhelpers.FuzzMutateTestFunc(testhelpers.FuzzMutateTestFuncInput{
+		FuzzTestFuncInput: utilconversion.FuzzTestFuncInput{
+			Scheme:           scheme,
+			Hub:              &infrav1.OpenStackCluster{},
+			Spoke:            &infrav1beta1.OpenStackCluster{},
+			HubAfterMutation: clusterHubAfterMutation,
+			FuzzerFuncs:      []fuzzer.FuzzerFuncs{fuzzerFuncs},
+		},
+		MutateFuzzerFuncs: []fuzzer.FuzzerFuncs{fuzzerFuncs},
+	})))
+
+	t.Run("for OpenStackClusterTemplate", runParallel(utilconversion.FuzzTestFunc(utilconversion.FuzzTestFuncInput{
+		Scheme:           scheme,
+		Hub:              &infrav1.OpenStackClusterTemplate{},
+		Spoke:            &infrav1beta1.OpenStackClusterTemplate{},
+		HubAfterMutation: ignoreDataAnnotation,
+		FuzzerFuncs:      []fuzzer.FuzzerFuncs{fuzzerFuncs},
+	})))
+
+	t.Run("for OpenStackClusterTemplate with mutate", runParallel(testhelpers.FuzzMutateTestFunc(testhelpers.FuzzMutateTestFuncInput{
+		FuzzTestFuncInput: utilconversion.FuzzTestFuncInput{
+			Scheme:           scheme,
+			Hub:              &infrav1.OpenStackClusterTemplate{},
+			Spoke:            &infrav1beta1.OpenStackClusterTemplate{},
+			HubAfterMutation: ignoreDataAnnotation,
+			FuzzerFuncs:      []fuzzer.FuzzerFuncs{fuzzerFuncs},
+		},
+		MutateFuzzerFuncs: []fuzzer.FuzzerFuncs{fuzzerFuncs},
+	})))
+
+	t.Run("for OpenStackMachine", runParallel(utilconversion.FuzzTestFunc(utilconversion.FuzzTestFuncInput{
+		Scheme:           scheme,
+		Hub:              &infrav1.OpenStackMachine{},
+		Spoke:            &infrav1beta1.OpenStackMachine{},
+		HubAfterMutation: ignoreDataAnnotation,
+		FuzzerFuncs:      []fuzzer.FuzzerFuncs{fuzzerFuncs},
+	})))
+
+	t.Run("for OpenStackMachine with mutate", runParallel(testhelpers.FuzzMutateTestFunc(testhelpers.FuzzMutateTestFuncInput{
+		FuzzTestFuncInput: utilconversion.FuzzTestFuncInput{
+			Scheme:           scheme,
+			Hub:              &infrav1.OpenStackMachine{},
+			Spoke:            &infrav1beta1.OpenStackMachine{},
+			HubAfterMutation: ignoreDataAnnotation,
+			FuzzerFuncs:      []fuzzer.FuzzerFuncs{fuzzerFuncs},
+		},
+		MutateFuzzerFuncs: []fuzzer.FuzzerFuncs{fuzzerFuncs},
+	})))
+
+	t.Run("for OpenStackMachineTemplate", runParallel(utilconversion.FuzzTestFunc(utilconversion.FuzzTestFuncInput{
+		Scheme:           scheme,
+		Hub:              &infrav1.OpenStackMachineTemplate{},
+		Spoke:            &infrav1beta1.OpenStackMachineTemplate{},
+		HubAfterMutation: ignoreDataAnnotation,
+		FuzzerFuncs:      []fuzzer.FuzzerFuncs{fuzzerFuncs},
+	})))
+
+	t.Run("for OpenStackMachineTemplate with mutate", runParallel(testhelpers.FuzzMutateTestFunc(testhelpers.FuzzMutateTestFuncInput{
+		FuzzTestFuncInput: utilconversion.FuzzTestFuncInput{
+			Scheme:           scheme,
+			Hub:              &infrav1.OpenStackMachineTemplate{},
+			Spoke:            &infrav1beta1.OpenStackMachineTemplate{},
+			HubAfterMutation: ignoreDataAnnotation,
+			FuzzerFuncs:      []fuzzer.FuzzerFuncs{fuzzerFuncs},
+		},
+		MutateFuzzerFuncs: []fuzzer.FuzzerFuncs{fuzzerFuncs},
+	})))
+}