Replace gofuzz with randfill

Replace the deprecated gofuzz library with randfill, updating all fuzzer
function signatures and method calls accordingly.

Signed-off-by: Lennart Jern <lennart.jern@est.tech>

Author: lentzi90

test/helpers/fuzzerfuncs.go

@@ -19,8 +19,8 @@ package helpers
 import (
 	"strings"
 
-	fuzz "github.com/google/gofuzz"
 	"k8s.io/utils/ptr"
+	"sigs.k8s.io/randfill"
 
 	infrav1 "sigs.k8s.io/cluster-api-provider-openstack/api/v1beta2"
 	"sigs.k8s.io/cluster-api-provider-openstack/pkg/utils/optional"
@@ -37,9 +37,9 @@ func filterInvalidTags(tags []infrav1.NeutronTag) []infrav1.NeutronTag {
 	return ret
 }
 
-func nonEmptyString(c fuzz.Continue) string {
+func nonEmptyString(c randfill.Continue) string {
 	for {
-		if s := c.RandString(); s != "" {
+		if s := c.String(20); s != "" {
 			return s
 		}
 	}
@@ -50,14 +50,14 @@ type isZeroer[T any] interface {
 	*T
 }
 
-func fuzzFilterParam[Z isZeroer[T], T any](id *optional.String, filter *Z, c fuzz.Continue) {
-	if c.RandBool() {
+func fuzzFilterParam[Z isZeroer[T], T any](id *optional.String, filter *Z, c randfill.Continue) {
+	if c.Bool() {
 		*id = ptr.To(nonEmptyString(c))
 		*filter = nil
 	} else {
 		*filter = new(T)
 		for (*filter).IsZero() {
-			c.Fuzz(*filter)
+			c.Fill(*filter)
 		}
 		*id = nil
 	}
@@ -66,60 +66,60 @@ func fuzzFilterParam[Z isZeroer[T], T any](id *optional.String, filter *Z, c fuz
 // InfraV1FuzzerFuncs returns fuzzer funcs for v1beta1 OpenStack types which:
 // * Constrain the output in ways which are validated by the API server
 // * Add additional test coverage where it is not generated by the default fuzzer.
-func InfraV1FuzzerFuncs() []interface{} {
-	return []interface{}{
-		func(spec *infrav1.OpenStackClusterSpec, c fuzz.Continue) {
-			c.FuzzNoCustom(spec)
+func InfraV1FuzzerFuncs() []any {
+	return []any{
+		func(spec *infrav1.OpenStackClusterSpec, c randfill.Continue) {
+			c.FillNoCustom(spec)
 
 			// The fuzzer only seems to generate Subnets of
 			// length 1, but we need to also test length 2.
 			// Ensure it is occasionally generated.
-			if len(spec.Subnets) == 1 && c.RandBool() {
+			if len(spec.Subnets) == 1 && c.Bool() {
 				subnet := infrav1.SubnetParam{}
-				c.Fuzz(&subnet)
+				c.Fill(&subnet)
 				spec.Subnets = append(spec.Subnets, subnet)
 			}
 		},
 
-		func(spec *infrav1.SubnetSpec, c fuzz.Continue) {
-			c.FuzzNoCustom(spec)
+		func(spec *infrav1.SubnetSpec, c randfill.Continue) {
+			c.FillNoCustom(spec)
 
 			// CIDR is required and API validates that it's present, so
 			// we force it to always be set.
 			for spec.CIDR == "" {
-				spec.CIDR = c.RandString()
+				spec.CIDR = c.String(20)
 			}
 		},
 
-		func(pool *infrav1.AllocationPool, c fuzz.Continue) {
-			c.FuzzNoCustom(pool)
+		func(pool *infrav1.AllocationPool, c randfill.Continue) {
+			c.FillNoCustom(pool)
 
 			// Start and End are required properties, let's make sure both are set
 			for pool.Start == "" {
-				pool.Start = c.RandString()
+				pool.Start = c.String(20)
 			}
 
 			for pool.End == "" {
-				pool.End = c.RandString()
+				pool.End = c.String(20)
 			}
 		},
 
 		// v1beta1 filter tags cannot contain commas and can't be empty.
-		func(filter *infrav1.FilterByNeutronTags, c fuzz.Continue) {
-			c.FuzzNoCustom(filter)
+		func(filter *infrav1.FilterByNeutronTags, c randfill.Continue) {
+			c.FillNoCustom(filter)
 
 			// Sometimes add an additional tag to ensure we get test coverage of multiple tags
-			if c.RandBool() {
-				filter.Tags = append(filter.Tags, infrav1.NeutronTag(c.RandString()))
+			if c.Bool() {
+				filter.Tags = append(filter.Tags, infrav1.NeutronTag(c.String(20)))
 			}
-			if c.RandBool() {
-				filter.TagsAny = append(filter.TagsAny, infrav1.NeutronTag(c.RandString()))
+			if c.Bool() {
+				filter.TagsAny = append(filter.TagsAny, infrav1.NeutronTag(c.String(20)))
 			}
-			if c.RandBool() {
-				filter.NotTags = append(filter.NotTags, infrav1.NeutronTag(c.RandString()))
+			if c.Bool() {
+				filter.NotTags = append(filter.NotTags, infrav1.NeutronTag(c.String(20)))
 			}
-			if c.RandBool() {
-				filter.NotTagsAny = append(filter.NotTagsAny, infrav1.NeutronTag(c.RandString()))
+			if c.Bool() {
+				filter.NotTagsAny = append(filter.NotTagsAny, infrav1.NeutronTag(c.String(20)))
 			}
 
 			// Remove empty tags and tags with commas
@@ -130,50 +130,46 @@ func InfraV1FuzzerFuncs() []interface{} {
 		},
 
 		// v1beta1 filter params contain exactly one of ID or filter
-		func(param *infrav1.NetworkParam, c fuzz.Continue) {
+		func(param *infrav1.NetworkParam, c randfill.Continue) {
 			fuzzFilterParam(&param.ID, &param.Filter, c)
 		},
 
-		func(param *infrav1.SubnetParam, c fuzz.Continue) {
+		func(param *infrav1.SubnetParam, c randfill.Continue) {
 			fuzzFilterParam(&param.ID, &param.Filter, c)
 		},
 
-		func(param *infrav1.SecurityGroupParam, c fuzz.Continue) {
+		func(param *infrav1.SecurityGroupParam, c randfill.Continue) {
 			fuzzFilterParam(&param.ID, &param.Filter, c)
 		},
 
-		func(param *infrav1.ImageParam, c fuzz.Continue) {
+		func(param *infrav1.ImageParam, c randfill.Continue) {
 			fuzzFilterParam(&param.ID, &param.Filter, c)
 		},
 
-		func(param *infrav1.RouterParam, c fuzz.Continue) {
-			fuzzFilterParam(&param.ID, &param.Filter, c)
-		},
-
-		func(param *infrav1.SecurityGroupParam, c fuzz.Continue) {
+		func(param *infrav1.RouterParam, c randfill.Continue) {
 			fuzzFilterParam(&param.ID, &param.Filter, c)
 		},
 
 		// Ensure VolumeAZ type is valid
-		func(az *infrav1.VolumeAvailabilityZone, c fuzz.Continue) {
+		func(az *infrav1.VolumeAvailabilityZone, c randfill.Continue) {
 			stringWithoutSpaces := func() string {
 				for {
-					s := c.RandString()
+					s := c.String(20)
 					if !strings.Contains(s, " ") && s != "" {
 						return s
 					}
 				}
 			}
 
 			// From is defaulted
-			if c.RandBool() {
+			if c.Bool() {
 				name := infrav1.VolumeAZName(stringWithoutSpaces())
 				az.Name = &name
 				return
 			}
 
 			// From is Name
-			if c.RandBool() {
+			if c.Bool() {
 				az.From = infrav1.VolumeAZFromName
 				name := infrav1.VolumeAZName(stringWithoutSpaces())
 				az.Name = &name