Helm Chart: extraArgs in map form do not work for args without values

[jabbrwcky]

What happened:

I tried to configure the commandline argument --aws-zone-match-parent for the AWS provider using the map form of extraArgs:, which did not work with using the arg key with a null value or a value of true

aws-zone-match-parent: true got rendered as --aws-zone-match-parent=true which caused an fatal error on startup

What you expected to happen:

the map form of extraArgs should handle CLI arguments without parameters as well as the list version.

Ideally the map version should support either flag: null (just key present) or flag: true for CLI args without an explicit value.

How to reproduce it (as minimally and precisely as possible):

extraArgs:
  domain-filter:
    - management.example.com
    - management.ext.example.com
  aws-zone-match-parent:

does not work, neither does:

extraArgs:
  domain-filter:
    - management.example.com
    - management.ext.example.com
  aws-zone-match-parent: true

This works:

extraArgs:
  - --domain-filter=management.example.com
  - --domain-filter=management.ext.example.com
  - --aws-zone-match-parent

(but does not support merging of values files)

Anything else we need to know?:

Environment:

• External-DNS version (use external-dns --version): 0.20.0
• DNS provider: AWS
• Others: Chart v1.20.0

[ivankatliarchuk]

It could be helm version related. There was a regression in Helm helm/helm#31643

[jabbrwcky]

It might be, if I actually tried to merge a map, but in this case the cause is the template.

As far as I can tell the linked PR already addresses the issue I encountered.

[thomas315]

It could be helm version related. There was a regression in Helm helm/helm#31643

I can confirm that this was the case. With Helm 4.1.3 the regression got fixed and the null value is preserved and template is rendered correctly. Nonetheless I would also prefer the mentioned PR to be merged since we are using Golang to template and their the behavior for null values is different.