Skip to content

Commit 62e8b4f

Browse files
authored
Improve security posture pruning unnecessary rbac (#172)
1 parent d0c45cf commit 62e8b4f

File tree

4 files changed

+3
-35
lines changed

4 files changed

+3
-35
lines changed

config/rbac/leader_election_role.yaml

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,6 @@ metadata:
77
app.kubernetes.io/managed-by: kustomize
88
name: leader-election-role
99
rules:
10-
- apiGroups:
11-
- ""
12-
resources:
13-
- configmaps
14-
verbs:
15-
- get
16-
- list
17-
- watch
18-
- create
19-
- update
20-
- patch
21-
- delete
2210
- apiGroups:
2311
- coordination.k8s.io
2412
resources:
@@ -31,10 +19,3 @@ rules:
3119
- update
3220
- patch
3321
- delete
34-
- apiGroups:
35-
- ""
36-
resources:
37-
- events
38-
verbs:
39-
- create
40-
- patch

config/rbac/role.yaml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,34 +16,22 @@ rules:
1616
resources:
1717
- nodes
1818
verbs:
19-
- create
20-
- delete
2119
- get
2220
- list
2321
- patch
2422
- update
2523
- watch
26-
- apiGroups:
27-
- ""
28-
resources:
29-
- nodes/finalizers
30-
verbs:
31-
- update
3224
- apiGroups:
3325
- ""
3426
resources:
3527
- nodes/status
3628
verbs:
3729
- get
38-
- patch
39-
- update
4030
- apiGroups:
4131
- readiness.node.x-k8s.io
4232
resources:
4333
- nodereadinessrules
4434
verbs:
45-
- create
46-
- delete
4735
- get
4836
- list
4937
- patch

internal/controller/node_controller.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,8 @@ func (r *NodeReconciler) SetupWithManager(ctx context.Context, mgr ctrl.Manager)
8181
Complete(r)
8282
}
8383

84-
// +kubebuilder:rbac:groups=core,resources=nodes,verbs=get;list;watch;create;update;patch;delete
85-
// +kubebuilder:rbac:groups=core,resources=nodes/status,verbs=get;update;patch
86-
// +kubebuilder:rbac:groups=core,resources=nodes/finalizers,verbs=update
84+
// +kubebuilder:rbac:groups=core,resources=nodes,verbs=get;list;watch;update;patch
85+
// +kubebuilder:rbac:groups=core,resources=nodes/status,verbs=get
8786

8887
// NodeReconciler handles node changes
8988

internal/controller/nodereadinessrule_controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ func (r *RuleReconciler) SetupWithManager(ctx context.Context, mgr ctrl.Manager)
8787
Complete(r)
8888
}
8989

90-
// +kubebuilder:rbac:groups=readiness.node.x-k8s.io,resources=nodereadinessrules,verbs=get;list;watch;create;update;patch;delete
90+
// +kubebuilder:rbac:groups=readiness.node.x-k8s.io,resources=nodereadinessrules,verbs=get;list;watch;update;patch
9191
// +kubebuilder:rbac:groups=readiness.node.x-k8s.io,resources=nodereadinessrules/status,verbs=get;update;patch
9292
// +kubebuilder:rbac:groups=readiness.node.x-k8s.io,resources=nodereadinessrules/finalizers,verbs=update
9393
// +kubebuilder:rbac:groups="",resources=events,verbs=create;patch

0 commit comments

Comments
 (0)