Skip to content

Commit 247e02c

Browse files
authored
Merge pull request #42 from libwww-perl/close-39
leave choosing IP address family to IO::Socket::IP
2 parents bee739a + 5996800 commit 247e02c

2 files changed

Lines changed: 15 additions & 18 deletions

File tree

Changes

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
Revision history for HTTP-Daemon
22

33
{{$NEXT}}
4+
- In t/chunked.t, leave choosing IP address family to IO::Socket::IP (GH#42) (Shoichi Kaji)
45

56
6.07 2020-05-19 19:19:53Z (TRIAL RELEASE)
67
- Prefer IP address for host in $d->url (GH#40) (Shoichi Kaji)

t/chunked.t

Lines changed: 14 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ use Test::More;
77

88
# use Time::HiRes qw(sleep);
99
our $CRLF;
10-
use Socket qw($CRLF);
10+
use Socket qw($CRLF AF_INET AF_INET6);
1111

1212
our $LOGGING = 0;
1313

@@ -101,23 +101,19 @@ my $can_fork
101101
my $tests = @TESTS;
102102
my $tport = 8334;
103103

104-
my @addresses = (
105-
{server => '::', client => '::1'},
106-
{server => '0.0.0.0', client => '127.0.0.1'}
104+
my %addresses = (
105+
AF_INET6() => {server => '::', client => '::1'},
106+
AF_INET() => {server => '0.0.0.0', client => '127.0.0.1'}
107107
);
108108
my $family;
109-
for my $id (0 .. $#addresses) {
110-
my $tsock = IO::Socket::IP->new(
111-
LocalAddr => $addresses[$id]->{server},
112-
LocalPort => $tport,
113-
Listen => 1,
114-
ReuseAddr => 1
115-
);
116-
if ($tsock) {
117-
close $tsock;
118-
$family = $id;
119-
last;
120-
}
109+
my $tsock = IO::Socket::IP->new(
110+
LocalPort => $tport,
111+
Listen => 1,
112+
ReuseAddr => 1
113+
);
114+
if ($tsock) {
115+
$family = $tsock->sockdomain;
116+
close $tsock;
121117
}
122118

123119
if (!$can_fork) {
@@ -153,7 +149,7 @@ if ($pid = fork) {
153149
}
154150
use IO::Socket::IP;
155151
my $sock = IO::Socket::IP->new(
156-
PeerAddr => $addresses[$family]->{client},
152+
PeerAddr => $addresses{$family}->{client},
157153
PeerPort => $tport,
158154
) or die;
159155
if (0) {
@@ -176,7 +172,7 @@ if ($pid = fork) {
176172
else {
177173
die "cannot fork: $!" unless defined $pid;
178174
my $d = HTTP::Daemon->new(
179-
LocalAddr => $addresses[$family]->{server},
175+
LocalAddr => $addresses{$family}->{server},
180176
LocalPort => $tport,
181177
ReuseAddr => 1,
182178
) or die;

0 commit comments

Comments
 (0)