Skip to content

Commit 516a79c

Browse files
authored
fix(cli): po files --frozen flag (#616)
Fix spec tests.
1 parent d5a04dc commit 516a79c

File tree

4 files changed

+14
-7
lines changed

4 files changed

+14
-7
lines changed

.changeset/lazy-flies-draw.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"@lingo.dev/_spec": patch
3+
"lingo.dev": patch
4+
---
5+
6+
po files --frozen flag

packages/cli/src/cli/loaders/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,8 @@ export default function createBucketLoader(
9494
createPoLoader(),
9595
createFlatLoader(),
9696
createSyncLoader(),
97-
createUnlocalizableLoader(options.isCacheRestore, options.returnUnlocalizedKeys),
9897
createVariableLoader({ type: "python" }),
98+
createUnlocalizableLoader(options.isCacheRestore, options.returnUnlocalizedKeys),
9999
);
100100
case "properties":
101101
return composeLoaders(
@@ -127,8 +127,8 @@ export default function createBucketLoader(
127127
createXcodeXcstringsLoader(options.defaultLocale),
128128
createFlatLoader(),
129129
createSyncLoader(),
130-
createUnlocalizableLoader(options.isCacheRestore, options.returnUnlocalizedKeys),
131130
createVariableLoader({ type: "ieee" }),
131+
createUnlocalizableLoader(options.isCacheRestore, options.returnUnlocalizedKeys),
132132
);
133133
case "yaml":
134134
return composeLoaders(

packages/cli/src/cli/loaders/variable/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@ function variableExtractLoader(
2424
return createLoader({
2525
pull: async (locale, input) => {
2626
const result: Record<string, VariableExtractionPayload> = {};
27-
for (const [key, value] of Object.entries(input)) {
27+
const inputValues = _.omitBy(input, _.isEmpty);
28+
for (const [key, value] of Object.entries(inputValues)) {
2829
const matches = value.match(specifierPattern) || [];
2930
result[key] = result[key] || {
3031
value,

packages/spec/src/config.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { describe, it, expect } from "vitest";
2-
import { parseI18nConfig, defaultConfig } from "./config"; // Adjust the import path as needed
2+
import { parseI18nConfig, defaultConfig, LATEST_CONFIG_DEFINITION } from "./config";
33

44
// Helper function to create a v0 config
55
const createV0Config = () => ({
@@ -71,7 +71,7 @@ describe("I18n Config Parser", () => {
7171
const result = parseI18nConfig(v0Config);
7272

7373
expect(result["$schema"]).toBeDefined();
74-
expect(result.version).toBe(1.4);
74+
expect(result.version).toBe(LATEST_CONFIG_DEFINITION.defaultValue.version);
7575
expect(result.locale).toEqual(defaultConfig.locale);
7676
expect(result.buckets).toEqual({});
7777
});
@@ -81,7 +81,7 @@ describe("I18n Config Parser", () => {
8181
const result = parseI18nConfig(v1Config);
8282

8383
expect(result["$schema"]).toBeDefined();
84-
expect(result.version).toBe(1.4);
84+
expect(result.version).toBe(LATEST_CONFIG_DEFINITION.defaultValue.version);
8585
expect(result.locale).toEqual(v1Config.locale);
8686
expect(result.buckets).toEqual({
8787
json: {
@@ -119,7 +119,7 @@ describe("I18n Config Parser", () => {
119119
it("should throw an error for unsupported locales", () => {
120120
const invalidLocaleConfig = createInvalidLocaleConfig();
121121
expect(() => parseI18nConfig(invalidLocaleConfig)).toThrow(
122-
`\nUnsupported locale: ${invalidLocaleConfig.locale.source}\nUnsupported locale: ${invalidLocaleConfig.locale.targets[1]}`,
122+
`\nUnsupported locale: ${invalidLocaleConfig.locale.source}\nUnsupported locale: ${invalidLocaleConfig.locale.targets[1]}`
123123
);
124124
});
125125
});

0 commit comments

Comments
 (0)