fix(cli): exit with non-zero code on localization errors (#2026)

* fix(cli): exit with non-zero code when localization tasks fail

Previously, partial localization errors (e.g., API timeout on one locale)
were caught per-task and stored in results, but the process still exited
with code 0. This caused CI/CD pipelines to silently pass on failures.

Now sets process.exitCode = 1 when any task has error status, in both
the `run` and deprecated `i18n` commands. Also fixes the `run` command
to play the failure sound instead of success when there are errors.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* chore: add changeset for CLI exit code fix

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* refactor: extract exit code logic into shared helper

Addresses CodeRabbit review — tests now import and verify the actual
production function instead of duplicating the logic.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: cherkanovart

.changeset/exit-code-on-errors.md

@@ -0,0 +1,5 @@
+---
+"lingo.dev": patch
+---
+
+Exit with non-zero code when localization tasks fail, so CI/CD pipelines correctly detect partial errors

packages/cli/src/cli/cmd/i18n.ts

@@ -600,6 +600,7 @@ export default new Command()
         await new Promise((resolve) => setTimeout(resolve, 50));
       } else {
         ora.warn("Localization completed with errors.");
+        process.exitCode = 1;
         await trackEvent(email, "cmd.i18n.error", {
           flags,
           ...aggregateErrorAnalytics(

packages/cli/src/cli/cmd/run/exit-code.spec.ts

@@ -0,0 +1,115 @@
+import { describe, it, expect, beforeEach, afterEach } from "vitest";
+import { CmdRunTask, CmdRunTaskResult } from "./_types";
+import { applyRunExitCode } from "./exit-code";
+
+/**
+ * Tests that the CLI exits with non-zero code when localization tasks fail.
+ * This prevents CI/CD pipelines from silently passing on partial errors.
+ */
+describe("run command - exit code on errors", () => {
+  let originalExitCode: number | undefined;
+
+  beforeEach(() => {
+    originalExitCode = process.exitCode;
+    process.exitCode = undefined;
+  });
+
+  afterEach(() => {
+    process.exitCode = originalExitCode;
+  });
+
+  function createTask(overrides?: Partial<CmdRunTask>): CmdRunTask {
+    return {
+      sourceLocale: "en",
+      targetLocale: "es",
+      bucketType: "json",
+      bucketPathPattern: "[locale]/messages.json",
+      injectLocale: [],
+      lockedKeys: [],
+      lockedPatterns: [],
+      ignoredKeys: [],
+      preservedKeys: [],
+      localizableKeys: [],
+      onlyKeys: [],
+      ...overrides,
+    };
+  }
+
+  it("should set exitCode=1 when any task has error status", () => {
+    const results = new Map<CmdRunTask, CmdRunTaskResult>();
+    results.set(createTask({ targetLocale: "es" }), { status: "success" });
+    results.set(createTask({ targetLocale: "fr" }), {
+      status: "error",
+      error: new Error("API timeout"),
+    });
+    results.set(createTask({ targetLocale: "de" }), { status: "success" });
+
+    const hasErrors = applyRunExitCode(results);
+
+    expect(hasErrors).toBe(true);
+    expect(process.exitCode).toBe(1);
+  });
+
+  it("should NOT set exitCode when all tasks succeed", () => {
+    const results = new Map<CmdRunTask, CmdRunTaskResult>();
+    results.set(createTask({ targetLocale: "es" }), { status: "success" });
+    results.set(createTask({ targetLocale: "fr" }), { status: "success" });
+
+    const hasErrors = applyRunExitCode(results);
+
+    expect(hasErrors).toBe(false);
+    expect(process.exitCode).toBeUndefined();
+  });
+
+  it("should NOT set exitCode when tasks are skipped (no errors)", () => {
+    const results = new Map<CmdRunTask, CmdRunTaskResult>();
+    results.set(createTask({ targetLocale: "es" }), { status: "skipped" });
+    results.set(createTask({ targetLocale: "fr" }), { status: "success" });
+
+    const hasErrors = applyRunExitCode(results);
+
+    expect(hasErrors).toBe(false);
+    expect(process.exitCode).toBeUndefined();
+  });
+
+  it("should set exitCode=1 when all tasks fail", () => {
+    const results = new Map<CmdRunTask, CmdRunTaskResult>();
+    results.set(createTask({ targetLocale: "es" }), {
+      status: "error",
+      error: new Error("fail 1"),
+    });
+    results.set(createTask({ targetLocale: "fr" }), {
+      status: "error",
+      error: new Error("fail 2"),
+    });
+
+    const hasErrors = applyRunExitCode(results);
+
+    expect(hasErrors).toBe(true);
+    expect(process.exitCode).toBe(1);
+  });
+
+  it("should set exitCode=1 even with mix of success, skipped, and error", () => {
+    const results = new Map<CmdRunTask, CmdRunTaskResult>();
+    results.set(createTask({ targetLocale: "es" }), { status: "success" });
+    results.set(createTask({ targetLocale: "fr" }), { status: "skipped" });
+    results.set(createTask({ targetLocale: "de" }), {
+      status: "error",
+      error: new Error("one failure"),
+    });
+
+    const hasErrors = applyRunExitCode(results);
+
+    expect(hasErrors).toBe(true);
+    expect(process.exitCode).toBe(1);
+  });
+
+  it("should NOT set exitCode when results map is empty", () => {
+    const results = new Map<CmdRunTask, CmdRunTaskResult>();
+
+    const hasErrors = applyRunExitCode(results);
+
+    expect(hasErrors).toBe(false);
+    expect(process.exitCode).toBeUndefined();
+  });
+});

packages/cli/src/cli/cmd/run/exit-code.ts

@@ -0,0 +1,11 @@
+import { CmdRunTask, CmdRunTaskResult } from "./_types";
+
+export function applyRunExitCode(results: Map<CmdRunTask, CmdRunTaskResult>) {
+  const hasErrors = Array.from(results.values()).some(
+    (r) => r.status === "error",
+  );
+  if (hasErrors) {
+    process.exitCode = 1;
+  }
+  return hasErrors;
+}

packages/cli/src/cli/cmd/run/index.ts

@@ -9,6 +9,7 @@ import execute from "./execute";
 import watch from "./watch";
 import { CmdRunContext, flagsSchema } from "./_types";
 import frozen from "./frozen";
+import { applyRunExitCode } from "./exit-code";
 import {
   renderClear,
   renderSpacer,
@@ -163,9 +164,11 @@ export default new Command()
       await renderSummary(ctx.results);
       await renderSpacer();
 
+      const hasErrors = applyRunExitCode(ctx.results);
+
       // Play sound after main tasks complete if sound flag is enabled
       if (ctx.flags.sound) {
-        await playSound("success");
+        await playSound(hasErrors ? "failure" : "success");
       }
 
       // If watch mode is enabled, start watching for changes