chore: observability status fix (#1724)

* chore: fix observability for status command

* chore: add changeset

Author: vrcprl

.changeset/empty-dryers-happen.md

@@ -0,0 +1,5 @@
+---
+"lingo.dev": patch
+---
+
+fix observability for status command

packages/cli/src/cli/cmd/i18n.ts

@@ -125,7 +125,7 @@ export default new Command()
     }
 
     let hasErrors = false;
-    let authId: string | null = null;
+    let email: string | null = null;
     const errorDetails: ErrorDetail[] = [];
     try {
       ora.start("Loading configuration...");
@@ -141,15 +141,15 @@ export default new Command()
       const isByokMode = !!i18nConfig?.provider;
 
       if (isByokMode) {
-        authId = null;
+        email = null;
         ora.succeed("Using external provider (BYOK mode)");
       } else {
         const auth = await validateAuth(settings);
-        authId = auth.id;
+        email = auth.email;
         ora.succeed(`Authenticated as ${auth.email}`);
       }
 
-      await trackEvent(authId, "cmd.i18n.start", {
+      await trackEvent(email, "cmd.i18n.start", {
         i18nConfig,
         flags,
       });
@@ -569,7 +569,7 @@ export default new Command()
       console.log();
       if (!hasErrors) {
         ora.succeed("Localization completed.");
-        await trackEvent(authId, "cmd.i18n.success", {
+        await trackEvent(email, "cmd.i18n.success", {
           i18nConfig: {
             sourceLocale: i18nConfig!.locale.source,
             targetLocales: i18nConfig!.locale.targets,
@@ -583,7 +583,7 @@ export default new Command()
         await new Promise((resolve) => setTimeout(resolve, 50));
       } else {
         ora.warn("Localization completed with errors.");
-        await trackEvent(authId, "cmd.i18n.error", {
+        await trackEvent(email, "cmd.i18n.error", {
           flags,
           ...aggregateErrorAnalytics(
             errorDetails,
@@ -615,7 +615,7 @@ export default new Command()
         };
       }
 
-      await trackEvent(authId, "cmd.i18n.error", {
+      await trackEvent(email, "cmd.i18n.error", {
         flags,
         errorType,
         errorName: error.name || "Error",

packages/cli/src/cli/cmd/run/_utils.ts

@@ -1,9 +1,10 @@
 import { CmdRunContext } from "./_types";
 
 /**
- * Determines the authentication ID for tracking purposes
+ * Determines the user's email for tracking purposes.
+ * Returns null if using BYOK mode or if authentication fails.
  */
-export async function determineAuthId(
+export async function determineEmail(
   ctx: CmdRunContext,
 ): Promise<string | null> {
   const isByokMode = !!ctx.config?.provider;

packages/cli/src/cli/cmd/run/index.ts

@@ -18,7 +18,7 @@ import {
   renderSummary,
 } from "../../utils/ui";
 import trackEvent from "../../utils/observability";
-import { determineAuthId } from "./_utils";
+import { determineEmail } from "./_utils";
 
 const __dirname = path.dirname(fileURLToPath(import.meta.url));
 
@@ -119,7 +119,7 @@ export default new Command()
     "Play audio feedback when translations complete (success or failure sounds)",
   )
   .action(async (args) => {
-    let authId: string | null = null;
+    let email: string | null = null;
     try {
       const ctx: CmdRunContext = {
         flags: flagsSchema.parse(args),
@@ -138,9 +138,9 @@ export default new Command()
 
       await setup(ctx);
 
-      authId = await determineAuthId(ctx);
+      email = await determineEmail(ctx);
 
-      await trackEvent(authId, "cmd.run.start", {
+      await trackEvent(email, "cmd.run.start", {
         config: ctx.config,
         flags: ctx.flags,
       });
@@ -169,13 +169,17 @@ export default new Command()
         await watch(ctx);
       }
 
-      await trackEvent(authId, "cmd.run.success", {
+      await trackEvent(email, "cmd.run.success", {
         config: ctx.config,
         flags: ctx.flags,
       });
       await new Promise((resolve) => setTimeout(resolve, 50));
     } catch (error: any) {
-      await trackEvent(authId, "cmd.run.error", {});
+      await trackEvent(email, "cmd.run.error", {
+        flags: args,
+        error: error.message,
+        authenticated: !!email,
+      });
       await new Promise((resolve) => setTimeout(resolve, 50));
       // Play sad sound if sound flag is enabled
       if (args.sound) {

packages/cli/src/cli/cmd/status.ts

@@ -63,7 +63,7 @@ export default new Command()
   .action(async function (options) {
     const ora = Ora();
     const flags = parseFlags(options);
-    let authId: string | null = null;
+    let email: string | null = null;
 
     try {
       ora.start("Loading configuration...");
@@ -76,7 +76,7 @@ export default new Command()
         ora.start("Checking authentication status...");
         const auth = await tryAuthenticate(settings);
         if (auth) {
-          authId = auth.id;
+          email = auth.email;
           ora.succeed(`Authenticated as ${auth.email}`);
         } else {
           ora.info(
@@ -92,10 +92,11 @@ export default new Command()
       ora.succeed("Localization configuration is valid");
 
       // Track event with or without authentication
-      trackEvent(authId, "cmd.status.start", {
+      trackEvent(email, "cmd.status.start", {
         i18nConfig,
         flags,
       });
+      await new Promise((resolve) => setTimeout(resolve, 50));
 
       let buckets = getBuckets(i18nConfig!);
       if (flags.bucket?.length) {
@@ -628,22 +629,22 @@ export default new Command()
       }
 
       // Track successful completion
-      trackEvent(authId, "cmd.status.success", {
+      trackEvent(email, "cmd.status.success", {
         i18nConfig,
         flags,
         totalSourceKeyCount,
         languageStats,
         totalWordsToTranslate,
-        authenticated: !!authId,
+        authenticated: !!email,
       });
       await new Promise((resolve) => setTimeout(resolve, 50));
       exitGracefully();
     } catch (error: any) {
       ora.fail(error.message);
-      trackEvent(authId, "cmd.status.error", {
+      trackEvent(email, "cmd.status.error", {
         flags,
         error: error.message,
-        authenticated: !!authId,
+        authenticated: !!email,
       });
       await new Promise((resolve) => setTimeout(resolve, 50));
       process.exit(1);

packages/cli/src/cli/utils/observability.ts

@@ -9,15 +9,15 @@ const POSTHOG_PATH = "/i/v0/e/";
 const REQUEST_TIMEOUT_MS = 3000;
 const TRACKING_VERSION = "2.0";
 
-function determineDistinctId(providedId: string | null | undefined): {
+function determineDistinctId(email: string | null | undefined): {
   distinct_id: string;
   distinct_id_source: string;
   project_id: string | null;
 } {
-  if (providedId) {
+  if (email) {
     const projectId = getRepositoryId();
     return {
-      distinct_id: providedId,
+      distinct_id: email,
       distinct_id_source: "email",
       project_id: projectId,
     };
@@ -46,7 +46,7 @@ function determineDistinctId(providedId: string | null | undefined): {
 }
 
 export default function trackEvent(
-  distinctId: string | null | undefined,
+  email: string | null | undefined,
   event: string,
   properties?: Record<string, any>,
 ): void {
@@ -56,7 +56,7 @@ export default function trackEvent(
 
   setImmediate(() => {
     try {
-      const identityInfo = determineDistinctId(distinctId);
+      const identityInfo = determineDistinctId(email);
 
       if (process.env.DEBUG === "true") {
         console.log(