feat: add provider settings (#1215)

vrcprl · web-flow · commit e858174fd516 · 2025-10-10T18:28:55.000-07:00
* feat: add provider settings

* chore: formatting and changeset

* chore: removed a redundant test
diff --git a/.changeset/modern-seahorses-whisper.md b/.changeset/modern-seahorses-whisper.md
@@ -0,0 +1,6 @@
+---
+"@lingo.dev/_spec": patch
+"lingo.dev": patch
+---
+
+add provider settings
diff --git a/.claude/commands/create-bucket-docs.md b/.claude/commands/create-bucket-docs.md
@@ -58,7 +58,7 @@ Update your `i18n.json` to add [BUCKET_TYPE] support:
 ```json
 {
   "$schema": "https://lingo.dev/schema/i18n.json",
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": ["es"]
@@ -191,7 +191,7 @@ The [BUCKET_TYPE] bucket supports providing context hints to improve translation
 ```json
 {
   "$schema": "https://lingo.dev/schema/i18n.json",
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": ["es"]
diff --git a/i18n.json b/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.7,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/android/i18n.json b/packages/cli/demo/android/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/csv/i18n.json b/packages/cli/demo/csv/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/ejs/i18n.json b/packages/cli/demo/ejs/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/flutter/i18n.json b/packages/cli/demo/flutter/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/html/i18n.json b/packages/cli/demo/html/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/json-dictionary/i18n.json b/packages/cli/demo/json-dictionary/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/json/i18n.json b/packages/cli/demo/json/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/json5/i18n.json b/packages/cli/demo/json5/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/jsonc/i18n.json b/packages/cli/demo/jsonc/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/markdoc/i18n.json b/packages/cli/demo/markdoc/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/markdown/i18n.json b/packages/cli/demo/markdown/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/mdx/i18n.json b/packages/cli/demo/mdx/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/php/i18n.json b/packages/cli/demo/php/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/po/i18n.json b/packages/cli/demo/po/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/properties/i18n.json b/packages/cli/demo/properties/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/srt/i18n.json b/packages/cli/demo/srt/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/txt/i18n.json b/packages/cli/demo/txt/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/typescript/i18n.json b/packages/cli/demo/typescript/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/vtt/i18n.json b/packages/cli/demo/vtt/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/vue-json/i18n.json b/packages/cli/demo/vue-json/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/xcode-strings/i18n.json b/packages/cli/demo/xcode-strings/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/xcode-stringsdict/i18n.json b/packages/cli/demo/xcode-stringsdict/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/xcode-xcstrings/i18n.json b/packages/cli/demo/xcode-xcstrings/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/xliff/i18n.json b/packages/cli/demo/xliff/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/xml/i18n.json b/packages/cli/demo/xml/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/yaml-root-key/i18n.json b/packages/cli/demo/yaml-root-key/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/demo/yaml/i18n.json b/packages/cli/demo/yaml/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.8,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": [
diff --git a/packages/cli/i18n.json b/packages/cli/i18n.json
@@ -1,5 +1,5 @@
 {
-  "version": 1.7,
+  "version": "1.10",
   "locale": {
     "source": "en",
     "targets": ["es"]
diff --git a/packages/cli/src/cli/cmd/run/setup.ts b/packages/cli/src/cli/cmd/run/setup.ts
@@ -67,20 +67,30 @@ export default async function setup(input: CmdRunContext) {
       },
       {
         title: "Checking authentication",
+        enabled: (ctx) => ctx.localizer?.id === "Lingo.dev",
         task: async (ctx, task) => {
           const authStatus = await ctx.localizer!.checkAuth();
           if (!authStatus.authenticated) {
-            throw new Error(
-              `Failed to authenticate with ${chalk.hex(colors.yellow)(
-                ctx.localizer!.id,
-              )} provider. Please check your API key and try again.`,
-            );
+            throw new Error(authStatus.error || "Authentication failed");
           }
           task.title = `Authenticated as ${chalk.hex(colors.yellow)(
             authStatus.username,
           )}`;
         },
       },
+      {
+        title: "Validating configuration",
+        enabled: (ctx) => ctx.localizer?.id !== "Lingo.dev",
+        task: async (ctx, task) => {
+          const validationStatus = await ctx.localizer!.validateSettings!();
+          if (!validationStatus.valid) {
+            throw new Error(
+              validationStatus.error || "Configuration validation failed",
+            );
+          }
+          task.title = `Configuration validated`;
+        },
+      },
       {
         title: "Initializing localization provider",
         async task(ctx, task) {
diff --git a/packages/cli/src/cli/localizer/_types.ts b/packages/cli/src/cli/localizer/_types.ts
@@ -17,7 +17,12 @@ export type LocalizerProgressFn = (
 
 export interface ILocalizer {
   id: "Lingo.dev" | NonNullable<I18nConfig["provider"]>["id"];
-  checkAuth: () => Promise<{ authenticated: boolean; username?: string }>;
+  checkAuth: () => Promise<{
+    authenticated: boolean;
+    username?: string;
+    error?: string;
+  }>;
+  validateSettings?: () => Promise<{ valid: boolean; error?: string }>;
   localize: (
     input: LocalizerData,
     onProgress?: LocalizerProgressFn,
diff --git a/packages/cli/src/cli/localizer/explicit.ts b/packages/cli/src/cli/localizer/explicit.ts
@@ -15,6 +15,8 @@ import { createOllama } from "ollama-ai-provider";
 export default function createExplicitLocalizer(
   provider: NonNullable<I18nConfig["provider"]>,
 ): ILocalizer {
+  const settings = provider.settings || {};
+
   switch (provider.id) {
     default:
       throw new Error(
@@ -39,6 +41,7 @@ export default function createExplicitLocalizer(
         prompt: provider.prompt,
         apiKeyName: "OPENAI_API_KEY",
         baseUrl: provider.baseUrl,
+        settings,
       });
     case "anthropic":
       return createAiSdkLocalizer({
@@ -48,6 +51,7 @@ export default function createExplicitLocalizer(
         prompt: provider.prompt,
         apiKeyName: "ANTHROPIC_API_KEY",
         baseUrl: provider.baseUrl,
+        settings,
       });
     case "google":
       return createAiSdkLocalizer({
@@ -57,6 +61,7 @@ export default function createExplicitLocalizer(
         prompt: provider.prompt,
         apiKeyName: "GOOGLE_API_KEY",
         baseUrl: provider.baseUrl,
+        settings,
       });
     case "openrouter":
       return createAiSdkLocalizer({
@@ -66,13 +71,15 @@ export default function createExplicitLocalizer(
         prompt: provider.prompt,
         apiKeyName: "OPENROUTER_API_KEY",
         baseUrl: provider.baseUrl,
+        settings,
       });
     case "ollama":
       return createAiSdkLocalizer({
         factory: (_params) => createOllama().languageModel(provider.model),
         id: provider.id,
         prompt: provider.prompt,
         skipAuth: true,
+        settings,
       });
     case "mistral":
       return createAiSdkLocalizer({
@@ -82,6 +89,7 @@ export default function createExplicitLocalizer(
         prompt: provider.prompt,
         apiKeyName: "MISTRAL_API_KEY",
         baseUrl: provider.baseUrl,
+        settings,
       });
   }
 }
@@ -93,6 +101,7 @@ function createAiSdkLocalizer(params: {
   apiKeyName?: string;
   baseUrl?: string;
   skipAuth?: boolean;
+  settings?: { temperature?: number };
 }): ILocalizer {
   const skipAuth = params.skipAuth === true;
 
@@ -134,9 +143,15 @@ function createAiSdkLocalizer(params: {
   return {
     id: params.id,
     checkAuth: async () => {
+      // For BYOK providers, auth check is not meaningful
+      // Configuration validation happens in validateSettings
+      return { authenticated: true, username: "anonymous" };
+    },
+    validateSettings: async () => {
       try {
         await generateText({
           model,
+          ...params.settings,
           messages: [
             { role: "system", content: "You are an echo server" },
             { role: "user", content: "OK" },
@@ -145,9 +160,11 @@ function createAiSdkLocalizer(params: {
           ],
         });
 
-        return { authenticated: true, username: "anonymous" };
+        return { valid: true };
       } catch (error) {
-        return { authenticated: false };
+        const errorMessage =
+          error instanceof Error ? error.message : String(error);
+        return { valid: false, error: errorMessage };
       }
     },
     localize: async (input: LocalizerData) => {
@@ -181,6 +198,7 @@ function createAiSdkLocalizer(params: {
 
       const response = await generateText({
         model,
+        ...params.settings,
         messages: [
           { role: "system", content: systemPrompt },
           { role: "user", content: "OK" },
@@ -196,6 +214,13 @@ function createAiSdkLocalizer(params: {
       });
 
       const result = JSON.parse(response.text);
+
+      // Handle both object and string responses
+      if (typeof result.data === "object" && result.data !== null) {
+        return result.data;
+      }
+
+      // Handle string responses - extract and repair JSON
       const index = result.data.indexOf("{");
       const lastIndex = result.data.lastIndexOf("}");
       const trimmed = result.data.slice(index, lastIndex + 1);
diff --git a/packages/cli/src/cli/localizer/lingodotdev.ts b/packages/cli/src/cli/localizer/lingodotdev.ts
diff --git a/packages/cli/src/cli/processor/basic.ts b/packages/cli/src/cli/processor/basic.ts
diff --git a/packages/cli/src/cli/processor/index.ts b/packages/cli/src/cli/processor/index.ts
diff --git a/packages/spec/src/config.spec.ts b/packages/spec/src/config.spec.ts
diff --git a/packages/spec/src/config.ts b/packages/spec/src/config.ts

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "version": 1.7,`
	`2`	`+ "version": "1.10",`
`3`	`3`	`"locale": {`
`4`	`4`	`"source": "en",`
`5`	`5`	`"targets": [`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "version": 1.8,`
	`2`	`+ "version": "1.10",`
`3`	`3`	`"locale": {`
`4`	`4`	`"source": "en",`
`5`	`5`	`"targets": [`