Skip to content

Commit 728d7e5

Browse files
committed
Specify rust-version and remove outdated info from README
The workspace does not compile with Rust 1.60.0 due to a neon target feature: ```log error[E0658]: the target feature `neon` is currently unstable --> src/simd/aarch64.rs:11:18 | 11 | #[target_feature(enable = "neon")] | ^^^^^^^^^^^^^^^ | = note: see issue #44839 <rust-lang/rust#44839> for more information ```
1 parent f06647f commit 728d7e5

3 files changed

Lines changed: 11 additions & 13 deletions

File tree

.github/workflows/ci.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
strategy:
1313
matrix:
1414
rust:
15-
- 1.32.0
15+
- 1.61.0
1616
- stable
1717
- beta
1818
- nightly
@@ -28,7 +28,7 @@ jobs:
2828
- runtime-dispatch-simd
2929
- generic-simd
3030
exclude:
31-
- rust: 1.32.0
31+
- rust: 1.61.0
3232
features: generic-simd
3333
- rust: stable
3434
features: generic-simd
@@ -47,37 +47,37 @@ jobs:
4747
override: true
4848
components: clippy, rustfmt
4949
- uses: Swatinem/rust-cache@v2
50-
- name: Build (1.32.0, default)
50+
- name: Build (1.61.0, default)
5151
uses: actions-rs/cargo@v1.0.3
5252
with:
5353
command: build
5454
args: --release
55-
if: ${{ matrix.features == 'default' && matrix.rust == '1.32.0' }}
56-
- name: Build (1.32.0, non-default)
55+
if: ${{ matrix.features == 'default' && matrix.rust == '1.61.0' }}
56+
- name: Build (1.61.0, non-default)
5757
uses: actions-rs/cargo@v1.0.3
5858
with:
5959
command: build
6060
args: --release --features ${{ matrix.features }}
61-
if: ${{ matrix.features != 'default' && matrix.rust == '1.32.0' }}
61+
if: ${{ matrix.features != 'default' && matrix.rust == '1.61.0' }}
6262
- name: Test (default)
6363
uses: actions-rs/cargo@v1.0.3
6464
with:
6565
command: test
6666
args: --release
67-
if: ${{ matrix.features == 'default' && matrix.rust != '1.32.0' }}
67+
if: ${{ matrix.features == 'default' && matrix.rust != '1.61.0' }}
6868
- name: Test (non-default)
6969
uses: actions-rs/cargo@v1.0.3
7070
with:
7171
command: test
7272
args: --release --features ${{ matrix.features }}
73-
if: ${{ matrix.features != 'default' && matrix.rust != '1.32.0' }}
73+
if: ${{ matrix.features != 'default' && matrix.rust != '1.61.0' }}
7474
- name: bench
7575
uses: actions-rs/cargo@v1.0.3
7676
with:
7777
command: bench
7878
env:
7979
COUNTS: 0,10,1000,100000,10000000
80-
if: ${{ matrix.rust != '1.32.0' }}
80+
if: ${{ matrix.rust != '1.61.0' }}
8181

8282
# Fails currently on check_count_overflow_many
8383
#

Cargo.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
[package]
22
authors = ["Andre Bogus <bogusandre@gmail.de>", "Joshua Landau <joshua@landau.ws>"]
33
description = "count occurrences of a given byte, or the number of UTF-8 code points, in a byte slice, fast"
4-
edition = "2018"
4+
edition = "2021"
5+
rust-version = "1.61.0"
56
name = "bytecount"
67
version = "0.6.9"
78
license = "Apache-2.0/MIT"

README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,6 @@ RUSTFLAGS="-C target-cpu=native" cargo build --release
6464

6565
The scalar algorithm is explained in depth [here](https://llogiq.github.io/2016/09/27/count.html).
6666

67-
**Note: Versions until 0.4.0 worked with Rust as of 1.20.0. Version 0.5.0 until 0.6.0 requires Rust 1.26 or later,
68-
and at least 1.27.2 to use SIMD. Versions from 0.6.0 require Rust 1.32.0 or later.**
69-
7067
## License
7168

7269
Licensed under either of at your discretion:

0 commit comments

Comments
 (0)