Skip to content

Commit 15c0565

Browse files
authored
Merge pull request #687 from marcospereirampj/fix/pyright
fix: strong and consistent typing across the library
2 parents 30a1367 + 3c43516 commit 15c0565

19 files changed

Lines changed: 5265 additions & 1372 deletions

poetry.lock

Lines changed: 143 additions & 127 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,12 @@ Documentation = "https://python-keycloak.readthedocs.io/en/latest/"
3131
"Issue tracker" = "https://github.com/marcospereirampj/python-keycloak/issues"
3232

3333
[tool.poetry.dependencies]
34-
python = ">=3.9,<4.0"
34+
python = ">=3.9,<=3.14"
3535
requests = ">=2.20.0"
3636
requests-toolbelt = ">=0.6.0"
3737
deprecation = ">=2.1.0"
3838
jwcrypto = ">=1.5.4"
3939
httpx = ">=0.23.2"
40-
async-property = ">=0.2.2"
4140
aiofiles = ">=24.1.0"
4241

4342
[tool.poetry.group.docs.dependencies]

src/keycloak/authorization/permission.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ def logic(self) -> str:
133133
return self._logic
134134

135135
@logic.setter
136-
def logic(self, value: str) -> str:
136+
def logic(self, value: str) -> None:
137137
self._logic = value
138138

139139
@property

src/keycloak/authorization/policy.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,9 @@
2424

2525
from keycloak.exceptions import KeycloakAuthorizationConfigError
2626

27+
from .permission import Permission
28+
from .role import Role
29+
2730

2831
class Policy:
2932
"""
@@ -172,7 +175,7 @@ def permissions(self) -> list:
172175
def permissions(self, value: list) -> None:
173176
self._permissions = value
174177

175-
def add_role(self, role: dict) -> None:
178+
def add_role(self, role: str | Role) -> None:
176179
"""
177180
Add keycloak role in policy.
178181
@@ -185,7 +188,7 @@ def add_role(self, role: dict) -> None:
185188
raise KeycloakAuthorizationConfigError(error_msg)
186189
self._roles.append(role)
187190

188-
def add_permission(self, permission: dict) -> None:
191+
def add_permission(self, permission: str | Permission) -> None:
189192
"""
190193
Add keycloak permission in policy.
191194

src/keycloak/authorization/role.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def get_name(self) -> str:
6161
"""
6262
return self.name
6363

64-
def __eq__(self, other: str | Role) -> bool:
64+
def __eq__(self, other: object) -> bool:
6565
"""
6666
Eq method.
6767

0 commit comments

Comments
 (0)