Skip to content

Commit ad6ff06

Browse files
committed
fix: retry upon 401
1 parent b5e966f commit ad6ff06

2 files changed

Lines changed: 36 additions & 6 deletions

File tree

src/keycloak/openid_connection.py

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -389,6 +389,10 @@ def raw_get(self, *args, **kwargs):
389389
"""
390390
self._refresh_if_required()
391391
r = super().raw_get(*args, **kwargs)
392+
if r.status_code == 401:
393+
self.refresh_token()
394+
r = super().raw_get(*args, **kwargs)
395+
392396
return r
393397

394398
def raw_post(self, *args, **kwargs):
@@ -406,6 +410,10 @@ def raw_post(self, *args, **kwargs):
406410
"""
407411
self._refresh_if_required()
408412
r = super().raw_post(*args, **kwargs)
413+
if r.status_code == 401:
414+
self.refresh_token()
415+
r = super().raw_post(*args, **kwargs)
416+
409417
return r
410418

411419
def raw_put(self, *args, **kwargs):
@@ -423,6 +431,10 @@ def raw_put(self, *args, **kwargs):
423431
"""
424432
self._refresh_if_required()
425433
r = super().raw_put(*args, **kwargs)
434+
if r.status_code == 401:
435+
self.refresh_token()
436+
r = super().raw_put(*args, **kwargs)
437+
426438
return r
427439

428440
def raw_delete(self, *args, **kwargs):
@@ -440,6 +452,10 @@ def raw_delete(self, *args, **kwargs):
440452
"""
441453
self._refresh_if_required()
442454
r = super().raw_delete(*args, **kwargs)
455+
if r.status_code == 401:
456+
self.refresh_token()
457+
r = super().raw_delete(*args, **kwargs)
458+
443459
return r
444460

445461
async def a_get_token(self):
@@ -496,6 +512,10 @@ async def a_raw_get(self, *args, **kwargs):
496512
"""
497513
await self.a__refresh_if_required()
498514
r = await super().a_raw_get(*args, **kwargs)
515+
if r.status_code == 401:
516+
await self.a_refresh_token()
517+
r = await super().a_raw_get(*args, **kwargs)
518+
499519
return r
500520

501521
async def a_raw_post(self, *args, **kwargs):
@@ -513,6 +533,10 @@ async def a_raw_post(self, *args, **kwargs):
513533
"""
514534
await self.a__refresh_if_required()
515535
r = await super().a_raw_post(*args, **kwargs)
536+
if r.status_code == 401:
537+
await self.a_refresh_token()
538+
r = await super().a_raw_post(*args, **kwargs)
539+
516540
return r
517541

518542
async def a_raw_put(self, *args, **kwargs):
@@ -530,6 +554,10 @@ async def a_raw_put(self, *args, **kwargs):
530554
"""
531555
await self.a__refresh_if_required()
532556
r = await super().a_raw_put(*args, **kwargs)
557+
if r.status_code == 401:
558+
await self.a_refresh_token()
559+
r = await super().a_raw_put(*args, **kwargs)
560+
533561
return r
534562

535563
async def a_raw_delete(self, *args, **kwargs):
@@ -547,4 +575,8 @@ async def a_raw_delete(self, *args, **kwargs):
547575
"""
548576
await self.a__refresh_if_required()
549577
r = await super().a_raw_delete(*args, **kwargs)
578+
if r.status_code == 401:
579+
await self.a_refresh_token()
580+
r = await super().a_raw_delete(*args, **kwargs)
581+
550582
return r

tests/test_keycloak_admin.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2771,9 +2771,8 @@ def test_auto_refresh(admin_frozen: KeycloakAdmin, realm: str):
27712771
"Content-Type": "application/json",
27722772
}
27732773

2774-
with pytest.raises(KeycloakAuthenticationError) as err:
2775-
admin.get_realm(realm_name=realm)
2776-
assert err.match('401: b\'{"error":"HTTP 401 Unauthorized".*}\'')
2774+
res = admin.get_realm(realm_name=realm)
2775+
assert res["realm"] == realm
27772776

27782777
# Freeze time to simulate the access token expiring
27792778
with freezegun.freeze_time("2023-02-25 10:05:00"):
@@ -6008,9 +6007,8 @@ async def test_a_auto_refresh(admin_frozen: KeycloakAdmin, realm: str):
60086007
"Content-Type": "application/json",
60096008
}
60106009

6011-
with pytest.raises(KeycloakAuthenticationError) as err:
6012-
await admin.a_get_realm(realm_name=realm)
6013-
assert err.match('401: b\'{"error":"HTTP 401 Unauthorized".*}\'')
6010+
res = await admin.a_get_realm(realm_name=realm)
6011+
assert res["realm"] == realm
60146012

60156013
# Freeze time to simulate the access token expiring
60166014
with freezegun.freeze_time("2023-02-25 10:05:00"):

0 commit comments

Comments
 (0)