From 21950bade5a7761dc7e2ccfac3f704787ce3b76b Mon Sep 17 00:00:00 2001 From: guettonenrique Date: Sun, 25 Oct 2026 05:44:10 -0600 Subject: [PATCH] fix(nitrogen): avoid impossible type check for RecyclableView on Kotlin 2.4 --- .../nitrogen/src/views/kotlin/KotlinHybridViewManager.ts | 6 +++--- .../nitro/test/views/HybridRecyclableTestViewManager.kt | 6 +++--- .../com/margelo/nitro/test/views/HybridTestViewManager.kt | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/packages/nitrogen/src/views/kotlin/KotlinHybridViewManager.ts b/packages/nitrogen/src/views/kotlin/KotlinHybridViewManager.ts index d3f2623865..65cfcf6b20 100644 --- a/packages/nitrogen/src/views/kotlin/KotlinHybridViewManager.ts +++ b/packages/nitrogen/src/views/kotlin/KotlinHybridViewManager.ts @@ -114,10 +114,10 @@ public class ${manager}: SimpleViewManager() { val hybridView = holder.hybridView holder.lastState = null - @Suppress("USELESS_IS_CHECK") - if (hybridView is RecyclableView) { + val recyclableView = (hybridView as Any) as? RecyclableView + if (recyclableView != null) { // Recycle in it's implementation - hybridView.prepareForRecycle() + recyclableView.prepareForRecycle() // Maybe update the view if it changed return hybridView.view diff --git a/tests/react-native/packages/react-native-nitro-test/nitrogen/generated/android/kotlin/com/margelo/nitro/test/views/HybridRecyclableTestViewManager.kt b/tests/react-native/packages/react-native-nitro-test/nitrogen/generated/android/kotlin/com/margelo/nitro/test/views/HybridRecyclableTestViewManager.kt index 06f4d24dd2..d2e15b0912 100644 --- a/tests/react-native/packages/react-native-nitro-test/nitrogen/generated/android/kotlin/com/margelo/nitro/test/views/HybridRecyclableTestViewManager.kt +++ b/tests/react-native/packages/react-native-nitro-test/nitrogen/generated/android/kotlin/com/margelo/nitro/test/views/HybridRecyclableTestViewManager.kt @@ -78,10 +78,10 @@ public class HybridRecyclableTestViewManager: SimpleViewManager() { val hybridView = holder.hybridView holder.lastState = null - @Suppress("USELESS_IS_CHECK") - if (hybridView is RecyclableView) { + val recyclableView = (hybridView as Any) as? RecyclableView + if (recyclableView != null) { // Recycle in it's implementation - hybridView.prepareForRecycle() + recyclableView.prepareForRecycle() // Maybe update the view if it changed return hybridView.view diff --git a/tests/react-native/packages/react-native-nitro-test/nitrogen/generated/android/kotlin/com/margelo/nitro/test/views/HybridTestViewManager.kt b/tests/react-native/packages/react-native-nitro-test/nitrogen/generated/android/kotlin/com/margelo/nitro/test/views/HybridTestViewManager.kt index 3543c60462..c7f5c72e08 100644 --- a/tests/react-native/packages/react-native-nitro-test/nitrogen/generated/android/kotlin/com/margelo/nitro/test/views/HybridTestViewManager.kt +++ b/tests/react-native/packages/react-native-nitro-test/nitrogen/generated/android/kotlin/com/margelo/nitro/test/views/HybridTestViewManager.kt @@ -78,10 +78,10 @@ public class HybridTestViewManager: SimpleViewManager() { val hybridView = holder.hybridView holder.lastState = null - @Suppress("USELESS_IS_CHECK") - if (hybridView is RecyclableView) { + val recyclableView = (hybridView as Any) as? RecyclableView + if (recyclableView != null) { // Recycle in it's implementation - hybridView.prepareForRecycle() + recyclableView.prepareForRecycle() // Maybe update the view if it changed return hybridView.view