Root Finding: Newton-Raphson to check for zero after each eval to avoid NaN. Closes #774.

Author: cdrnet

src/Numerics/RootFinding/NewtonRaphson.cs

@@ -99,6 +99,11 @@ public static bool TryFindRoot(Func<double, double> f, Func<double, double> df,
             {
                 // Evaluation
                 double fx = f(root);
+                if (fx == 0.0)
+                {
+                    return true;
+                }
+
                 double dfx = df(root);
 
                 // Netwon-Raphson step

src/Numerics/RootFinding/RobustNewtonRaphson.cs

@@ -91,6 +91,11 @@ public static bool TryFindRoot(Func<double, double> f, Func<double, double> df,
 
             root = 0.5*(lowerBound + upperBound);
             double fx = f(root);
+            if (fx == 0.0)
+            {
+                return true;
+            }
+
             double lastStep = Math.Abs(upperBound - lowerBound);
             for (int i = 0; i < maxIterations; i++)
             {
@@ -119,6 +124,11 @@ public static bool TryFindRoot(Func<double, double> f, Func<double, double> df,
                     // Bisection
                     root = 0.5*(upperBound + lowerBound);
                     fx = f(root);
+                    if (fx == 0.0)
+                    {
+                        return true;
+                    }
+
                     lastStep = 0.5*Math.Abs(upperBound - lowerBound);
                     if (Math.Sign(fx) == Math.Sign(fmin))
                     {
@@ -146,6 +156,11 @@ public static bool TryFindRoot(Func<double, double> f, Func<double, double> df,
 
                 // Evaluation
                 fx = f(root);
+                if (fx == 0.0)
+                {
+                    return true;
+                }
+
                 lastStep = step;
 
                 // Update bounds