Code Maintenance

Author: cdrnet

src/Numerics/Integration/NewtonCotesTrapeziumRule.cs

@@ -268,8 +268,8 @@ public static double IntegrateAdaptiveTransformedOdd(
                 // First Level
                 abcissasIterator.MoveNext();
                 weightsIterator.MoveNext();
-                double[] abcissasL1 = abcissasIterator.Current;
-                double[] weightsL1 = weightsIterator.Current;
+                double[] abcissasL1 = abcissasIterator.Current ?? throw new ArgumentNullException(nameof(levelAbscissas));
+                double[] weightsL1 = weightsIterator.Current ?? throw new ArgumentNullException(nameof(levelWeights));
 
                 double sum = f(linearOffset)*weightsL1[0];
                 for (int i = 1; i < abcissasL1.Length; i++)
@@ -283,8 +283,8 @@ public static double IntegrateAdaptiveTransformedOdd(
                 double previousDelta = double.MaxValue;
                 for (int level = 1; abcissasIterator.MoveNext() && weightsIterator.MoveNext(); level++)
                 {
-                    double[] abcissas = abcissasIterator.Current;
-                    double[] weights = weightsIterator.Current;
+                    double[] abcissas = abcissasIterator.Current ?? throw new ArgumentNullException(nameof(levelAbscissas));
+                    double[] weights = weightsIterator.Current ?? throw new ArgumentNullException(nameof(levelWeights));
 
                     double midpointsum = 0;
                     for (int i = 0; i < abcissas.Length; i++)
@@ -367,8 +367,8 @@ public static Complex ContourIntegrateAdaptiveTransformedOdd(
                 // First Level
                 abcissasIterator.MoveNext();
                 weightsIterator.MoveNext();
-                double[] abcissasL1 = abcissasIterator.Current;
-                double[] weightsL1 = weightsIterator.Current;
+                double[] abcissasL1 = abcissasIterator.Current ?? throw new ArgumentNullException(nameof(levelAbscissas));
+                double[] weightsL1 = weightsIterator.Current ?? throw new ArgumentNullException(nameof(levelWeights));
 
                 Complex sum = f(linearOffset) * weightsL1[0];
                 for (int i = 1; i < abcissasL1.Length; i++)
@@ -382,8 +382,8 @@ public static Complex ContourIntegrateAdaptiveTransformedOdd(
                 double previousDelta = double.MaxValue;
                 for (int level = 1; abcissasIterator.MoveNext() && weightsIterator.MoveNext(); level++)
                 {
-                    double[] abcissas = abcissasIterator.Current;
-                    double[] weights = weightsIterator.Current;
+                    double[] abcissas = abcissasIterator.Current ?? throw new ArgumentNullException(nameof(levelAbscissas));
+                    double[] weights = weightsIterator.Current ?? throw new ArgumentNullException(nameof(levelWeights));
 
                     Complex midpointsum = 0;
                     for (int i = 0; i < abcissas.Length; i++)

src/Numerics/Optimization/MinimizerBase.cs

@@ -59,15 +59,15 @@ protected MinimizerBase(double gradientTolerance, double parameterTolerance, dou
 
         protected ExitCondition ExitCriteriaSatisfied(IObjectiveFunctionEvaluation candidatePoint, IObjectiveFunctionEvaluation lastPoint, int iterations)
         {
-            Vector<double> relGrad = new DenseVector(candidatePoint.Point.Count);
+            var candidatePointPoint = candidatePoint.Point;
             double relativeGradient = 0.0;
             double normalizer = Math.Max(Math.Abs(candidatePoint.Value), 1.0);
-            for (int ii = 0; ii < relGrad.Count; ++ii)
+            for (int ii = 0; ii < candidatePointPoint.Count; ++ii)
             {
                 double projectedGradient = GetProjectedGradient(candidatePoint, ii);
 
                 double tmp = projectedGradient *
-                    Math.Max(Math.Abs(candidatePoint.Point[ii]), 1.0) / normalizer;
+                    Math.Max(Math.Abs(candidatePointPoint[ii]), 1.0) / normalizer;
                 relativeGradient = Math.Max(relativeGradient, Math.Abs(tmp));
             }
             if (relativeGradient < GradientTolerance)
@@ -77,11 +77,12 @@ protected ExitCondition ExitCriteriaSatisfied(IObjectiveFunctionEvaluation candi
 
             if (lastPoint != null)
             {
+                var lastPointPoint = lastPoint.Point;
                 double mostProgress = 0.0;
-                for (int ii = 0; ii < candidatePoint.Point.Count; ++ii)
+                for (int ii = 0; ii < candidatePointPoint.Count; ++ii)
                 {
-                    var tmp = Math.Abs(candidatePoint.Point[ii] - lastPoint.Point[ii]) /
-                        Math.Max(Math.Abs(lastPoint.Point[ii]), 1.0);
+                    var tmp = Math.Abs(candidatePointPoint[ii] - lastPointPoint[ii]) /
+                              Math.Max(Math.Abs(lastPointPoint[ii]), 1.0);
                     mostProgress = Math.Max(mostProgress, tmp);
                 }
                 if (mostProgress < ParameterTolerance)