diagnostics: tweak error message to give more rationale to unsafe Fn

notriddle · notriddle · commit 6d18fbbc3f1f · 2022-04-05T11:13:48.000-07:00
diff --git a/library/core/src/ops/function.rs b/library/core/src/ops/function.rs
@@ -61,8 +61,9 @@
     ),
     on(
         _Self = "unsafe fn",
+        note = "unsafe function cannot be called generically without an unsafe block",
         // SAFETY: tidy is not smart enough to tell that the below unsafe block is a string
-        note = "unsafe functions must be wrapped in closures: `|| unsafe {{ /* code */ }}`"
+        label = "call the function in a closure: `|| unsafe {{ /* code */ }}`"
     ),
     message = "expected a `{Fn}<{Args}>` closure, found `{Self}`",
     label = "expected an `Fn<{Args}>` closure, found `{Self}`"
@@ -146,8 +147,9 @@ pub trait Fn<Args>: FnMut<Args> {
     ),
     on(
         _Self = "unsafe fn",
+        note = "unsafe function cannot be called generically without an unsafe block",
         // SAFETY: tidy is not smart enough to tell that the below unsafe block is a string
-        note = "unsafe functions must be wrapped in closures: `|| unsafe {{ /* code */ }}`"
+        label = "call the function in a closure: `|| unsafe {{ /* code */ }}`"
     ),
     message = "expected a `{FnMut}<{Args}>` closure, found `{Self}`",
     label = "expected an `FnMut<{Args}>` closure, found `{Self}`"
@@ -223,8 +225,9 @@ pub trait FnMut<Args>: FnOnce<Args> {
     ),
     on(
         _Self = "unsafe fn",
+        note = "unsafe function cannot be called generically without an unsafe block",
         // SAFETY: tidy is not smart enough to tell that the below unsafe block is a string
-        note = "unsafe functions must be wrapped in closures: `|| unsafe {{ /* code */ }}`"
+        label = "call the function in a closure: `|| unsafe {{ /* code */ }}`"
     ),
     message = "expected a `{FnOnce}<{Args}>` closure, found `{Self}`",
     label = "expected an `FnOnce<{Args}>` closure, found `{Self}`"
diff --git a/src/test/ui/closures/coerce-unsafe-to-closure.stderr b/src/test/ui/closures/coerce-unsafe-to-closure.stderr
@@ -2,12 +2,12 @@ error[E0277]: expected a `FnOnce<(&str,)>` closure, found `unsafe extern "rust-i
   --> $DIR/coerce-unsafe-to-closure.rs:2:44
    |
 LL |     let x: Option<&[u8]> = Some("foo").map(std::mem::transmute);
-   |                                        --- ^^^^^^^^^^^^^^^^^^^ expected an `FnOnce<(&str,)>` closure, found `unsafe extern "rust-intrinsic" fn(_) -> _ {transmute::<_, _>}`
+   |                                        --- ^^^^^^^^^^^^^^^^^^^ call the function in a closure: `|| unsafe { /* code */ }`
    |                                        |
    |                                        required by a bound introduced by this call
    |
    = help: the trait `FnOnce<(&str,)>` is not implemented for `unsafe extern "rust-intrinsic" fn(_) -> _ {transmute::<_, _>}`
-   = note: unsafe functions must be wrapped in closures: `|| unsafe { /* code */ }`
+   = note: unsafe function cannot be called generically without an unsafe block
 note: required by a bound in `Option::<T>::map`
   --> $SRC_DIR/core/src/option.rs:LL:COL
    |
diff --git a/src/test/ui/rfcs/rfc-2396-target_feature-11/fn-traits.stderr b/src/test/ui/rfcs/rfc-2396-target_feature-11/fn-traits.stderr
@@ -53,7 +53,7 @@ error[E0277]: expected a `Fn<()>` closure, found `unsafe fn() {foo_unsafe}`
   --> $DIR/fn-traits.rs:28:10
    |
 LL |     call(foo_unsafe);
-   |     ---- ^^^^^^^^^^ expected an `Fn<()>` closure, found `unsafe fn() {foo_unsafe}`
+   |     ---- ^^^^^^^^^^ call the function in a closure: `|| unsafe { /* code */ }`
    |     |
    |     required by a bound introduced by this call
    |
@@ -70,7 +70,7 @@ error[E0277]: expected a `FnMut<()>` closure, found `unsafe fn() {foo_unsafe}`
   --> $DIR/fn-traits.rs:30:14
    |
 LL |     call_mut(foo_unsafe);
-   |     -------- ^^^^^^^^^^ expected an `FnMut<()>` closure, found `unsafe fn() {foo_unsafe}`
+   |     -------- ^^^^^^^^^^ call the function in a closure: `|| unsafe { /* code */ }`
    |     |
    |     required by a bound introduced by this call
    |
@@ -87,7 +87,7 @@ error[E0277]: expected a `FnOnce<()>` closure, found `unsafe fn() {foo_unsafe}`
   --> $DIR/fn-traits.rs:32:15
    |
 LL |     call_once(foo_unsafe);
-   |     --------- ^^^^^^^^^^ expected an `FnOnce<()>` closure, found `unsafe fn() {foo_unsafe}`
+   |     --------- ^^^^^^^^^^ call the function in a closure: `|| unsafe { /* code */ }`
    |     |
    |     required by a bound introduced by this call
    |
diff --git a/src/test/ui/unboxed-closures/unboxed-closures-unsafe-extern-fn.stderr b/src/test/ui/unboxed-closures/unboxed-closures-unsafe-extern-fn.stderr
@@ -2,12 +2,12 @@ error[E0277]: expected a `Fn<(&isize,)>` closure, found `for<'r> unsafe fn(&'r i
   --> $DIR/unboxed-closures-unsafe-extern-fn.rs:20:21
    |
 LL |     let x = call_it(&square, 22);
-   |             ------- ^^^^^^^ expected an `Fn<(&isize,)>` closure, found `for<'r> unsafe fn(&'r isize) -> isize {square}`
+   |             ------- ^^^^^^^ call the function in a closure: `|| unsafe { /* code */ }`
    |             |
    |             required by a bound introduced by this call
    |
    = help: the trait `for<'r> Fn<(&'r isize,)>` is not implemented for `for<'r> unsafe fn(&'r isize) -> isize {square}`
-   = note: unsafe functions must be wrapped in closures: `|| unsafe { /* code */ }`
+   = note: unsafe function cannot be called generically without an unsafe block
 note: required by a bound in `call_it`
   --> $DIR/unboxed-closures-unsafe-extern-fn.rs:9:15
    |
@@ -18,12 +18,12 @@ error[E0277]: expected a `FnMut<(&isize,)>` closure, found `for<'r> unsafe fn(&'
   --> $DIR/unboxed-closures-unsafe-extern-fn.rs:25:25
    |
 LL |     let y = call_it_mut(&mut square, 22);
-   |             ----------- ^^^^^^^^^^^ expected an `FnMut<(&isize,)>` closure, found `for<'r> unsafe fn(&'r isize) -> isize {square}`
+   |             ----------- ^^^^^^^^^^^ call the function in a closure: `|| unsafe { /* code */ }`
    |             |
    |             required by a bound introduced by this call
    |
    = help: the trait `for<'r> FnMut<(&'r isize,)>` is not implemented for `for<'r> unsafe fn(&'r isize) -> isize {square}`
-   = note: unsafe functions must be wrapped in closures: `|| unsafe { /* code */ }`
+   = note: unsafe function cannot be called generically without an unsafe block
 note: required by a bound in `call_it_mut`
   --> $DIR/unboxed-closures-unsafe-extern-fn.rs:12:19
    |
@@ -34,12 +34,12 @@ error[E0277]: expected a `FnOnce<(&isize,)>` closure, found `for<'r> unsafe fn(&
   --> $DIR/unboxed-closures-unsafe-extern-fn.rs:30:26
    |
 LL |     let z = call_it_once(square, 22);
-   |             ------------ ^^^^^^ expected an `FnOnce<(&isize,)>` closure, found `for<'r> unsafe fn(&'r isize) -> isize {square}`
+   |             ------------ ^^^^^^ call the function in a closure: `|| unsafe { /* code */ }`
    |             |
    |             required by a bound introduced by this call
    |
    = help: the trait `for<'r> FnOnce<(&'r isize,)>` is not implemented for `for<'r> unsafe fn(&'r isize) -> isize {square}`
-   = note: unsafe functions must be wrapped in closures: `|| unsafe { /* code */ }`
+   = note: unsafe function cannot be called generically without an unsafe block
 note: required by a bound in `call_it_once`
   --> $DIR/unboxed-closures-unsafe-extern-fn.rs:15:20
    |
diff --git a/src/test/ui/unboxed-closures/unboxed-closures-wrong-arg-type-extern-fn.stderr b/src/test/ui/unboxed-closures/unboxed-closures-wrong-arg-type-extern-fn.stderr
@@ -2,12 +2,12 @@ error[E0277]: expected a `Fn<(&isize,)>` closure, found `unsafe fn(isize) -> isi
   --> $DIR/unboxed-closures-wrong-arg-type-extern-fn.rs:21:21
    |
 LL |     let x = call_it(&square, 22);
-   |             ------- ^^^^^^^ expected an `Fn<(&isize,)>` closure, found `unsafe fn(isize) -> isize {square}`
+   |             ------- ^^^^^^^ call the function in a closure: `|| unsafe { /* code */ }`
    |             |
    |             required by a bound introduced by this call
    |
    = help: the trait `for<'r> Fn<(&'r isize,)>` is not implemented for `unsafe fn(isize) -> isize {square}`
-   = note: unsafe functions must be wrapped in closures: `|| unsafe { /* code */ }`
+   = note: unsafe function cannot be called generically without an unsafe block
 note: required by a bound in `call_it`
   --> $DIR/unboxed-closures-wrong-arg-type-extern-fn.rs:10:15
    |
@@ -18,12 +18,12 @@ error[E0277]: expected a `FnMut<(&isize,)>` closure, found `unsafe fn(isize) ->
   --> $DIR/unboxed-closures-wrong-arg-type-extern-fn.rs:26:25
    |
 LL |     let y = call_it_mut(&mut square, 22);
-   |             ----------- ^^^^^^^^^^^ expected an `FnMut<(&isize,)>` closure, found `unsafe fn(isize) -> isize {square}`
+   |             ----------- ^^^^^^^^^^^ call the function in a closure: `|| unsafe { /* code */ }`
    |             |
    |             required by a bound introduced by this call
    |
    = help: the trait `for<'r> FnMut<(&'r isize,)>` is not implemented for `unsafe fn(isize) -> isize {square}`
-   = note: unsafe functions must be wrapped in closures: `|| unsafe { /* code */ }`
+   = note: unsafe function cannot be called generically without an unsafe block
 note: required by a bound in `call_it_mut`
   --> $DIR/unboxed-closures-wrong-arg-type-extern-fn.rs:13:19
    |
@@ -34,12 +34,12 @@ error[E0277]: expected a `FnOnce<(&isize,)>` closure, found `unsafe fn(isize) ->
   --> $DIR/unboxed-closures-wrong-arg-type-extern-fn.rs:31:26
    |
 LL |     let z = call_it_once(square, 22);
-   |             ------------ ^^^^^^ expected an `FnOnce<(&isize,)>` closure, found `unsafe fn(isize) -> isize {square}`
+   |             ------------ ^^^^^^ call the function in a closure: `|| unsafe { /* code */ }`
    |             |
    |             required by a bound introduced by this call
    |
    = help: the trait `for<'r> FnOnce<(&'r isize,)>` is not implemented for `unsafe fn(isize) -> isize {square}`
-   = note: unsafe functions must be wrapped in closures: `|| unsafe { /* code */ }`
+   = note: unsafe function cannot be called generically without an unsafe block
 note: required by a bound in `call_it_once`
   --> $DIR/unboxed-closures-wrong-arg-type-extern-fn.rs:16:20
    |

Original file line number	Diff line number	Diff line change
@@ -2,12 +2,12 @@ error[E0277]: expected a `FnOnce<(&str,)>` closure, found `unsafe extern "rust-i
`2`	`2`	`--> $DIR/coerce-unsafe-to-closure.rs:2:44`
`3`	`3`	`\|`
`4`	`4`	`LL \| let x: Option<&[u8]> = Some("foo").map(std::mem::transmute);`
`5`		- \| --- ^^^^^^^^^^^^^^^^^^^ expected an `FnOnce<(&str,)>` closure, found `unsafe extern "rust-intrinsic" fn(_) -> _ {transmute::<_, _>}`
	`5`	+ \| --- ^^^^^^^^^^^^^^^^^^^ call the function in a closure: `\|\| unsafe { /* code */ }`
`6`	`6`	`\| \|`
`7`	`7`	`\| required by a bound introduced by this call`
`8`	`8`	`\|`
`9`	`9`	= help: the trait `FnOnce<(&str,)>` is not implemented for `unsafe extern "rust-intrinsic" fn(_) -> _ {transmute::<_, _>}`
`10`		- = note: unsafe functions must be wrapped in closures: `\|\| unsafe { /* code */ }`
	`10`	`+ = note: unsafe function cannot be called generically without an unsafe block`
`11`	`11`	note: required by a bound in `Option::<T>::map`
`12`	`12`	`--> $SRC_DIR/core/src/option.rs:LL:COL`
`13`	`13`	`\|`
Original file line number	Diff line number	Diff line change
@@ -53,7 +53,7 @@ error[E0277]: expected a `Fn<()>` closure, found `unsafe fn() {foo_unsafe}`
`53`	`53`	`--> $DIR/fn-traits.rs:28:10`
`54`	`54`	`\|`
`55`	`55`	`LL \| call(foo_unsafe);`
`56`		- \| ---- ^^^^^^^^^^ expected an `Fn<()>` closure, found `unsafe fn() {foo_unsafe}`
	`56`	+ \| ---- ^^^^^^^^^^ call the function in a closure: `\|\| unsafe { /* code */ }`
`57`	`57`	`\| \|`
`58`	`58`	`\| required by a bound introduced by this call`
`59`	`59`	`\|`
@@ -70,7 +70,7 @@ error[E0277]: expected a `FnMut<()>` closure, found `unsafe fn() {foo_unsafe}`
`70`	`70`	`--> $DIR/fn-traits.rs:30:14`
`71`	`71`	`\|`
`72`	`72`	`LL \| call_mut(foo_unsafe);`
`73`		- \| -------- ^^^^^^^^^^ expected an `FnMut<()>` closure, found `unsafe fn() {foo_unsafe}`
	`73`	+ \| -------- ^^^^^^^^^^ call the function in a closure: `\|\| unsafe { /* code */ }`
`74`	`74`	`\| \|`
`75`	`75`	`\| required by a bound introduced by this call`
`76`	`76`	`\|`
@@ -87,7 +87,7 @@ error[E0277]: expected a `FnOnce<()>` closure, found `unsafe fn() {foo_unsafe}`
`87`	`87`	`--> $DIR/fn-traits.rs:32:15`
`88`	`88`	`\|`
`89`	`89`	`LL \| call_once(foo_unsafe);`
`90`		- \| --------- ^^^^^^^^^^ expected an `FnOnce<()>` closure, found `unsafe fn() {foo_unsafe}`
	`90`	+ \| --------- ^^^^^^^^^^ call the function in a closure: `\|\| unsafe { /* code */ }`
`91`	`91`	`\| \|`
`92`	`92`	`\| required by a bound introduced by this call`
`93`	`93`	`\|`
Original file line number	Diff line number	Diff line change
@@ -2,12 +2,12 @@ error[E0277]: expected a `Fn<(&isize,)>` closure, found `for<'r> unsafe fn(&'r i
`2`	`2`	`--> $DIR/unboxed-closures-unsafe-extern-fn.rs:20:21`
`3`	`3`	`\|`
`4`	`4`	`LL \| let x = call_it(&square, 22);`
`5`		- \| ------- ^^^^^^^ expected an `Fn<(&isize,)>` closure, found `for<'r> unsafe fn(&'r isize) -> isize {square}`
	`5`	+ \| ------- ^^^^^^^ call the function in a closure: `\|\| unsafe { /* code */ }`
`6`	`6`	`\| \|`
`7`	`7`	`\| required by a bound introduced by this call`
`8`	`8`	`\|`
`9`	`9`	= help: the trait `for<'r> Fn<(&'r isize,)>` is not implemented for `for<'r> unsafe fn(&'r isize) -> isize {square}`
`10`		- = note: unsafe functions must be wrapped in closures: `\|\| unsafe { /* code */ }`
	`10`	`+ = note: unsafe function cannot be called generically without an unsafe block`
`11`	`11`	note: required by a bound in `call_it`
`12`	`12`	`--> $DIR/unboxed-closures-unsafe-extern-fn.rs:9:15`
`13`	`13`	`\|`
@@ -18,12 +18,12 @@ error[E0277]: expected a `FnMut<(&isize,)>` closure, found `for<'r> unsafe fn(&'
`18`	`18`	`--> $DIR/unboxed-closures-unsafe-extern-fn.rs:25:25`
`19`	`19`	`\|`
`20`	`20`	`LL \| let y = call_it_mut(&mut square, 22);`
`21`		- \| ----------- ^^^^^^^^^^^ expected an `FnMut<(&isize,)>` closure, found `for<'r> unsafe fn(&'r isize) -> isize {square}`
	`21`	+ \| ----------- ^^^^^^^^^^^ call the function in a closure: `\|\| unsafe { /* code */ }`
`22`	`22`	`\| \|`
`23`	`23`	`\| required by a bound introduced by this call`
`24`	`24`	`\|`
`25`	`25`	= help: the trait `for<'r> FnMut<(&'r isize,)>` is not implemented for `for<'r> unsafe fn(&'r isize) -> isize {square}`
`26`		- = note: unsafe functions must be wrapped in closures: `\|\| unsafe { /* code */ }`
	`26`	`+ = note: unsafe function cannot be called generically without an unsafe block`
`27`	`27`	note: required by a bound in `call_it_mut`
`28`	`28`	`--> $DIR/unboxed-closures-unsafe-extern-fn.rs:12:19`
`29`	`29`	`\|`
@@ -34,12 +34,12 @@ error[E0277]: expected a `FnOnce<(&isize,)>` closure, found `for<'r> unsafe fn(&
`34`	`34`	`--> $DIR/unboxed-closures-unsafe-extern-fn.rs:30:26`
`35`	`35`	`\|`
`36`	`36`	`LL \| let z = call_it_once(square, 22);`
`37`		- \| ------------ ^^^^^^ expected an `FnOnce<(&isize,)>` closure, found `for<'r> unsafe fn(&'r isize) -> isize {square}`
	`37`	+ \| ------------ ^^^^^^ call the function in a closure: `\|\| unsafe { /* code */ }`
`38`	`38`	`\| \|`
`39`	`39`	`\| required by a bound introduced by this call`
`40`	`40`	`\|`
`41`	`41`	= help: the trait `for<'r> FnOnce<(&'r isize,)>` is not implemented for `for<'r> unsafe fn(&'r isize) -> isize {square}`
`42`		- = note: unsafe functions must be wrapped in closures: `\|\| unsafe { /* code */ }`
	`42`	`+ = note: unsafe function cannot be called generically without an unsafe block`
`43`	`43`	note: required by a bound in `call_it_once`
`44`	`44`	`--> $DIR/unboxed-closures-unsafe-extern-fn.rs:15:20`
`45`	`45`	`\|`
Original file line number	Diff line number	Diff line change
@@ -2,12 +2,12 @@ error[E0277]: expected a `Fn<(&isize,)>` closure, found `unsafe fn(isize) -> isi
`2`	`2`	`--> $DIR/unboxed-closures-wrong-arg-type-extern-fn.rs:21:21`
`3`	`3`	`\|`
`4`	`4`	`LL \| let x = call_it(&square, 22);`
`5`		- \| ------- ^^^^^^^ expected an `Fn<(&isize,)>` closure, found `unsafe fn(isize) -> isize {square}`
	`5`	+ \| ------- ^^^^^^^ call the function in a closure: `\|\| unsafe { /* code */ }`
`6`	`6`	`\| \|`
`7`	`7`	`\| required by a bound introduced by this call`
`8`	`8`	`\|`
`9`	`9`	= help: the trait `for<'r> Fn<(&'r isize,)>` is not implemented for `unsafe fn(isize) -> isize {square}`
`10`		- = note: unsafe functions must be wrapped in closures: `\|\| unsafe { /* code */ }`
	`10`	`+ = note: unsafe function cannot be called generically without an unsafe block`
`11`	`11`	note: required by a bound in `call_it`
`12`	`12`	`--> $DIR/unboxed-closures-wrong-arg-type-extern-fn.rs:10:15`
`13`	`13`	`\|`
@@ -18,12 +18,12 @@ error[E0277]: expected a `FnMut<(&isize,)>` closure, found `unsafe fn(isize) ->
`18`	`18`	`--> $DIR/unboxed-closures-wrong-arg-type-extern-fn.rs:26:25`
`19`	`19`	`\|`
`20`	`20`	`LL \| let y = call_it_mut(&mut square, 22);`
`21`		- \| ----------- ^^^^^^^^^^^ expected an `FnMut<(&isize,)>` closure, found `unsafe fn(isize) -> isize {square}`
	`21`	+ \| ----------- ^^^^^^^^^^^ call the function in a closure: `\|\| unsafe { /* code */ }`
`22`	`22`	`\| \|`
`23`	`23`	`\| required by a bound introduced by this call`
`24`	`24`	`\|`
`25`	`25`	= help: the trait `for<'r> FnMut<(&'r isize,)>` is not implemented for `unsafe fn(isize) -> isize {square}`
`26`		- = note: unsafe functions must be wrapped in closures: `\|\| unsafe { /* code */ }`
	`26`	`+ = note: unsafe function cannot be called generically without an unsafe block`
`27`	`27`	note: required by a bound in `call_it_mut`
`28`	`28`	`--> $DIR/unboxed-closures-wrong-arg-type-extern-fn.rs:13:19`
`29`	`29`	`\|`
@@ -34,12 +34,12 @@ error[E0277]: expected a `FnOnce<(&isize,)>` closure, found `unsafe fn(isize) ->
`34`	`34`	`--> $DIR/unboxed-closures-wrong-arg-type-extern-fn.rs:31:26`
`35`	`35`	`\|`
`36`	`36`	`LL \| let z = call_it_once(square, 22);`
`37`		- \| ------------ ^^^^^^ expected an `FnOnce<(&isize,)>` closure, found `unsafe fn(isize) -> isize {square}`
	`37`	+ \| ------------ ^^^^^^ call the function in a closure: `\|\| unsafe { /* code */ }`
`38`	`38`	`\| \|`
`39`	`39`	`\| required by a bound introduced by this call`
`40`	`40`	`\|`
`41`	`41`	= help: the trait `for<'r> FnOnce<(&'r isize,)>` is not implemented for `unsafe fn(isize) -> isize {square}`
`42`		- = note: unsafe functions must be wrapped in closures: `\|\| unsafe { /* code */ }`
	`42`	`+ = note: unsafe function cannot be called generically without an unsafe block`
`43`	`43`	note: required by a bound in `call_it_once`
`44`	`44`	`--> $DIR/unboxed-closures-wrong-arg-type-extern-fn.rs:16:20`
`45`	`45`	`\|`