feat: Allow custom adapter registration

This PR implements a solution to the issue discussed in thephpleague#181, enabling external bundles to register their custom storage adapters with Flysystem Bundle without requiring them to be directly added to the main bundle's codebase.

I had to remove the  `@internal` annotation from `AdapterDefinitionBuilderInterface` and `AbstractAdapterDefinitionBuilder` to allow them to be referenced by other bundles.

External bundles can now register their adapters as follows:
``` php
class AzureBlobStorageAdapterBundle extends Bundle
{
    /**
     * {@inheritdoc}
     */
    public function build(ContainerBuilder $container): void
    {
        parent::build($container);

        /** @var FlysystemExtension $extension */
        $extension = $container->getExtension('flysystem');
        $extension->addAdapterDefinitionBuilder(new AzureOssAdapterDefinitionBuilder());
    }
}
```

Author: maxhelias

src/Adapter/AdapterDefinitionFactory.php

@@ -27,9 +27,12 @@ final class AdapterDefinitionFactory
      */
     private array $builders;
 
-    public function __construct()
+    /**
+     * @param list<AdapterDefinitionBuilderInterface> $builders
+     */
+    public function __construct(array $builders)
     {
-        $this->builders = [
+        $this->builders = array_merge([
             new Builder\AsyncAwsAdapterDefinitionBuilder(),
             new Builder\AwsAdapterDefinitionBuilder(),
             new Builder\AzureAdapterDefinitionBuilder(),
@@ -41,7 +44,7 @@ public function __construct()
             new Builder\SftpAdapterDefinitionBuilder(),
             new Builder\WebDAVAdapterDefinitionBuilder(),
             new Builder\BunnyCDNAdapterDefinitionBuilder(),
-        ];
+        ], $builders);
     }
 
     public function createDefinition(string $name, array $options, ?string $defaultVisibilityForDirectories = null): ?Definition

src/Adapter/Builder/AbstractAdapterDefinitionBuilder.php

@@ -16,8 +16,6 @@
 
 /**
  * @author Titouan Galopin <galopintitouan@gmail.com>
- *
- * @internal
  */
 abstract class AbstractAdapterDefinitionBuilder implements AdapterDefinitionBuilderInterface
 {

src/Adapter/Builder/AdapterDefinitionBuilderInterface.php

@@ -15,8 +15,6 @@
 
 /**
  * @author Titouan Galopin <galopintitouan@gmail.com>
- *
- * @internal
  */
 interface AdapterDefinitionBuilderInterface
 {

src/DependencyInjection/FlysystemExtension.php

@@ -17,6 +17,7 @@
 use League\Flysystem\FilesystemWriter;
 use League\Flysystem\ReadOnly\ReadOnlyFilesystemAdapter;
 use League\FlysystemBundle\Adapter\AdapterDefinitionFactory;
+use League\FlysystemBundle\Adapter\Builder\AdapterDefinitionBuilderInterface;
 use League\FlysystemBundle\Command\PullCommand;
 use League\FlysystemBundle\Command\PushCommand;
 use League\FlysystemBundle\Exception\MissingPackageException;
@@ -35,6 +36,9 @@
  */
 final class FlysystemExtension extends Extension
 {
+    /** @var list<AdapterDefinitionBuilderInterface> */
+    private array $adapterDefinitionBuilders = [];
+
     public function load(array $configs, ContainerBuilder $container): void
     {
         $configuration = new Configuration();
@@ -53,6 +57,11 @@ public function load(array $configs, ContainerBuilder $container): void
         $this->createStoragesDefinitions($config, $container);
     }
 
+    public function addAdapterDefinitionBuilder(AdapterDefinitionBuilderInterface $builder): void
+    {
+        $this->adapterDefinitionBuilders[] = $builder;
+    }
+
     private function registerPushCommand(ContainerBuilder $container): void
     {
         $container
@@ -75,7 +84,7 @@ private function registerPullCommand(ContainerBuilder $container): void
 
     private function createStoragesDefinitions(array $config, ContainerBuilder $container): void
     {
-        $definitionFactory = new AdapterDefinitionFactory();
+        $definitionFactory = new AdapterDefinitionFactory($this->adapterDefinitionBuilders);
 
         foreach ($config['storages'] as $storageName => $storageConfig) {
             // If the storage is a lazy one, it's resolved at runtime

tests/Adapter/AdapterDefinitionFactoryTest.php

@@ -117,7 +117,7 @@ public static function provideConfigOptions(): \Generator
      */
     public static function testCreateDefinition($name, $options): void
     {
-        $factory = new AdapterDefinitionFactory();
+        $factory = new AdapterDefinitionFactory([]);
 
         $definition = $factory->createDefinition($name, $options);
         self::assertInstanceOf(Definition::class, $definition);