Skip to content

Commit 02ded0a

Browse files
committed
Merge branch 'refactor/typescript-cards' of github.com:medyo/hackertab.dev into refactor/typescript-cards
2 parents 94c96a4 + c4af437 commit 02ded0a

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

src/features/conferencesCard/components/ConferenceItem.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,19 +56,19 @@ const ConferencesItem = (props: ConferenceItemPropsType) => {
5656
source={'conferences'}
5757
index={index}
5858
key={index}
59-
item={{ ...item, title: item.name }}
59+
item={item}
6060
cardItem={
6161
<>
6262
<CardLink
6363
link={item.url}
6464
analyticsAttributes={{
6565
[Attributes.TRIGERED_FROM]: 'card',
66-
[Attributes.TITLE]: item.name,
66+
[Attributes.TITLE]: item.title,
6767
[Attributes.LINK]: item.url,
6868
[Attributes.SOURCE]: 'conferences',
6969
}}>
7070
<RiCalendarEventFill className={'rowTitleIcon'} />
71-
{item.name}
71+
{item.title}
7272
</CardLink>
7373
{listingMode === 'normal' ? (
7474
<>

src/types/index.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,10 @@ export type ListingMode = "normal" | "compact";
3636
export type BaseEntry = {
3737
id: string
3838
url: string
39+
title: string
3940
}
4041

4142
export type Article = BaseEntry & {
42-
title: string
4343
published_at: number
4444
tags: Array<string>
4545
reactions: number
@@ -56,7 +56,6 @@ export type Article = BaseEntry & {
5656
}
5757

5858
export type Repository = BaseEntry & {
59-
title: string
6059
programmingLanguage: string
6160
stars: number
6261
source: string
@@ -68,7 +67,6 @@ export type Repository = BaseEntry & {
6867
}
6968

7069
export type Conference = BaseEntry & {
71-
name: string
7270
start_date: number
7371
end_date: number
7472
tag: string

0 commit comments

Comments
 (0)