fix unbook event + fix imports

Chouikane · Chouikane · commit 09df2672080e · 2022-10-20T19:14:11.000+01:00
diff --git a/src/bookmark/BookmarksSidebar.js b/src/bookmark/BookmarksSidebar.js
@@ -12,9 +12,15 @@ import { trackLinkUnBookmark, Attributes } from 'src/lib/analytics'
 
 const BookmarkItem = ({ item, appendRef = true }) => {
   const { dispatcher } = useContext(PreferencesContext)
+  const analyticsAttrs = {
+    [Attributes.TRIGERED_FROM]: 'bookmarks',
+    [Attributes.TITLE]: item.title,
+    [Attributes.LINK]: item.url,
+    [Attributes.SOURCE]: item.source,
+  } 
   const unBookmark = () => {
     dispatcher({ type: 'unBookmarkItem', value: item })
-    trackLinkUnBookmark(item.source)
+    trackLinkUnBookmark(analyticsAttrs)
   }
   return (
     <MenuItem
@@ -26,12 +32,10 @@ const BookmarkItem = ({ item, appendRef = true }) => {
       <CardLink
         link={item.url}
         appendRef={appendRef}
-        analyticsAttributes={{
-          [Attributes.TRIGERED_FROM]: 'bookmarks',
-          [Attributes.TITLE]: item.title,
-          [Attributes.LINK]: item.url,
-          [Attributes.SOURCE]: item.source,
-        }}>{`${item.title}`}</CardLink>
+        analyticsAttributes={analyticsAttrs}
+        >
+          {`${item.title}`}
+        </CardLink>
     </MenuItem>
   )
 }
diff --git a/src/cards/DevToCard.js b/src/cards/DevToCard.js
@@ -11,7 +11,7 @@ import { AiOutlineLike } from 'react-icons/ai'
 import CardItemWithActions from '../components/CardItemWithActions'
 import ColoredLanguagesBadge from '../components/ColoredLanguagesBadge'
 import SelectableCard from '../components/SelectableCard'
-import { GLOBAL_TAG, MY_LANGUAGES_TAG, MAX_MERGED_ITEMS_PER_LANGUAGE } from '../constants'
+import { GLOBAL_TAG, MY_LANGUAGES_TAG, MAX_MERGED_ITEMS_PER_LANGUAGE } from '../Constants'
 import { mergeMultipleDataSources } from '../utils/DataUtils'
 import { trackCardLanguageSelect } from 'src/lib/analytics'
 import { Attributes } from 'src/lib/analytics'
diff --git a/src/cards/HashNodeCard.js b/src/cards/HashNodeCard.js
@@ -11,7 +11,7 @@ import { AiTwotoneHeart } from 'react-icons/ai'
 import CardItemWithActions from '../components/CardItemWithActions'
 import ColoredLanguagesBadge from '../components/ColoredLanguagesBadge'
 import SelectableCard from '../components/SelectableCard'
-import { GLOBAL_TAG, MY_LANGUAGES_TAG, MAX_MERGED_ITEMS_PER_LANGUAGE } from '../constants'
+import { GLOBAL_TAG, MY_LANGUAGES_TAG, MAX_MERGED_ITEMS_PER_LANGUAGE } from '../Constants'
 import { mergeMultipleDataSources } from '../utils/DataUtils'
 import { trackCardLanguageSelect, Attributes } from 'src/lib/analytics'
 
diff --git a/src/cards/MediumCard.js b/src/cards/MediumCard.js
@@ -10,7 +10,7 @@ import { MdAccessTime } from 'react-icons/md'
 import { MdWavingHand } from 'react-icons/md'
 import CardItemWithActions from '../components/CardItemWithActions'
 import SelectableCard from '../components/SelectableCard'
-import { GLOBAL_TAG, MY_LANGUAGES_TAG, MAX_MERGED_ITEMS_PER_LANGUAGE } from '../constants'
+import { GLOBAL_TAG, MY_LANGUAGES_TAG, MAX_MERGED_ITEMS_PER_LANGUAGE } from '../Constants'
 import { mergeMultipleDataSources } from '../utils/DataUtils'
 import { trackCardLanguageSelect } from 'src/lib/analytics'
 import { Attributes } from 'src/lib/analytics'
diff --git a/src/cards/ReposCard.js b/src/cards/ReposCard.js
@@ -7,7 +7,7 @@ import PreferencesContext from '../preferences/PreferencesContext'
 import CardLink from '../components/CardLink'
 import CardItemWithActions from '../components/CardItemWithActions'
 import SelectableCard from '../components/SelectableCard'
-import { GLOBAL_TAG, MY_LANGUAGES_TAG, MAX_MERGED_ITEMS_PER_LANGUAGE } from '../constants'
+import { GLOBAL_TAG, MY_LANGUAGES_TAG, MAX_MERGED_ITEMS_PER_LANGUAGE } from '../Constants'
 import { mergeMultipleDataSources } from '../utils/DataUtils'
 import ColoredLanguagesBadge from '../components/ColoredLanguagesBadge'
 import { trackCardLanguageSelect, trackCardDateRangeSelect, Attributes } from 'src/lib/analytics'
diff --git a/src/components/AppContentLayout.js b/src/components/AppContentLayout.js
@@ -1,5 +1,5 @@
 import React, { useContext, useState } from 'react'
-import { SUPPORTED_CARDS } from '../constants'
+import { SUPPORTED_CARDS } from '../Constants'
 import PreferencesContext from '../preferences/PreferencesContext'
 import BottomNavigation from './BottomNavigation'
 import { isDesktop } from 'react-device-detect'
diff --git a/src/components/BottomNavigation.js b/src/components/BottomNavigation.js
@@ -1,5 +1,5 @@
 import React, { useContext } from 'react'
-import { SUPPORTED_CARDS } from '../constants'
+import { SUPPORTED_CARDS } from '../Constants'
 import PreferencesContext from '../preferences/PreferencesContext'
 import { AiOutlineMenu } from 'react-icons/ai'
 
diff --git a/src/components/CardComponent.js b/src/components/CardComponent.js
@@ -1,6 +1,6 @@
 import React, { useContext } from 'react';
 import { BsBoxArrowInUpRight } from 'react-icons/bs';
-import { APP } from '../constants'
+import { APP } from '../Constants'
 import PreferencesContext from '../preferences/PreferencesContext'
 
 function CardComponent({ icon, title, children, fullBlock, link }) {
diff --git a/src/components/CardItemWithActions.js b/src/components/CardItemWithActions.js
@@ -19,21 +19,16 @@ export default function CardItemWithActions({ cardItem, item, index, source }) {
       },
     })
     setIsBookmarked(!isBookmarked)
-
+    const analyticsAttrs = {
+      [Attributes.TRIGERED_FROM]: 'card',
+      [Attributes.TITLE]: item.title,
+      [Attributes.LINK]: item.url,
+      [Attributes.SOURCE]: source,
+    } 
     if (isBookmarked) {
-      trackLinkUnBookmark({
-        [Attributes.TRIGERED_FROM]: 'bookmarks',
-        [Attributes.TITLE]: item.title,
-        [Attributes.LINK]: item.url,
-        [Attributes.SOURCE]: source,
-      })
+      trackLinkUnBookmark(analyticsAttrs)
     } else {
-      trackLinkBookmark({
-        [Attributes.TRIGERED_FROM]: 'bookmarks',
-        [Attributes.TITLE]: item.title,
-        [Attributes.LINK]: item.url,
-        [Attributes.SOURCE]: source,
-      })
+      trackLinkBookmark(analyticsAttrs)
     }
   }
   useEffect(() => {
diff --git a/src/components/Changelog.js b/src/components/Changelog.js
@@ -5,7 +5,7 @@ import ReactMarkdown from 'react-markdown'
 import axios from 'axios'
 import { format } from 'timeago.js'
 import BeatLoader from 'react-spinners/BeatLoader'
-import { APP } from '../constants'
+import { APP } from '../Constants'
 import PreferencesContext from '../preferences/PreferencesContext'
 
 function Changelog({}) {
diff --git a/src/components/ClickableItem.js b/src/components/ClickableItem.js
@@ -1,6 +1,6 @@
 import { trackLinkOpen } from 'src/lib/analytics'
 import React, { useContext } from 'react'
-import { APP } from '../constants'
+import { APP } from '../Constants'
 import PreferencesContext from '../preferences/PreferencesContext'
 
 const ClickableItem = ({ link, className, children, analyticsAttributes, appendRef = true }) => {
diff --git a/src/components/Footer.js b/src/components/Footer.js
@@ -1,5 +1,5 @@
 import React from 'react'
-import { APP } from '../constants'
+import { APP } from '../Constants'
 import { RiCodeSSlashFill } from 'react-icons/ri'
 import { HiLightBulb } from 'react-icons/hi'
 import { trackPageView } from 'src/lib/analytics'
diff --git a/src/components/Header.js b/src/components/Header.js
@@ -4,7 +4,7 @@ import { CgTab } from 'react-icons/cg';
 import { BsFillBookmarksFill } from "react-icons/bs"
 import { ReactComponent as HackertabLogo } from '../logo.svg';
 import UserTags from "./UserTags";
-import { SUPPORTED_SEARCH_ENGINES } from '../constants'
+import { SUPPORTED_SEARCH_ENGINES } from '../Constants'
 import SettingsModal from '../settings/SettingsModal'
 import { BsMoon } from 'react-icons/bs'
 import { IoMdSunny } from 'react-icons/io'
diff --git a/src/components/ScrollCardsNavigator.js b/src/components/ScrollCardsNavigator.js
@@ -1,6 +1,6 @@
 import React, { useState, useEffect, useContext, useLayoutEffect, useRef } from 'react'
 import { FiChevronLeft, FiChevronRight } from 'react-icons/fi'
-import { APP } from '../constants'
+import { APP } from '../Constants'
 import PreferencesContext from '../preferences/PreferencesContext'
 import { trackPageScroll } from 'src/lib/analytics'
 
diff --git a/src/components/SelectableCard.js b/src/components/SelectableCard.js
@@ -1,6 +1,6 @@
 import React, { useContext, useLayoutEffect } from 'react'
 import DropDownMenu from './DropDownMenu'
-import { GLOBAL_TAG, MY_LANGUAGES_TAG } from '../constants'
+import { GLOBAL_TAG, MY_LANGUAGES_TAG } from '../Constants'
 import PreferencesContext from '../preferences/PreferencesContext'
 
 function SelectableCard({
diff --git a/src/configuration/AppWrapper.js b/src/configuration/AppWrapper.js
@@ -1,5 +1,5 @@
 import React, { useReducer, useContext } from 'react'
-import { LS_PREFERENCES_KEY } from '../constants'
+import { LS_PREFERENCES_KEY } from 'src/Constants'
 import AppStorage from '../services/localStorage'
 import { PreferencesProvider } from '../preferences/PreferencesContext'
 import { getOSMode } from '../services/os'
diff --git a/src/lib/analytics.ts b/src/lib/analytics.ts
@@ -1,7 +1,7 @@
 import AppStorage from '../services/localStorage';
 import { init, track, identify, Identify } from '@amplitude/analytics-browser'
 import { isDevelopment } from 'src/utils/Environment';
-import { ANALYTICS_SDK_KEY, ANALYTICS_ENDPOINT, LS_ANALYTICS_ID_KEY } from 'src/constants'
+import { ANALYTICS_SDK_KEY, ANALYTICS_ENDPOINT, LS_ANALYTICS_ID_KEY } from 'src/Constants'
 
 enum Objects {
   PAGE = 'Page',
diff --git a/src/preferences/AppReducer.js b/src/preferences/AppReducer.js
@@ -1,5 +1,5 @@
 
-import { LS_PREFERENCES_KEY } from '../constants'
+import { LS_PREFERENCES_KEY } from '../Constants'
 import AppStorage from '../services/localStorage'
 import {
   trackThemeSelect,
diff --git a/src/settings/SettingsModal.js b/src/settings/SettingsModal.js
@@ -8,7 +8,7 @@ import '../App.css';
 import './settings.css';
 import PreferencesContext from '../preferences/PreferencesContext';
 import ConfigurationContext from '../configuration/ConfigurationContext';
-import { SUPPORTED_CARDS, SUPPORTED_SEARCH_ENGINES, APP } from '../constants'
+import { SUPPORTED_CARDS, SUPPORTED_SEARCH_ENGINES, APP } from '../Constants'
 import {
   trackLanguageAdd,
   trackLanguageRemove,
diff --git a/yarn.lock b/yarn.lock
@@ -3962,7 +3962,7 @@ console-browserify@^1.1.0:
 
 constants-browserify@^1.0.0:
   version "1.0.0"
-  resolved "https://registry.yarnpkg.com/constants-browserify/-/constants-browserify-1.0.0.tgz#c20b96d8c617748aaf1c16021760cd27fcb8cb75"
+  resolved "https://registry.yarnpkg.com/Constants-browserify/-/Constants-browserify-1.0.0.tgz#c20b96d8c617748aaf1c16021760cd27fcb8cb75"
   integrity sha512-xFxOwqIzR/e1k1gLiWEophSCMqXcwVHIH7akf7b/vxcUeGunlj3hvZaaqxwHsTgn+IndtkQJgSztIDWeumWJDQ==
 
 content-disposition@0.5.4:
