Skip to content

Commit 0bc199d

Browse files
committed
refactor: add loading attribute to images in ArticleItem and FeedItemImage components
1 parent d3c9588 commit 0bc199d

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

src/features/cards/components/producthuntCard/ArticleItem.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,16 @@ import { Attributes } from 'src/lib/analytics'
55
import { useUserPreferences } from 'src/stores/preferences'
66
import { Article, BaseItemPropsType } from 'src/types'
77

8-
const ArticleItem = ({ item, index, analyticsTag }: BaseItemPropsType<Article>) => {
8+
const ArticleItem = ({ item, analyticsTag }: BaseItemPropsType<Article>) => {
99
const { listingMode } = useUserPreferences()
1010

1111
return (
1212
<CardItemWithActions
1313
source={analyticsTag}
14-
index={index}
15-
key={index}
1614
item={{ ...item, title: item.title }}
1715
cardItem={
1816
<div className="phItem">
19-
<img className="phImage" src={item.image_url} alt={item.title} />
17+
<img className="phImage" loading="lazy" src={item.image_url} alt={item.title} />
2018
<div className="phContent">
2119
<CardLink
2220
link={item.url}

src/features/feed/components/FeedItemImage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export const FeedItemImage = ({ imageUrl, fallbackImage }: FeedItemImageProps) =
1111

1212
if (hasError || !imageUrl) {
1313
if (typeof fallbackImage === 'string') {
14-
return <img src={fallbackImage} className="rowCover" alt="" />
14+
return <img src={fallbackImage} loading="lazy" className="rowCover" alt="" />
1515
} else {
1616
return (
1717
fallbackImage || (

0 commit comments

Comments
 (0)