Skip to content

Commit 0fa3a3a

Browse files
committed
fix a react warning (can't have div inside p)
1 parent 12782ed commit 0fa3a3a

1 file changed

Lines changed: 15 additions & 23 deletions

File tree

src/cards/HNCard.js

Lines changed: 15 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -20,52 +20,44 @@ const StoryItem = ({ item, index, analyticsTag }) => {
2020

2121
return (
2222
<CardItemWithActions
23-
source={"hackernews"}
23+
source={'hackernews'}
2424
index={index}
2525
item={item}
2626
key={index}
2727
cardItem={
2828
<>
2929
<p className="rowTitle">
3030
<CardLink link={item.url} analyticsSource={analyticsTag}>
31-
{ listingMode === "compact" &&
32-
<div className="counterWrapper">
33-
<VscTriangleUp/>
34-
<span className="value">{item.score}</span>
35-
</div>
36-
}
37-
38-
<div className="subTitle">
39-
{item.title}
40-
</div>
31+
{listingMode === 'compact' && (
32+
<span className="counterWrapper">
33+
<VscTriangleUp />
34+
<span className="value">{item.score}</span>
35+
</span>
36+
)}
37+
38+
<span className="subTitle">{item.title}</span>
4139
</CardLink>
4240
</p>
43-
{listingMode === "normal" && (
41+
{listingMode === 'normal' && (
4442
<div className="rowDetails">
4543
<span className="rowItem hnRowItem">
4644
<GoPrimitiveDot className="rowItemIcon" /> {item.score} points
4745
</span>
48-
<span
49-
className="rowItem"
50-
title={new Date(item.time * 1000).toUTCString()}
51-
>
52-
<MdAccessTime className="rowItemIcon" />{" "}
53-
{format(new Date(item.time * 1000))}
46+
<span className="rowItem" title={new Date(item.time * 1000).toUTCString()}>
47+
<MdAccessTime className="rowItemIcon" /> {format(new Date(item.time * 1000))}
5448
</span>
5549
<ClickableItem
5650
link={`https://news.ycombinator.com/item?id=${item.id}`}
5751
className="rowItem rowItemClickable"
58-
analyticsSource={analyticsTag}
59-
>
60-
<BiCommentDetail className="rowItemIcon" /> {item.descendants}{" "}
61-
comments
52+
analyticsSource={analyticsTag}>
53+
<BiCommentDetail className="rowItemIcon" /> {item.descendants} comments
6254
</ClickableItem>
6355
</div>
6456
)}
6557
</>
6658
}
6759
/>
68-
);
60+
)
6961
}
7062

7163

0 commit comments

Comments
 (0)