Skip to content

Commit 13e28f4

Browse files
authored
Merge pull request #61 from medyo/develop
skip setting etag on web version (cors issue)
2 parents ceb1ffb + 57a5427 commit 13e28f4

1 file changed

Lines changed: 17 additions & 16 deletions

File tree

src/services/cachedRequest.js

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -6,35 +6,36 @@ var packageFile = require("../../package.json");
66
const axiosInstance = axios.create({
77
baseURL: process.env.NODE_ENV === "production" ? packageFile.proxy : null,
88
});
9+
const isWebVersion = !!+process.env.REACT_APP_WEB_BUILD
910

1011
const cachedRequest = async (url) => {
11-
const cachedResponse = await AppStorage.getItem(url);
12-
let headers = {};
13-
let response;
14-
if (cachedResponse) {
15-
let etag = JSON.parse(cachedResponse).headers.etag;
12+
const cachedResponse = await AppStorage.getItem(url)
13+
let headers = {}
14+
let response
15+
if (!isWebVersion && cachedResponse) {
16+
let etag = JSON.parse(cachedResponse).headers.etag
1617
headers = {
17-
"If-None-Match": etag,
18-
};
18+
'If-None-Match': etag,
19+
}
1920
}
2021

2122
try {
22-
response = await axiosInstance.get(url, { headers });
23+
response = await axiosInstance.get(url, { headers })
2324
if (response.headers.etag) {
24-
AppStorage.setItem(url, response);
25+
AppStorage.setItem(url, response)
2526
}
2627
} catch (error) {
2728
if (!error.response || error.response.status !== 304) {
28-
throw error;
29+
throw error
2930
}
3031
if (!cachedResponse) {
31-
throw "Network Failed";
32+
throw 'Network Failed'
3233
}
33-
response = error.response;
34-
response.status = 200;
35-
response.data = JSON.parse(cachedResponse).data;
34+
response = error.response
35+
response.status = 200
36+
response.data = JSON.parse(cachedResponse).data
3637
}
37-
return response.data;
38-
};
38+
return response.data
39+
}
3940

4041
export default cachedRequest

0 commit comments

Comments
 (0)