refactor: simplify loading state handling in ListComponent

medyo · medyo · commit 166ca1b46970 · 2025-11-16T19:34:28.000+01:00
diff --git a/src/components/List/ListComponent.tsx b/src/components/List/ListComponent.tsx
@@ -78,6 +78,9 @@ export function ListComponent<T extends any>(props: ListComponentPropsType<T>) {
     }
   }, [sortedData, header, renderItem, limit])
 
+  if (isLoading) {
+    return <Placeholders placeholder={placeholder} />
+  }
   if (error) {
     return <p className="errorMsg">{error?.message || error}</p>
   }
@@ -90,5 +93,5 @@ export function ListComponent<T extends any>(props: ListComponentPropsType<T>) {
     )
   }
 
-  return <>{isLoading ? <Placeholders placeholder={placeholder} /> : enrichedItems}</>
+  return <>{enrichedItems}</>
 }

Original file line number	Diff line number	Diff line change
`@@ -78,6 +78,9 @@ export function ListComponent<T extends any>(props: ListComponentPropsType<T>) {`
`78`	`78`	`}`
`79`	`79`	`}, [sortedData, header, renderItem, limit])`
`80`	`80`
	`81`	`+ if (isLoading) {`
	`82`	`+ return <Placeholders placeholder={placeholder} />`
	`83`	`+ }`
`81`	`84`	`if (error) {`
`82`	`85`	`return <p className="errorMsg">{error?.message \|\| error}</p>`
`83`	`86`	`}`
`@@ -90,5 +93,5 @@ export function ListComponent<T extends any>(props: ListComponentPropsType<T>) {`
`90`	`93`	`)`
`91`	`94`	`}`
`92`	`95`
`93`		`- return <>{isLoading ? <Placeholders placeholder={placeholder} /> : enrichedItems}</>`
	`96`	`+ return <>{enrichedItems}</>`
`94`	`97`	`}`