Skip to content

Commit 1680297

Browse files
committed
refactor: simplify cardSettings destructuring in GithubCard component
1 parent 2b8251f commit 1680297

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

src/features/cards/components/githubCard/GithubCard.tsx

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,11 @@ export function GithubCard(props: CardPropsType) {
1919

2020
const { ref, isVisible } = useLazyListLoad()
2121
const setCardSettings = useUserPreferences((state) => state.setCardSettings)
22-
const {
23-
queryTags,
24-
selectedTag,
25-
cardSettings: { dateRange, sortBy, language } = {},
26-
} = useSelectedTags({
22+
const { queryTags, selectedTag, cardSettings } = useSelectedTags({
2723
source: meta.value,
2824
fallbackTag: GLOBAL_TAG,
2925
})
26+
const { dateRange, language, sortBy } = cardSettings
3027

3128
const selectedDateRange = useMemo(
3229
() => dateRanges.find((date) => date.value === dateRange) || dateRanges[0],
@@ -82,7 +79,7 @@ export function GithubCard(props: CardPropsType) {
8279
value={date.value}
8380
disabled={selectedDateRange.value === date.value}
8481
onClick={() => {
85-
setCardSettings(meta.value, { dateRange: date.value, language, sortBy })
82+
setCardSettings(meta.value, { ...cardSettings, dateRange: date.value })
8683
}}>
8784
{date.label}
8885
</MenuItem>

0 commit comments

Comments
 (0)