Skip to content

Commit 17f02de

Browse files
committed
fix github issues
1 parent 73bb80a commit 17f02de

2 files changed

Lines changed: 5 additions & 11 deletions

File tree

src/features/githubCard/components/ArticleItem.tsx

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import { useMemo } from 'react'
21
import CardLink from 'src/components/CardLink'
32
import CardItemWithActions from 'src/components/CardItemWithActions'
43
import { Attributes } from 'src/lib/analytics'
@@ -11,10 +10,6 @@ const sourceName = 'github'
1110
const ArticleItem = (props: ArticleItemPropsType) => {
1211
const { item, index, listingMode, selectedTag } = props
1312

14-
const title = useMemo(() => {
15-
return `${item.owner ? item.owner + '/' : ''}${item.title}`
16-
}, [item])
17-
1813
return (
1914
<CardItemWithActions
2015
source={sourceName}
@@ -35,8 +30,7 @@ const ArticleItem = (props: ArticleItemPropsType) => {
3530
[Attributes.LANGUAGE]: selectedTag?.value,
3631
}}>
3732
<VscRepo className={'rowTitleIcon'} />
38-
{item.owner && `${item?.owner}/`}
39-
<b>{item.name}</b>
33+
{item.title}
4034
</CardLink>
4135
<p className="rowDescription">{item.description}</p>
4236
{listingMode === 'normal' && (

src/features/githubCard/components/GithubCard.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,13 @@ export function GithubCard(props: CardPropsType) {
3434
if (selectedTag) {
3535
setCardSettings(label.toLowerCase(), { language: selectedTag.label })
3636
}
37-
}, [selectedTag])
37+
}, [label, selectedTag, setCardSettings])
3838

3939
useEffect(() => {
4040
if (selectedDateRange) {
4141
setCardSettings(label.toLowerCase(), { language: selectedDateRange.value })
4242
}
43-
}, [selectedDateRange])
43+
}, [label, selectedDateRange, setCardSettings])
4444

4545
const getQueryTags = () => {
4646
if (!selectedTag) {
@@ -95,7 +95,7 @@ export function GithubCard(props: CardPropsType) {
9595
setSelectedTag={setSelectedTag}
9696
fallbackTag={GLOBAL_TAG}
9797
cardSettings={cardsSettings?.repos?.language}
98-
trackEvent={(tag: Tag) => trackCardLanguageSelect('Repos', tag.value)}
98+
trackEvent={(tag: Tag) => trackCardLanguageSelect('Github', tag.value)}
9999
data={userSelectedTags.map((tag) => ({
100100
label: tag.label,
101101
value: tag.value,
@@ -107,7 +107,7 @@ export function GithubCard(props: CardPropsType) {
107107
selectedTag={selectedDateRange}
108108
setSelectedTag={setSelectedDateRange}
109109
fallbackTag={dateRanges[0]}
110-
trackEvent={(tag: DateRangeType) => trackCardDateRangeSelect('Repos', tag.value)}
110+
trackEvent={(tag: DateRangeType) => trackCardDateRangeSelect('Github', tag.value)}
111111
cardSettings={cardsSettings?.repos?.dateRange}
112112
data={dateRanges}
113113
/>

0 commit comments

Comments
 (0)