Skip to content

Commit 1aa51d4

Browse files
committed
fix other minor warnings
1 parent 83257ad commit 1aa51d4

4 files changed

Lines changed: 10 additions & 6 deletions

File tree

src/components/BottomNavigation.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,19 @@ function BottomNavigation({ selectedCard, setSelectedCard, setShowSettings }) {
1414
<a
1515
key={card.name}
1616
className={
17-
'navigationItem ' + (selectedCard && selectedCard.name == card.name ? 'active' : '')
17+
'navigationItem ' + (selectedCard && selectedCard.name === card.name ? 'active' : '')
1818
}
19-
href="#"
19+
href="/#"
2020
onClick={(e) => setSelectedCard(card)}>
2121
{constantCard.icon}
2222
</a>
2323
)
2424
})}
2525
{
26-
<a className={'navigationItem '} href="#" onClick={(e) => setShowSettings((prev) => !prev)}>
26+
<a
27+
className={'navigationItem '}
28+
href="/#"
29+
onClick={(e) => setShowSettings((prev) => !prev)}>
2730
{<AiOutlineMenu />}
2831
</a>
2932
}

src/components/CardItemWithActions.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export default function CardItemWithActions({ cardItem, item, index, source }) {
3535
}
3636
useEffect(() => {
3737
setIsBookmarked(userBookmarks.some((bm) => bm.source === source && bm.url === item.url))
38-
}, [userBookmarks])
38+
}, [userBookmarks, source, item])
3939

4040
return (
4141
<div key={`${source}-${index}`} className="blockRow">

src/features/changelog/components/Changelog.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ export const Changelog = () => {
6363
<div key={item.name}>
6464
<div className="tooltipHeader">
6565
<a
66+
href="/#"
6667
className="tooltipVersion"
6768
onClick={() => window.open(item.html_url, '_blank')}>
6869
{item.name}

src/features/settings/components/SettingsModal.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ export const SettingsModal = ({ showSettings, setShowSettings }: SettingsModalPr
157157
/>
158158
<p className="settingHint">
159159
Missing language or technology? create an issue{' '}
160-
<a href="#" onClick={(e) => window.open(supportLink, '_blank')}>
160+
<a href={supportLink} target="_blank" rel="noreferrer">
161161
here
162162
</a>
163163
</p>
@@ -181,7 +181,7 @@ export const SettingsModal = ({ showSettings, setShowSettings }: SettingsModalPr
181181
/>
182182
<p className="settingHint">
183183
Missing a cool data source? create an issue{' '}
184-
<a href="#" onClick={(_e) => window.open(supportLink, '_blank')}>
184+
<a href={supportLink} target="_blank" rel="noreferrer">
185185
here
186186
</a>
187187
</p>

0 commit comments

Comments
 (0)