Skip to content

Commit 2d4d638

Browse files
committed
feat: Simplify Firebase configuration by removing unused keys and adding build target
1 parent 9211342 commit 2d4d638

2 files changed

Lines changed: 6 additions & 34 deletions

File tree

src/config/index.tsx

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@ export const ANALYTICS_ENDPOINT = import.meta.env.VITE_AMPLITUDE_URL as string
33
export const ANALYTICS_SDK_KEY = import.meta.env.VITE_AMPLITUDE_KEY as string
44
export const API_ENDPOINT = import.meta.env.VITE_API_URL as string
55
export const LS_ANALYTICS_ID_KEY = 'hackerTabAnalyticsId'
6+
export const FIREBASE_API_KEY = import.meta.env.VITE_FIREBASE_API_KEY as string
7+
export const BUILD_TARGET = (import.meta.env.VITE_BUILD_TARGET as 'web' | 'extension') || 'web'
8+
69
// Meta
710
export const name = 'Hackertab.dev'
811
export const slogan = '— Stay updated with the new technology and trends'
@@ -50,12 +53,3 @@ export const dateRanges: DateRangeType[] = [
5053
{ label: 'the week', value: 'weekly' },
5154
{ label: 'the month', value: 'monthly' },
5255
]
53-
54-
export const FIREBASE_API_KEY = import.meta.env.VITE_FIREBASE_API_KEY as string
55-
export const FIREBASE_AUTH_DOMAIN = import.meta.env.VITE_FIREBASE_AUTH_DOMAIN as string
56-
export const FIREBASE_PROJECT_ID = import.meta.env.VITE_FIREBASE_PROJECT_ID as string
57-
export const FIREBASE_STORAGE_BUCKET = import.meta.env.VITE_FIREBASE_STORAGE_BUCKET as string
58-
export const FIREBASE_MESSAGING_SENDER_ID = import.meta.env
59-
.VITE_FIREBASE_MESSAGING_SENDER_ID as string
60-
export const FIREBASE_APP_ID = import.meta.env.VITE_FIREBASE_APP_ID as string
61-
export const FIREBASE_MEASUREMENT_ID = import.meta.env.VITE_FIREBASE_MEASUREMENT_ID as string

src/lib/firebase.ts

Lines changed: 3 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,13 @@
11
import { initializeApp } from 'firebase/app'
22
import { getAuth, GithubAuthProvider, GoogleAuthProvider } from 'firebase/auth'
3-
import {
4-
FIREBASE_API_KEY,
5-
FIREBASE_APP_ID,
6-
FIREBASE_AUTH_DOMAIN,
7-
FIREBASE_MEASUREMENT_ID,
8-
FIREBASE_MESSAGING_SENDER_ID,
9-
FIREBASE_PROJECT_ID,
10-
FIREBASE_STORAGE_BUCKET,
11-
} from 'src/config'
3+
import { FIREBASE_API_KEY } from 'src/config'
124

135
const firebaseConfig = {
146
apiKey: FIREBASE_API_KEY,
15-
authDomain: FIREBASE_AUTH_DOMAIN,
16-
projectId: FIREBASE_PROJECT_ID,
17-
storageBucket: FIREBASE_STORAGE_BUCKET,
18-
messagingSenderId: FIREBASE_MESSAGING_SENDER_ID,
19-
appId: FIREBASE_APP_ID,
20-
measurementId: FIREBASE_MEASUREMENT_ID,
217
}
228

23-
if (
24-
!FIREBASE_API_KEY ||
25-
!FIREBASE_APP_ID ||
26-
!FIREBASE_AUTH_DOMAIN ||
27-
!FIREBASE_MEASUREMENT_ID ||
28-
!FIREBASE_MESSAGING_SENDER_ID ||
29-
!FIREBASE_PROJECT_ID ||
30-
!FIREBASE_STORAGE_BUCKET
31-
) {
32-
console.warn('Missing Firebase configuration')
9+
if (!FIREBASE_API_KEY) {
10+
console.warn('Missing Firebase api Key')
3311
}
3412
// Initialize Firebase
3513
const app = initializeApp(firebaseConfig)

0 commit comments

Comments
 (0)