Skip to content

Commit 359269c

Browse files
committed
refactor: Replace button elements with CircleButton and Button components in Header and BookmarkSettings
1 parent c7d52a1 commit 359269c

2 files changed

Lines changed: 35 additions & 34 deletions

File tree

src/components/Layout/Header.tsx

Lines changed: 27 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { useEffect, useState } from 'react'
22
import { BsFillBookmarksFill, BsFillGearFill, BsMoonFill } from 'react-icons/bs'
33
import { CgTab } from 'react-icons/cg'
4-
import { FaUserLarge } from 'react-icons/fa6'
4+
import { FaUser } from 'react-icons/fa'
55
import { IoMdSunny } from 'react-icons/io'
66
import { MdDoDisturbOff } from 'react-icons/md'
77
import { RxArrowLeft } from 'react-icons/rx'
@@ -14,6 +14,7 @@ import { Changelog } from 'src/features/changelog'
1414
import { identifyUserTheme, trackDNDDisable, trackThemeSelect } from 'src/lib/analytics'
1515
import { useBookmarks } from 'src/stores/bookmarks'
1616
import { useUserPreferences } from 'src/stores/preferences'
17+
import { Button, CircleButton } from '../Elements'
1718

1819
export const Header = () => {
1920
const { openAuthModal, user, isConnected } = useAuth()
@@ -78,37 +79,37 @@ export const Header = () => {
7879
<Changelog />
7980
</span>
8081
<SearchBar />
81-
<div className="extras">
82+
<div className="buttonsFlex extras">
8283
{isDNDModeActive() && (
83-
<button className="extraBtn extraTextBtn" onClick={() => onUnpauseClicked()}>
84+
<Button onClick={onUnpauseClicked} className="dndButton">
8485
<MdDoDisturbOff />
85-
&nbsp;Unpause
86-
</button>
86+
Unpause
87+
</Button>
8788
)}
88-
<button aria-label="Open settings" className="extraBtn" onClick={onSettingsClick}>
89+
90+
<CircleButton onClick={onSettingsClick}>
8991
<BsFillGearFill />
90-
</button>
91-
<button
92-
aria-label="Toggle theme"
93-
className="extraBtn darkModeBtn"
94-
onClick={onThemeChange}>
92+
</CircleButton>
93+
<CircleButton onClick={onThemeChange} variant="darkfocus">
9594
{themeIcon}
96-
</button>
97-
<Link to="/settings/bookmarks" className="extraBtn" aria-label="Open bookmarks">
98-
<>
99-
<BsFillBookmarksFill />
100-
<BookmarksBadgeCount />
101-
</>
102-
</Link>
103-
{isConnected() ? (
104-
<Link to="/settings/profile" aria-label="Open profile">
95+
</CircleButton>
96+
<CircleButton onClick={() => navigate('/settings/bookmarks')}>
97+
<BsFillBookmarksFill />
98+
</CircleButton>
99+
<CircleButton
100+
onClick={() => {
101+
if (isConnected()) {
102+
navigate('/settings/profile')
103+
} else {
104+
openAuthModal()
105+
}
106+
}}>
107+
{isConnected() ? (
105108
<img className="profileImage" src={user?.imageURL} />
106-
</Link>
107-
) : (
108-
<button aria-label="open login" className="extraBtn" onClick={openAuthModal}>
109-
<FaUserLarge />
110-
</button>
111-
)}
109+
) : (
110+
<FaUser style={{ fontSize: '1.2em' }} />
111+
)}
112+
</CircleButton>
112113
</div>
113114
{location.pathname === '/' ? (
114115
<UserTags />

src/features/settings/components/BookmarkSettings/BookmarkSettings.tsx

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { useRef } from 'react'
22
import { BiBookmarkMinus } from 'react-icons/bi'
33
import { RiFileDownloadFill, RiFileUploadFill } from 'react-icons/ri'
44
import toast from 'react-simple-toasts'
5-
import { CardLink } from 'src/components/Elements'
5+
import { Button, CardLink, CircleButton } from 'src/components/Elements'
66
import { SettingsContentLayout } from 'src/components/Layout/SettingsContentLayout'
77
import { SUPPORTED_CARDS } from 'src/config/supportedCards'
88
import { BookmarkedPost } from 'src/features/bookmarks'
@@ -115,7 +115,7 @@ export const BookmarkSettings = () => {
115115
title="Bookmarks"
116116
description="Find all your bookmarks here. You can remove a bookmark by clicking on the remove icon."
117117
actions={
118-
<>
118+
<div className="buttonsFlex">
119119
<input
120120
type="file"
121121
id="file"
@@ -124,14 +124,14 @@ export const BookmarkSettings = () => {
124124
className="hidden"
125125
onChange={handleFileChange}
126126
/>
127-
<button className="extraBtn extraTextBtn" onClick={() => importBookmarks()}>
127+
<Button onClick={importBookmarks} className="dndButton">
128128
<RiFileUploadFill />
129-
&nbsp;Import
130-
</button>
131-
<button className="extraBtn" onClick={() => exportBookmarks()}>
129+
Import
130+
</Button>
131+
<CircleButton onClick={() => exportBookmarks()}>
132132
<RiFileDownloadFill />
133-
</button>
134-
</>
133+
</CircleButton>
134+
</div>
135135
}>
136136
<div className="bookmarks">
137137
{userBookmarks.map((bm) => (

0 commit comments

Comments
 (0)