Skip to content

Commit 47b371c

Browse files
committed
fix hardcoded values
1 parent 14ae043 commit 47b371c

5 files changed

Lines changed: 13 additions & 11 deletions

File tree

src/features/devtoCard/components/DevtoCard.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,15 +60,15 @@ export function DevtoCard({ withAds, meta }: CardPropsType) {
6060
const HeaderTitle = () => {
6161
return (
6262
<div style={{ display: 'inline-block', margin: 0, padding: 0 }}>
63-
<span> DevTo </span>
63+
<span> {meta.label} </span>
6464
<SelectableCard
6565
isLanguage={true}
6666
tagId={DT_MENU_LANGUAGE_ID}
6767
selectedTag={selectedTag}
6868
setSelectedTag={setSelectedTag}
6969
fallbackTag={GLOBAL_TAG}
7070
cardSettings={cardsSettings?.devto?.language}
71-
trackEvent={(tag: Tag) => trackCardLanguageSelect('Devto', tag.value)}
71+
trackEvent={(tag: Tag) => trackCardLanguageSelect(meta.analyticsTag, tag.value)}
7272
data={userSelectedTags.map((tag) => ({
7373
label: tag.label,
7474
value: tag.value,

src/features/freecodecampCard/components/FreecodecampCard.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export function FreecodecampCard({ meta, withAds }: CardPropsType) {
2121
if (selectedTag) {
2222
setCardSettings(meta.label.toLowerCase(), { language: selectedTag.label })
2323
}
24-
}, [selectedTag])
24+
}, [meta.label, setCardSettings, selectedTag])
2525

2626
const getQueryTags = () => {
2727
if (!selectedTag) {
@@ -68,7 +68,7 @@ export function FreecodecampCard({ meta, withAds }: CardPropsType) {
6868
setSelectedTag={setSelectedTag}
6969
fallbackTag={GLOBAL_TAG}
7070
cardSettings={cardsSettings?.devto?.language}
71-
trackEvent={(tag: Tag) => trackCardLanguageSelect('Devto', tag.value)}
71+
trackEvent={(tag: Tag) => trackCardLanguageSelect(meta.analyticsTag, tag.value)}
7272
data={userSelectedTags.map((tag) => ({
7373
label: tag.label,
7474
value: tag.value,

src/features/githubCard/components/GithubCard.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ export function GithubCard({ meta, withAds }: CardPropsType) {
9494
setSelectedTag={setSelectedTag}
9595
fallbackTag={GLOBAL_TAG}
9696
cardSettings={cardsSettings?.repos?.language}
97-
trackEvent={(tag: Tag) => trackCardLanguageSelect('Github', tag.value)}
97+
trackEvent={(tag: Tag) => trackCardLanguageSelect(meta.analyticsTag, tag.value)}
9898
data={userSelectedTags.map((tag) => ({
9999
label: tag.label,
100100
value: tag.value,
@@ -106,7 +106,9 @@ export function GithubCard({ meta, withAds }: CardPropsType) {
106106
selectedTag={selectedDateRange}
107107
setSelectedTag={setSelectedDateRange}
108108
fallbackTag={dateRanges[0]}
109-
trackEvent={(tag: DateRangeType) => trackCardDateRangeSelect('Github', tag.value)}
109+
trackEvent={(tag: DateRangeType) =>
110+
trackCardDateRangeSelect(meta.analyticsTag, tag.value)
111+
}
110112
cardSettings={cardsSettings?.repos?.dateRange}
111113
data={dateRanges}
112114
/>

src/features/hashnodeCard/components/HashnodeCard.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export function HashnodeCard({ withAds, meta }: CardPropsType) {
2121
if (selectedTag) {
2222
setCardSettings(meta.label.toLowerCase(), { language: selectedTag.label })
2323
}
24-
}, [selectedTag])
24+
}, [selectedTag, meta.label, setCardSettings])
2525

2626
const getQueryTags = () => {
2727
if (!selectedTag) {
@@ -60,15 +60,15 @@ export function HashnodeCard({ withAds, meta }: CardPropsType) {
6060
const HeaderTitle = () => {
6161
return (
6262
<div style={{ display: 'inline-block', margin: 0, padding: 0 }}>
63-
<span> Hashnode </span>
63+
<span> {meta.label} </span>
6464
<SelectableCard
6565
isLanguage={true}
6666
tagId={HN_MENU_LANGUAGE_ID}
6767
selectedTag={selectedTag}
6868
setSelectedTag={setSelectedTag}
6969
fallbackTag={GLOBAL_TAG}
7070
cardSettings={cardsSettings?.hashnode?.language}
71-
trackEvent={(tag: Tag) => trackCardLanguageSelect('Hashnode', tag.value)}
71+
trackEvent={(tag: Tag) => trackCardLanguageSelect(meta.analyticsTag, tag.value)}
7272
data={userSelectedTags.map((tag) => ({
7373
label: tag.label,
7474
value: tag.value,

src/features/mediumCard/components/MediumCard.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,15 +60,15 @@ export function MediumCard({ meta, withAds }: CardPropsType) {
6060
const HeaderTitle = () => {
6161
return (
6262
<div style={{ display: 'inline-block', margin: 0, padding: 0 }}>
63-
<span> Medium </span>
63+
<span> {meta.label} </span>
6464
<SelectableCard
6565
isLanguage={true}
6666
tagId={MEDIUM_MENU_LANGUAGE_ID}
6767
selectedTag={selectedTag}
6868
setSelectedTag={setSelectedTag}
6969
fallbackTag={GLOBAL_TAG}
7070
cardSettings={cardsSettings?.medium?.language}
71-
trackEvent={(tag: Tag) => trackCardLanguageSelect('Medium', tag.value)}
71+
trackEvent={(tag: Tag) => trackCardLanguageSelect(meta.analyticsTag, tag.value)}
7272
data={userSelectedTags.map((tag) => ({
7373
label: tag.label,
7474
value: tag.value,

0 commit comments

Comments
 (0)