Skip to content

Commit 4a3ac83

Browse files
committed
fix rss sources bookmarks
1 parent 8cad7f4 commit 4a3ac83

4 files changed

Lines changed: 22 additions & 21 deletions

File tree

src/components/Elements/CardWithActions/CardItemWithActions.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,23 @@
1-
import React, { useState, useEffect } from 'react'
1+
import React, { useEffect, useState } from 'react'
2+
import { BiBookmarkMinus, BiBookmarkPlus } from 'react-icons/bi'
3+
import { Attributes, trackLinkBookmark, trackLinkUnBookmark } from 'src/lib/analytics'
24
import { useBookmarks } from 'src/stores/bookmarks'
3-
import { BiBookmarkPlus } from 'react-icons/bi'
4-
import { BiBookmarkMinus } from 'react-icons/bi'
5-
import { trackLinkBookmark, trackLinkUnBookmark, Attributes } from 'src/lib/analytics'
65
import { BaseEntry } from 'src/types'
76

87
type CardItemWithActionsProps = {
98
item: BaseEntry
109
index: number
1110
source: string
1211
cardItem: React.ReactNode
12+
sourceType?: 'rss' | 'supported'
1313
}
1414

1515
export const CardItemWithActions = ({
1616
cardItem,
1717
item,
1818
index,
1919
source,
20+
sourceType = 'supported',
2021
}: CardItemWithActionsProps) => {
2122
const { bookmarkPost, unbookmarkPost, userBookmarks } = useBookmarks()
2223
const [isBookmarked, setIsBookmarked] = useState(
@@ -27,6 +28,7 @@ export const CardItemWithActions = ({
2728
title: item.title,
2829
url: item.url,
2930
source,
31+
sourceType: sourceType ?? 'rss',
3032
}
3133
if (isBookmarked) {
3234
unbookmarkPost(itemToBookmark)

src/features/bookmarks/components/BookmarksSidebar.tsx

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,24 @@
1-
import './Sidebar.css'
2-
import { VscChromeClose } from 'react-icons/vsc'
3-
import { TiDelete } from 'react-icons/ti'
41
import { HiTicket } from 'react-icons/hi'
5-
import { SiGithub, SiReddit, SiProducthunt, SiYcombinator } from 'react-icons/si'
2+
import { SiGithub, SiProducthunt, SiReddit, SiYcombinator } from 'react-icons/si'
3+
import { TiDelete } from 'react-icons/ti'
4+
import { VscChromeClose } from 'react-icons/vsc'
65
import {
7-
ProSidebar,
86
Menu,
97
MenuItem,
10-
SubMenu,
11-
SidebarHeader,
8+
ProSidebar,
129
SidebarContent,
10+
SidebarHeader,
11+
SubMenu,
1312
} from 'react-pro-sidebar'
1413
import 'react-pro-sidebar/dist/css/styles.css'
1514
import { CardLink } from 'src/components/Elements'
16-
import { trackLinkUnBookmark, Attributes } from 'src/lib/analytics'
15+
import { Attributes, trackLinkUnBookmark } from 'src/lib/analytics'
1716
import { useBookmarks } from 'src/stores/bookmarks'
17+
import { BookmarkedPost } from '../types'
18+
import './Sidebar.css'
1819

1920
type BookmarkItemProps = {
20-
item: {
21-
url: string
22-
title: string
23-
source: string
24-
}
21+
item: BookmarkedPost
2522
appendRef?: boolean
2623
}
2724
const BookmarkItem = ({ item, appendRef = true }: BookmarkItemProps) => {
@@ -71,7 +68,7 @@ export const BookmarksSidebar = ({ showSidebar, onClose }: BookmarksSidebarTtype
7168
'freecodecamp',
7269
'medium',
7370
'indiehackers',
74-
].indexOf(bm.source) !== -1
71+
].indexOf(bm.source) !== -1 || bm.sourceType === 'rss'
7572
)
7673
const conferencesBookmarks = userBookmarks.filter((bm) => bm.source === 'conferences')
7774
const productsBookmarks = userBookmarks.filter((bm) => bm.source === 'producthunt')
Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
export type BookmarkedPost = {
2-
title: string,
3-
source: string,
4-
url: string;
2+
title: string
3+
source: string
4+
url: string
5+
sourceType: 'rss' | 'supported'
56
}

src/features/cards/components/customRssCard/ArticleItem.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ const ArticleItem = (props: BaseItemPropsType<Article>) => {
1212
return (
1313
<CardItemWithActions
1414
source={analyticsTag}
15+
sourceType="rss"
1516
index={index}
1617
key={index}
1718
item={item}

0 commit comments

Comments
 (0)